[2/7] dt-bindings: arm: qcom: Document samsung,milletwifi device

Message ID 20231105204759.37107-3-bryant@mai.rs
State New
Headers
Series Add samsung-milletwifi |

Commit Message

Bryant Mairs Nov. 5, 2023, 8:46 p.m. UTC
  Add binding documentation for Samsung Galaxy Tab 4 8.0 Wi-Fi
tablet which is based on Snapdragon 400 (apq8026) SoC.

Signed-off-by: Bryant Mairs <bryant@mai.rs>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Krzysztof Kozlowski Nov. 6, 2023, 7:37 a.m. UTC | #1
On 05/11/2023 21:46, Bryant Mairs wrote:
> Add binding documentation for Samsung Galaxy Tab 4 8.0 Wi-Fi
> tablet which is based on Snapdragon 400 (apq8026) SoC.
> 
> Signed-off-by: Bryant Mairs <bryant@mai.rs>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 88b84035e7b1..c66980b79f59 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -156,6 +156,7 @@ properties:
>                - huawei,sturgeon
>                - lg,lenok
>                - samsung,matisse-wifi
> +              - samsung,milletwifi

Not millet-wifi like the other one?

Best regards,
Krzysztof
  
Bryant Mairs Nov. 6, 2023, 8:07 a.m. UTC | #2
Sending again in plain text, sorry about that!

-----
That's a good question. Note that there is also samsung-matisselte, so I wasn't certain what the policy was on naming, which is why I deferred to the manufacturer naming scheme, which seems to be the most common approach.

On Mon, Nov 6, 2023, at 08:37, Krzysztof Kozlowski wrote:
> On 05/11/2023 21:46, Bryant Mairs wrote:
> > Add binding documentation for Samsung Galaxy Tab 4 8.0 Wi-Fi
> > tablet which is based on Snapdragon 400 (apq8026) SoC.
> > 
> > Signed-off-by: Bryant Mairs <bryant@mai.rs>
> > ---
> >  Documentation/devicetree/bindings/arm/qcom.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> > index 88b84035e7b1..c66980b79f59 100644
> > --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> > +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> > @@ -156,6 +156,7 @@ properties:
> >                - huawei,sturgeon
> >                - lg,lenok
> >                - samsung,matisse-wifi
> > +              - samsung,milletwifi
> 
> Not millet-wifi like the other one?
> 
> Best regards,
> Krzysztof
> 
>
  

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 88b84035e7b1..c66980b79f59 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -156,6 +156,7 @@  properties:
               - huawei,sturgeon
               - lg,lenok
               - samsung,matisse-wifi
+              - samsung,milletwifi
           - const: qcom,apq8026
 
       - items: