From patchwork Fri Nov 3 06:15:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Jeffery X-Patchwork-Id: 161161 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp830955vqu; Thu, 2 Nov 2023 23:16:45 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEBm4HYd5I7BPsrB072qEtBvW4qeDg5wR9520n/IbrCubqH9U3Fq2mcr8LmBr6Lj2Hb4wic X-Received: by 2002:a17:90b:3597:b0:27d:880d:8645 with SMTP id mm23-20020a17090b359700b0027d880d8645mr17411319pjb.49.1698992205733; Thu, 02 Nov 2023 23:16:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698992205; cv=none; d=google.com; s=arc-20160816; b=bA46UraUH7dMRz5EVJt5t1LdyHtEW1AL6errlTVkUrQuHTlJDvAKMhL17cSBmz+JIH LqHGRStu1s09b8ZNw7sGx6EG1DCTIi5TBP31fjid9rkgxiZQMT/bPHZPV6ZUsm954k9X shuM2NS1V2esEUTRNfOjeO4xs/hh/KtbzVNkHsc916hM0zG6fqZgUK5jqwGQ+1O40s+u 8LOxhd/o8Nhc1Th0Y/IvzHBBuaBQqjzVUi9Y/teUmjitz7TSPJgx8xpJ3s05Soa/pR1T snomf7T/OpEgyB4ItrgtgHwCtICI8v5j5VL5QpR5DqCxZRlCSVOX7/CCW6bfgLvocVLJ mXyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hYHyullC4OIb5ueKBUtHARoDjsv8sC0z5UpD23psbTg=; fh=J5fZGSGUmoD0NT+ZfFkgng7qPhvONoMGdVOrNctU85A=; b=pjRu+04xAtiQU35Y+oukkDWbq2vP9EqaOA3foIEsqA4cpYlr9Hm0MYvZwYQ+VkUaxK t5SZUOFa2abjfCTuuVjNivTyJ0qMnGij4Af4owpsnWt2D4sNC199E7fovcVTPkAXg4fj 4G57WknwIBshCMWScvj+lypJoUQFDkVYi0yI+xpUp69ahdHAErpmG3RmN9awNvgbwn7c 9r6jg7N+G5zpaGyhrEf+aV1GMQcI34A9tJf6kHhLakylC6u1uTvaKiYnJjW9+dJUSy6u r8/ZUSxKGMJWuePoruxvBeXM9R5kfcmJ9gckR1rW4gIv13ov8WTJP0tHgJs4Gs9IM3ku DDjw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=lKLQuGem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id pg13-20020a17090b1e0d00b00277651787f1si1044371pjb.145.2023.11.02.23.16.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 23:16:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@codeconstruct.com.au header.s=2022a header.b=lKLQuGem; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=codeconstruct.com.au Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id B19B1811F927; Thu, 2 Nov 2023 23:16:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231220AbjKCGP6 (ORCPT + 36 others); Fri, 3 Nov 2023 02:15:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230314AbjKCGPs (ORCPT ); Fri, 3 Nov 2023 02:15:48 -0400 Received: from codeconstruct.com.au (pi.codeconstruct.com.au [203.29.241.158]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E45B41B4 for ; Thu, 2 Nov 2023 23:15:41 -0700 (PDT) Received: from localhost.localdomain (ppp14-2-79-67.adl-apt-pir-bras31.tpg.internode.on.net [14.2.79.67]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id A4F7D201C3; Fri, 3 Nov 2023 14:15:39 +0800 (AWST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1698992140; bh=hYHyullC4OIb5ueKBUtHARoDjsv8sC0z5UpD23psbTg=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=lKLQuGemKmw5voq2rUsfzBHn00UX+Y/HnEtbLYNqvN9CseaRxwuOjIHs7hHv9nU17 1E7Egh94J5i3ygDC9uJZktBIr99HafQqZVBDpCnlta1lT6Pvp8sFgZSnkr2aFDP8za zc7oTfZAGpYs9YOf6/q+NZPBnGwPPKhrBVPn+5ULR+8x0FHqFxWxAgD24g5SaHzGW3 zRjkqz+W+5VxcdrECFjyv/Ds8UsXttu2lfr3OKqezPbOCEV/rWM/I/3QPG9SE3b7Ku tW3yISYZM6PmsEguqM8j2YhbfC2qvWaZAumTj9iY2XLk1MaPNvyZeMq2Ydf3+A7WuR yyZQ9zdtGTn+Q== From: Andrew Jeffery To: minyard@acm.org, openipmi-developer@lists.sourceforge.net Cc: Andrew Jeffery , linux-kernel@vger.kernel.org, Jonathan.Cameron@Huawei.com, aladyshev22@gmail.com, jk@codeconstruct.com.au Subject: [PATCH 03/10] ipmi: kcs_bmc: Make kcs_bmc_update_event_mask() static Date: Fri, 3 Nov 2023 16:45:15 +1030 Message-Id: <20231103061522.1268637-4-andrew@codeconstruct.com.au> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231103061522.1268637-1-andrew@codeconstruct.com.au> References: <20231103061522.1268637-1-andrew@codeconstruct.com.au> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 23:16:05 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781522450874365410 X-GMAIL-MSGID: 1781522450874365410 There were no users outside the subsystem core, so let's not expose it. Signed-off-by: Andrew Jeffery --- drivers/char/ipmi/kcs_bmc.c | 11 +++++------ drivers/char/ipmi/kcs_bmc_client.h | 2 -- 2 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/char/ipmi/kcs_bmc.c b/drivers/char/ipmi/kcs_bmc.c index a429d9f8a7bf..1a827db8a465 100644 --- a/drivers/char/ipmi/kcs_bmc.c +++ b/drivers/char/ipmi/kcs_bmc.c @@ -68,6 +68,11 @@ irqreturn_t kcs_bmc_handle_event(struct kcs_bmc_device *kcs_bmc) } EXPORT_SYMBOL(kcs_bmc_handle_event); +static void kcs_bmc_update_event_mask(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 events) +{ + kcs_bmc->ops->irq_mask_update(kcs_bmc, mask, events); +} + int kcs_bmc_enable_device(struct kcs_bmc_device *kcs_bmc, struct kcs_bmc_client *client) { int rc; @@ -178,12 +183,6 @@ void kcs_bmc_unregister_driver(struct kcs_bmc_driver *drv) } EXPORT_SYMBOL(kcs_bmc_unregister_driver); -void kcs_bmc_update_event_mask(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 events) -{ - kcs_bmc->ops->irq_mask_update(kcs_bmc, mask, events); -} -EXPORT_SYMBOL(kcs_bmc_update_event_mask); - MODULE_LICENSE("GPL v2"); MODULE_AUTHOR("Haiyue Wang "); MODULE_AUTHOR("Andrew Jeffery "); diff --git a/drivers/char/ipmi/kcs_bmc_client.h b/drivers/char/ipmi/kcs_bmc_client.h index 6fdcde0a7169..814ad8e052ef 100644 --- a/drivers/char/ipmi/kcs_bmc_client.h +++ b/drivers/char/ipmi/kcs_bmc_client.h @@ -35,8 +35,6 @@ void kcs_bmc_unregister_driver(struct kcs_bmc_driver *drv); int kcs_bmc_enable_device(struct kcs_bmc_device *kcs_bmc, struct kcs_bmc_client *client); void kcs_bmc_disable_device(struct kcs_bmc_device *kcs_bmc, struct kcs_bmc_client *client); -void kcs_bmc_update_event_mask(struct kcs_bmc_device *kcs_bmc, u8 mask, u8 events); - u8 kcs_bmc_read_data(struct kcs_bmc_device *kcs_bmc); void kcs_bmc_write_data(struct kcs_bmc_device *kcs_bmc, u8 data); u8 kcs_bmc_read_status(struct kcs_bmc_device *kcs_bmc);