Message ID | 20231102152033.5511-3-duje.mihanovic@skole.hr |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp429567vqu; Thu, 2 Nov 2023 08:21:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWCEJXCCuSH7WimsVYx0Gh7koRIGDBOWI3ebLj6XyBL3FYkQpzze7E4YqoXJvBHLF5WtNq X-Received: by 2002:a17:902:6b0c:b0:1ca:2ec4:7f38 with SMTP id o12-20020a1709026b0c00b001ca2ec47f38mr14428550plk.17.1698938480012; Thu, 02 Nov 2023 08:21:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698938480; cv=none; d=google.com; s=arc-20160816; b=jNNdTy8DmQDB8pzlSreCl3Bnb1w/wp2j8sVQF3jYreFucfzUX+oTAjaN4g4IiwNnVX 6w4okox/yq1GJwFKQDU2+5RXH6V8qYJbxvumYZi8iA7T/Oc3XbQ8LzcBaI5D+iiy3YlV luUw85ceMnxAZbSNM+uJpFb9dSoz6iZ8iEq8OAQlWcQWqT98rKgQAECapgSFuwlb78cH gpou2LL4ISt9m/u+NJVkG+UfDYEmZmRwR6WTlaeoLQCHpT4ljRxrK+N9dbknG9jielYJ WhqaWSrGAxrXBe1pQJDN1fByn/fJ/3XrN6nahgMNSYTfbSg42vUmBfUtcs8GaNN1vpf0 i6Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=9TYvknXIUsiR11+Kc42MHUFnNYj/g1xJB4J4MAonUCk=; fh=IDvgtJApayGNh1AEN9UG5NN1MoYSb7Pv9wTa711YuN0=; b=IF4EfnIcsjMcJhfPEVIidJJCtZ/UFS1flq2jdUGWc45JpCzWUHwyG9dZbEG+fKZ0rY uCId2PB0do1WlZP0ecU6oDr4qP+QrYvq8unM6XBBi6CwD50/FoM76aVUcbQqLEoBcf/s KF4+eOlpIeFLPKzTx3eKRpaDJ1hekDIxweKqA/iNuyPuDXJAd6HuWpiLN2/3olA1q5a9 bQrVKGhXAxQxROg8fMUAmtMxBILzaoeS/q2HJZhrE0rUoMkvdeZ584hXcN5hry4MhcX8 BdK/PQt1oQXGVny1uWVm3DrCo0sTn/6f0fpge8KKWUbgyP0xyQLeCmBXe/iXiQlE9E9t j7sg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id n5-20020a170902e54500b001c72699dcd3si29860plf.367.2023.11.02.08.21.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 08:21:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id B41DB817ABC8; Thu, 2 Nov 2023 08:21:16 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346501AbjKBPVM (ORCPT <rfc822;heyuhang3455@gmail.com> + 35 others); Thu, 2 Nov 2023 11:21:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56208 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347525AbjKBPVG (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 2 Nov 2023 11:21:06 -0400 Received: from mx.skole.hr (mx1.hosting.skole.hr [161.53.165.185]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78B521AC; Thu, 2 Nov 2023 08:20:57 -0700 (PDT) Received: from mx1.hosting.skole.hr (localhost.localdomain [127.0.0.1]) by mx.skole.hr (mx.skole.hr) with ESMTP id 1CE3683668; Thu, 2 Nov 2023 16:20:56 +0100 (CET) From: =?utf-8?q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr> To: Michael Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Tony Lindgren <tony@atomide.com>, =?utf-8?q?Duje_Mihanovi=C4=87?= <duje.mihanovic@skole.hr>, Daniel Mack <daniel@zonque.org>, Haojian Zhuang <haojian.zhuang@gmail.com>, Robert Jarzmik <robert.jarzmik@free.fr>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Leo Yan <leoy@marvell.com>, Zhangfei Gao <zhangfei.gao@marvell.com>, Lubomir Rintel <lkundrak@v3.sk>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Kees Cook <keescook@chromium.org>, Tony Luck <tony.luck@intel.com>, "Guilherme G . Piccoli" <gpiccoli@igalia.com> Cc: linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, alsa-devel@alsa-project.org, linux-hardening@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, Karel Balej <balejk@matfyz.cz> Subject: [PATCH v7 08/10] arm64: Kconfig.platforms: Add config for Marvell PXA1908 platform Date: Thu, 2 Nov 2023 16:20:31 +0100 Message-ID: <20231102152033.5511-3-duje.mihanovic@skole.hr> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231102152033.5511-1-duje.mihanovic@skole.hr> References: <20231102152033.5511-1-duje.mihanovic@skole.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Thu, 02 Nov 2023 08:21:16 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781466115414421777 X-GMAIL-MSGID: 1781466115414421777 |
Series |
Initial Marvell PXA1908 support
|
|
Commit Message
Duje Mihanović
Nov. 2, 2023, 3:20 p.m. UTC
Add ARCH_MMP configuration option for Marvell PXA1908 SoC.
Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr>
---
arch/arm64/Kconfig.platforms | 11 +++++++++++
1 file changed, 11 insertions(+)
Comments
On 2023-11-02 3:20 pm, Duje Mihanović wrote: > Add ARCH_MMP configuration option for Marvell PXA1908 SoC. > > Signed-off-by: Duje Mihanović <duje.mihanovic@skole.hr> > --- > arch/arm64/Kconfig.platforms | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms > index 6069120199bb..b417cae42c84 100644 > --- a/arch/arm64/Kconfig.platforms > +++ b/arch/arm64/Kconfig.platforms > @@ -89,6 +89,17 @@ config ARCH_BERLIN > help > This enables support for Marvell Berlin SoC Family > > +config ARCH_MMP > + bool "Marvell MMP SoC Family" > + select ARM_GIC > + select ARM_ARCH_TIMER > + select ARM_SMMU NAK, not only is selecting user-visible symbols generally frowned upon, and ignoring their dependencies even worse, but for a multiplatform kernel the user may well want this to be a module. If having the SMMU driver built-in is somehow fundamentally required for this platform to boot, that would represent much bigger problems. Thanks, Robin. > + select MMP_PDMA > + select PINCTRL_SINGLE > + help > + This enables support for Marvell MMP SoC family, currently > + supporting PXA1908 aka IAP140. > + > config ARCH_BITMAIN > bool "Bitmain SoC Platforms" > help
On Friday, November 3, 2023 4:34:54 PM CET Robin Murphy wrote: > On 2023-11-02 3:20 pm, Duje Mihanović wrote: > > +config ARCH_MMP > > + bool "Marvell MMP SoC Family" > > + select ARM_GIC > > + select ARM_ARCH_TIMER > > + select ARM_SMMU > > NAK, not only is selecting user-visible symbols generally frowned upon, > and ignoring their dependencies even worse, but for a multiplatform > kernel the user may well want this to be a module. > > If having the SMMU driver built-in is somehow fundamentally required for > this platform to boot, that would represent much bigger problems. The SoC can boot without SMMU and PDMA, but not GIC, pinctrl or the arch timer. I see that most other SoCs still select drivers and frameworks they presumably need for booting, with the exceptions of ARCH_BITMAIN, ARCH_LG1K and a couple others. Which of these two options should I go for? Regards, Duje
On 2023-11-03 5:02 pm, Duje Mihanović wrote: > On Friday, November 3, 2023 4:34:54 PM CET Robin Murphy wrote: >> On 2023-11-02 3:20 pm, Duje Mihanović wrote: >>> +config ARCH_MMP >>> + bool "Marvell MMP SoC Family" >>> + select ARM_GIC >>> + select ARM_ARCH_TIMER >>> + select ARM_SMMU >> >> NAK, not only is selecting user-visible symbols generally frowned upon, >> and ignoring their dependencies even worse, but for a multiplatform >> kernel the user may well want this to be a module. >> >> If having the SMMU driver built-in is somehow fundamentally required for >> this platform to boot, that would represent much bigger problems. > > The SoC can boot without SMMU and PDMA, but not GIC, pinctrl or the arch > timer. I see that most other SoCs still select drivers and frameworks they > presumably need for booting, with the exceptions of ARCH_BITMAIN, ARCH_LG1K > and a couple others. Which of these two options should I go for? Well, you don't really need to select ARM_GIC or ARM_ARCH_TIMER here either, since those are already selected by ARM64 itself. Keeping PINCTRL_SINGLE is fair, although you should also select PINCTRL as its dependency. As an additional nit, the file seems to be primarily ordered by symbol name, so it might be nice to slip ARCH_MMC in between ARCH_MESON and ARCH_MVEBU. Cheers, Robin.
diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 6069120199bb..b417cae42c84 100644 --- a/arch/arm64/Kconfig.platforms +++ b/arch/arm64/Kconfig.platforms @@ -89,6 +89,17 @@ config ARCH_BERLIN help This enables support for Marvell Berlin SoC Family +config ARCH_MMP + bool "Marvell MMP SoC Family" + select ARM_GIC + select ARM_ARCH_TIMER + select ARM_SMMU + select MMP_PDMA + select PINCTRL_SINGLE + help + This enables support for Marvell MMP SoC family, currently + supporting PXA1908 aka IAP140. + config ARCH_BITMAIN bool "Bitmain SoC Platforms" help