From patchwork Thu Nov 2 15:12:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 160931 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:8f47:0:b0:403:3b70:6f57 with SMTP id j7csp424103vqu; Thu, 2 Nov 2023 08:13:50 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFhtUw/QAMcMD9/AoMzx3JYkLIO7VVEPY6CUrOvCHg7f5YmLLzXR1egLPexruO1H2ROLuTR X-Received: by 2002:a05:6a20:e101:b0:181:b23a:b88c with SMTP id kr1-20020a056a20e10100b00181b23ab88cmr1615379pzb.49.1698938029921; Thu, 02 Nov 2023 08:13:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698938029; cv=none; d=google.com; s=arc-20160816; b=eukbJqrhzNG0slH6dPOAStqbeClVJlGsVbj3m32jrwL0xGLxsfO0fEz1TLV8whaqtP XcijB5HnAfQt5QnMymoDud9rO5k428rMiwx/tzl6QuLxOnU6CUDKr6ZhVf8p5QQgqnJf hr8BVdREnrDH2JwKXFpfCVPKRymj2IvInRLHSwYkVVW7FjfJHgc7zsbo3Qtx5Hw5Yo2U 6Eun/BLMfwT5lWY5cTHWe7KmPQ3DO0MN5cKzSzg9ygSGYV/ZTK+4JaHEKj6MQ7nEvpqz uQ0F/Lwmn4fBGC2adS/Lcd8Vo61Oak6ln1M1grSGbkFm9d0dQw8+IJU9qRuU+hqQ3gvk g/kA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oIMmKySKw7gyB97KpcVj84ElMUCRTot2jwvs7fLC70o=; fh=V5ywgBf85rQkHF36Ko7g9kTUFkdCX9ky0xG0tyEYPww=; b=ZF1ry8KQ1jh+/FnMSBC1fiOz0Wy0r8L4VDtTevou1//h2LBdYASudEhKXz+5RD8Rpz eyQdWvexytfx1FnKvxI2afs2mV9uQZJLNUQ4KqzyKpqt9cXmxXxu8LPtXsdVb073au4j Kbi+QNSilgB5QDFKshd4YoJ5KlB/IX8dzQr7pBaMRSozBN7jFDv8MdB6iYygpAt+3zYC 0qZyWYr2m4eD9mv9DYzpkuYKkfBTZnHPPlw4mJRx6saiTqBNIKPNlDSA+uBHOsHeu+74 6R8StHMRonHNFmDEOVNrIJGTjZ9cW9VyhFwBtHRMroA+cc4cij2I42pj1byx/c/e872j qRXA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MjE6fIh4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id r20-20020a6560d4000000b005b8edc44692si1872799pgv.721.2023.11.02.08.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Nov 2023 08:13:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=MjE6fIh4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id E0873826DBC5; Thu, 2 Nov 2023 08:13:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346324AbjKBPNb (ORCPT + 35 others); Thu, 2 Nov 2023 11:13:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42562 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346685AbjKBPMz (ORCPT ); Thu, 2 Nov 2023 11:12:55 -0400 Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FF7F194 for ; Thu, 2 Nov 2023 08:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698937966; x=1730473966; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GllTeDr5X3asel3oBTv59ZoUHW/F9FWypvBlv9MLNPM=; b=MjE6fIh4ikPtKaBX47Ba5LzOYVic2HPIDI8hYHAcLnt1RWc1QxGXVTtk PVdzgIr4YswHxJ9DgCCNryT/ZxBnRAakcXP6JRVP8vaI60VCjwHcw+W3u 1RbcUa4UYOBNVgXng2E2nRdmtTywDt8zyjHVXVagRC8Ic6oefdxv0CA+z B96tS/LvnH5dHx8V0rmhpdC2iwjUFdl7Dw/PmMOZPAcxXY/f3em6C2pL2 qRZ+XSK9v6tRzQEiaoVyxrzsAmdP6Rs6Jb8Ds81FXE0/vfgtenop7OEVz e8CDIAgChpJSpi66sanXDp/qHMoFWTGKEopFh0r9ajMN8ekkqz6u3uejK g==; X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="373773467" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="373773467" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2023 08:12:40 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10882"; a="711174070" X-IronPort-AV: E=Sophos;i="6.03,271,1694761200"; d="scan'208";a="711174070" Received: from black.fi.intel.com ([10.237.72.28]) by orsmga003.jf.intel.com with ESMTP; 02 Nov 2023 08:12:36 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id E881D65B; Thu, 2 Nov 2023 17:12:30 +0200 (EET) From: Andy Shevchenko To: Jani Nikula , Andy Shevchenko , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Hans de Goede , Andi Shyti Subject: [PATCH v3 08/15] drm/i915/dsi: Replace check with a (missing) MIPI sequence name Date: Thu, 2 Nov 2023 17:12:21 +0200 Message-Id: <20231102151228.668842-9-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231102151228.668842-1-andriy.shevchenko@linux.intel.com> References: <20231102151228.668842-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 02 Nov 2023 08:13:39 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781465643761084290 X-GMAIL-MSGID: 1781465643761084290 Names of the MIPI sequence steps are sequential and defined, no need to check for the gaps. However in seq_name the MIPI_SEQ_END is missing. Add it there, and drop unneeded NULL check in sequence_name(). Reviewed-by: Andi Shyti Signed-off-by: Andy Shevchenko --- drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c index 4ed5ede9ec5b..d270437217b3 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c @@ -653,6 +653,7 @@ static const fn_mipi_elem_exec exec_elem[] = { */ static const char * const seq_name[] = { + [MIPI_SEQ_END] = "MIPI_SEQ_END", [MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET", [MIPI_SEQ_INIT_OTP] = "MIPI_SEQ_INIT_OTP", [MIPI_SEQ_DISPLAY_ON] = "MIPI_SEQ_DISPLAY_ON", @@ -668,7 +669,7 @@ static const char * const seq_name[] = { static const char *sequence_name(enum mipi_seq seq_id) { - if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id]) + if (seq_id < ARRAY_SIZE(seq_name)) return seq_name[seq_id]; return "(unknown)";