From patchwork Wed Nov 1 21:37:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 160683 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:abcd:0:b0:403:3b70:6f57 with SMTP id f13csp724270vqx; Wed, 1 Nov 2023 14:38:17 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFNTp1Mz8mLb46GRHVp6GdUbhvDfUo4Wj9MUlznReq5id7VjmuObe/tlHiXPsi+AtxbxC1g X-Received: by 2002:a05:6a21:7189:b0:180:e069:581e with SMTP id wq9-20020a056a21718900b00180e069581emr7408479pzb.54.1698874696830; Wed, 01 Nov 2023 14:38:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698874696; cv=none; d=google.com; s=arc-20160816; b=zA3teYDwZrQrMhHKEGUoXgSHYroPtGGB6bmh4RkNWiEsiPgPYA6k6K5NH8v8xk4xlk /j74hWj9jkE9WUQAppz254ZSwZp0w7YePsZng8MDneBN2L3xk57l4TbWSo9S+GITyO5A oxCww3mL9BF7QCLTPrzqscipwVoUWmMa1erFpMb7SPQGP7dn4Pv/j4X0Qb4DlsT8UoWU o2rMKxXc1iWoAq4ODwhvzXz31gAXFKi9HTpLfxpNtJis4KALi6v+9ULr2YX1RC2RnvRX /ahYLFEt9cddKY2a1FsPdnVQ5lmQDkZa3MDb34ONIGHzXBLxCm3trES/PQ5L+cqJZNY6 lc6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=C27mSfTYC82A157L508cpU3kw+0R/dM9U8H3mGnYwEE=; fh=cY9HGbp9RiQ9xCYqjybSe1/cIiXVFs0Cn9z6ge1iyyY=; b=JMoER3JkS+kgUV2suc6sFfCpuB7C7jy+xdNsDvdZqj2QZgYpAoD1EZA663RNA5m8tz J6m+X4X8ZT6LDm0GP+33/rNK1HLnbrtlTOxqG5PwIa+wMRZb5CI4XAGwRHaKlK820dmn Q9xsYwFQrMSOGBFEu34F7UDy9WjDOFFfp476DWNFvgWuhNhZnbRBDcyYJESr3Au8IidE oRPA7+VVrFfnAYoR1DaOZFa54LMY+GM+OL5y6ia9frporgrSa1xgtW1kOw78ipRgSX1r xSM3AKYy2OI4j8f/pe3H83EQ3a1BP81UWqMNPhQGomm6WHDx2vFv5p5ujhmdPIirLNxi r9Qw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id h4-20020a170902f54400b001cc5505fff4si4112696plf.257.2023.11.01.14.38.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 14:38:16 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id CB403819477D; Wed, 1 Nov 2023 14:38:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345928AbjKAViJ (ORCPT + 35 others); Wed, 1 Nov 2023 17:38:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345726AbjKAViF (ORCPT ); Wed, 1 Nov 2023 17:38:05 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7DC8711D for ; Wed, 1 Nov 2023 14:38:03 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2E44BC433CB; Wed, 1 Nov 2023 21:38:03 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qyIuY-00EdX7-0g; Wed, 01 Nov 2023 17:38:02 -0400 Message-ID: <20231101213802.017038744@goodmis.org> User-Agent: quilt/0.66 Date: Wed, 01 Nov 2023 17:37:20 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton Subject: [for-next][PATCH 02/12] eventfs: Remove extra dget() in eventfs_create_events_dir() References: <20231101213718.381015321@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 14:38:15 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781399234183221200 X-GMAIL-MSGID: 1781399234183221200 From: "Steven Rostedt (Google)" The creation of the top events directory does a dget() at the end of the creation in eventfs_create_events_dir() with a comment saying the final dput() will happen when it is removed. The problem is that a dget() is already done on the dentry when it was created with tracefs_start_creating()! The dget() now just causes a memory leak of that dentry. Remove the extra dget() as the final dput() in the deletion of the events directory actually matches the one in tracefs_start_creating(). Link: https://lore.kernel.org/linux-trace-kernel/20231031124229.4f2e3fa1@gandalf.local.home Cc: Masami Hiramatsu Cc: Mark Rutland Fixes: 5790b1fb3d672 ("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Steven Rostedt (Google) --- fs/tracefs/event_inode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 4d2da7480e5f..5536860eb2ff 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -774,9 +774,6 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry fsnotify_mkdir(dentry->d_parent->d_inode, dentry); tracefs_end_creating(dentry); - /* Will call dput when the directory is removed */ - dget(dentry); - return ei; fail: