From patchwork Wed Nov 1 13:13:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kieran Bingham X-Patchwork-Id: 160544 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:abcd:0:b0:403:3b70:6f57 with SMTP id f13csp409031vqx; Wed, 1 Nov 2023 06:14:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFPehirgeyiNONYfGGvFqaR/8C9OaSPtuxL+uDC9K8rsumGT0KRkwcjQXyuz1f0tmay1KE+ X-Received: by 2002:a05:6358:186:b0:168:e3e1:11d5 with SMTP id d6-20020a056358018600b00168e3e111d5mr20958593rwa.28.1698844492833; Wed, 01 Nov 2023 06:14:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698844492; cv=none; d=google.com; s=arc-20160816; b=evRejUCOhzO8jmL3B02f3E1Z1nxcUyIJgqjTSOSdiNoI1UYgyKIeC6rDfoYRbePHXe UDoozlXu/N8dkuqwGIz9OTGGneecM0xjHh51P0Bpg4QUT+UWAVjJGVkema63kfcgAtGv hNBcD/ova069b2PevDlzTnlSwrAtj9yAvOyhl+RAOmW4QSAxTcbd++azs3mMSAV5enf4 ui/BG/lMhuvoduh2pyLFBrDbBYUwCT2ufi7hrhi9RU+LeKKv6QdGI8p+MAr/w9il8rHL EOiKXdZkpgnJMPs3U5xSib6YljUfFQxLSuZEwnpcBs4Ihvsx7KDrNkkV5tomA8bOIFoj 4uQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9jJMnq3t911vjpLlhC9Pko3KkWJTvBKgH70qvh9LHJE=; fh=L7bdhVUSRGewbZGUqR4L3H+66lE0SlV2odlkQU7WUEM=; b=uoUI8gvTw87wcEcgNM0ym4KqVMOx4B/gQ2X8ylC6DwHGtv/hOrN9hwHq4q9JOOCMH7 m9WtI6v9ktDsELztFfXQTunAsT3Fc2WdvhJzDIEGnE1ZtfyVfx+xYdukZR61GLmgvSqq p8e8QddStkThlBVbUSSXBeZkVRWliiSVYmbrx1m22Y7lo33p5hdmlWK9pk5cA2ay2MOP Nm/ophQJZYSzqjlnfYVaFeQVY3PbEHwCnoeXOLkfxJ6htZ8ZDdhtfx8f/Sf7GV4aL6LL FmAiKFAtn7eVXVBYh5CMmO8MumAhKe3g27tVmYyCGVfS36EedtK9m0LVU8AriFRT38CQ jrug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=hvQ3tiua; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id j69-20020a638048000000b00578e98dec9dsi3034391pgd.160.2023.11.01.06.14.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Nov 2023 06:14:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=hvQ3tiua; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6238F80E7116; Wed, 1 Nov 2023 06:14:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344163AbjKANO3 (ORCPT + 35 others); Wed, 1 Nov 2023 09:14:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36642 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344123AbjKANOY (ORCPT ); Wed, 1 Nov 2023 09:14:24 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED220126; Wed, 1 Nov 2023 06:14:17 -0700 (PDT) Received: from Monstersaurus.local (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id F29551BAE; Wed, 1 Nov 2023 14:13:45 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1698844426; bh=d0d7Rf2i4W+OeBaDehCuPFL1ycw0UNOszMGw/ErkDB8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hvQ3tiuanR7IGruQnZLms19/RyFFkoyLbgtZ/Ugcq/iB1EnKF1uE0r0SnQg5IWxpq 1f+VBdOGgrRCaF7D3LbCGBDLlQ5ju+kej4KR8hYsoASkvMv5/cKR7jBR7zRiFnRrar xKRUgYfb2x5k9xNlTqRhzFqaAvgpbk+bDzmHK2+M= From: Kieran Bingham To: devicetree@vger.kernel.org, linux-media@vger.kernel.org Cc: Kieran Bingham , Umang Jain , "Paul J. Murphy" , Daniele Alessandrelli , Sakari Ailus , Mauro Carvalho Chehab , linux-kernel@vger.kernel.org (open list) Subject: [PATCH v2 6/6] media: i2c: imx335: Fix hblank min/max values Date: Wed, 1 Nov 2023 13:13:54 +0000 Message-Id: <20231101131354.2333498-7-kieran.bingham@ideasonboard.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231101131354.2333498-1-kieran.bingham@ideasonboard.com> References: <20231101131354.2333498-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS, T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Wed, 01 Nov 2023 06:14:38 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781367562768021432 X-GMAIL-MSGID: 1781367562768021432 The V4L2_CID_HBLANK control is marked as readonly and can only be a single value. Set the minimum and maximum value to match the mode value. Reviewed-by: Umang Jain Signed-off-by: Kieran Bingham --- drivers/media/i2c/imx335.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c index ce41e9f669bc..5373775cf63f 100644 --- a/drivers/media/i2c/imx335.c +++ b/drivers/media/i2c/imx335.c @@ -1045,8 +1045,8 @@ static int imx335_init_controls(struct imx335 *imx335) imx335->hblank_ctrl = v4l2_ctrl_new_std(ctrl_hdlr, &imx335_ctrl_ops, V4L2_CID_HBLANK, - IMX335_REG_MIN, - IMX335_REG_MAX, + mode->hblank, + mode->hblank, 1, mode->hblank); if (imx335->hblank_ctrl) imx335->hblank_ctrl->flags |= V4L2_CTRL_FLAG_READ_ONLY;