From patchwork Tue Oct 31 16:42:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 160230 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b90f:0:b0:403:3b70:6f57 with SMTP id t15csp369340vqg; Tue, 31 Oct 2023 09:43:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7h7A4F/bsDzvud3bTAdsHJUhP9pfKoRbHIQm4Kjv7DAcvwLoP1fsNgirXsSLwgc+DRBWA X-Received: by 2002:a05:6a20:7286:b0:17a:e2b9:77e0 with SMTP id o6-20020a056a20728600b0017ae2b977e0mr4111660pzk.7.1698770587297; Tue, 31 Oct 2023 09:43:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698770587; cv=none; d=google.com; s=arc-20160816; b=QZQu0XKTPQ/M7bb+iLbFz8tTDqC3iyCHQLPGT5n8CRPpNDEIBCVrRVx7DHoMtvsxGP EvbFLgSnMJ/psyx041/q8c7JWAUoR+X3QQNVE9bTsFEA9Nh7KeWdwicFKqIEq9eFmIqm 9GPdJRoRF56FGkh31M7bmmTbbCb2yNxMarA8F/hNRTzE1CWnvqHKUhCO401J8qlqrPJA 8tIYkzYGvybHNz7W++5dEGT28xg/0jSW4XXavKqDzkkKDdxfVE8tc3UK6KDUgM/Kk0jc CPW6uHKJn4TmPxm86KXpJm41hp8VdP5s/LhZwQ1DBmxEWOQdsALq5CX50u6F1n8YQ04J Qiuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date; bh=k2BNmCpjZXUJS5hm/9Nz23g8l305Yv77r2FETCZUgV8=; fh=GwUA7iixakkO5NTXBBRh1SUU4bI3bHSxo/Z9KQ16JZ0=; b=lUgYQ9ud97VVr+5/SeYwuwvsEStFxupNLnaC0sRJA6yC3wYfpL1QgjVQAn26+L7Bqy lvpcLH3PMl7Ez3jD9BByjJNc3qwrtiI3RCzrkJwbmDBWGjMWvF3G7+6lhmz+BBhk+4xv B4iqScYjrDVSQfChiEX22GqbPJQ4feocAwWpQ1LtX2Myfn8im0jIQDDEVX5lj4recN2a MyFWPGGD6tbKn2MInnTlRjVTpyryMkHUYZzwvSqDQJ4T4/gowhBijv3V29r3wPeqEVqW eO8t8h0nv0aZ80iyUdON8bK+wA7Td+lNaNsCPzCs+eWfsLr2UNGg9qJ0JO0TgE3MF2vE AMZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id s20-20020a656914000000b00563ee04bbafsi1195803pgq.837.2023.10.31.09.43.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Oct 2023 09:43:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id D92E980A1A5F; Tue, 31 Oct 2023 09:43:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235926AbjJaQm5 (ORCPT + 33 others); Tue, 31 Oct 2023 12:42:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231540AbjJaQml (ORCPT ); Tue, 31 Oct 2023 12:42:41 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A3020137 for ; Tue, 31 Oct 2023 09:42:31 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3F57C433C7; Tue, 31 Oct 2023 16:42:30 +0000 (UTC) Date: Tue, 31 Oct 2023 12:42:29 -0400 From: Steven Rostedt To: LKML , Linux Trace Kernel Cc: Masami Hiramatsu , Mark Rutland Subject: [PATCH] eventfs: Remove extra dget() in eventfs_create_events_dir() Message-ID: <20231031124229.4f2e3fa1@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Tue, 31 Oct 2023 09:43:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781290067304471464 X-GMAIL-MSGID: 1781290067304471464 From: "Steven Rostedt (Google)" The creation of the top events directory does a dget() at the end of the creation in eventfs_create_events_dir() with a comment saying the final dput() will happen when it is removed. The problem is that a dget() is already done on the dentry when it was created with tracefs_start_creating()! The dget() now just causes a memory leak of that dentry. Remove the extra dget() as the final dput() in the deletion of the events directory actually matches the one in tracefs_start_creating(). Fixes: 5790b1fb3d672 ("eventfs: Remove eventfs_file and just use eventfs_inode") Signed-off-by: Steven Rostedt (Google) --- fs/tracefs/event_inode.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index ae2172814bdc..d051b889147d 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -952,9 +952,6 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry fsnotify_mkdir(dentry->d_parent->d_inode, dentry); tracefs_end_creating(dentry); - /* Will call dput when the directory is removed */ - dget(dentry); - return ei; fail: