From patchwork Tue Oct 31 04:09:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Randy Dunlap X-Patchwork-Id: 159942 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b90f:0:b0:403:3b70:6f57 with SMTP id t15csp1465vqg; Mon, 30 Oct 2023 21:09:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH/rMCZtfsOqtOLUrpxZq3agRDb9RCakpo3ilg9xRKl1E2FOzNCiFk/fCyKNp+5WqMlJ/4I X-Received: by 2002:a17:902:d492:b0:1cc:361b:7b10 with SMTP id c18-20020a170902d49200b001cc361b7b10mr4715024plg.24.1698725377485; Mon, 30 Oct 2023 21:09:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698725377; cv=none; d=google.com; s=arc-20160816; b=KbjNsVgCmtW4htpQp36tKDa10ixCBj2uvXzfjfZDUeyu6Hvi6FQEDX9kZlvn5ZmsLk aMNRtO5UABQkqlMvLbSh1SyTjUXr8ZTvlHrfyxT3aQcRoIiZVJyOvhVJLTNrIM6MmfbH ddadUXT2xP/xPbQV6JdFWH99nzUpGzQyUJPxgjWOQmE3zBsHID5NXxg6SEtXT1R9pzm9 o90gigxbnONZz09HQJNZOcJtWq1xTDyxx97CCJiVJHOo+s7AahQmUI3BEgvl8jdHNGRN o3O/umenTod/B6AaDbp3XOA4Epi7CX+zGSMs5QtM0YWdH7XPOtpbsGG/GlpMfQ0GwWlc bR9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Cm7wzuH90vimQPyA1MAWxOBXUh0ZmX/mfwrQf/vnoaI=; fh=hFQu8mso9ASJtgf3Ds/IVvJDHF5Z6alRqSksNTF7qZE=; b=Ch18nWDGrb2oK+wd1UP/Qrni3AY2I1n3+AzhKd9aLTodHUlS7/wyrUnD+0UXHRQhGX I5EGNJF+jQWlVI2bMGDx47uxC1d6wSQ5ecy7lzJD1WxZ5EuXhjcV7OomKMuZHnl8cvtU wtjgJSPeb8QhX7+Kj2EMruvhvu7x8FjBkLPgt/NaJoVRixAH97eM6w1MBaqjybKZONO8 Gpm9tuFxQ1qu8hGOVcayUz5FQBKZgMlJ6kFs29XuPLxnICI752G3JtzYrL2RbM2GWPop ziWZfvE/b+NKFSOjhpJrfVOLH4vWOMCDMIrmZua0szMfSGICcDcCQNO1utpYsFIgdBO9 2ugg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hg4aZ7bZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id kw7-20020a170902f90700b001c7347e993esi413519plb.17.2023.10.30.21.09.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Oct 2023 21:09:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=bombadil.20210309 header.b=hg4aZ7bZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 484EA80401FC; Mon, 30 Oct 2023 21:09:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235390AbjJaEJO (ORCPT + 33 others); Tue, 31 Oct 2023 00:09:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229436AbjJaEJM (ORCPT ); Tue, 31 Oct 2023 00:09:12 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66E48C0 for ; Mon, 30 Oct 2023 21:09:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=Cm7wzuH90vimQPyA1MAWxOBXUh0ZmX/mfwrQf/vnoaI=; b=hg4aZ7bZ+P68XcDNuMA+W83Ix7 IuAPauuIV22ASzDqQeJNucLIVfmEKamSiz7L+lqLsvl7oL4Y0PMkNyngSNGwMF2L6BXXhdDFTnjOY Nz3b5/gMioSnLmG45qgOrZ115mb0JeUIYaFfc07OLvm7KfVQqtG7knyGCT4rgRb5gMs/c5kZaSg27 8VL1hM4gBP/9HIUQBjy6ZqIbomrebipEg6UtZYWVI5BD6tPOlYvJTQmB70c4L3XC6BUyN9o45CLg6 pB3ir1X7UqaURtJfHB+8PBExDOMaIebnDif1/dpt18R8s/C0K/SIi6NOa2536a7Scwg8YPVF8+HiU /9Aw8Igg==; Received: from [50.53.46.231] (helo=bombadil.infradead.org) by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1qxg3x-004VG8-2x; Tue, 31 Oct 2023 04:09:09 +0000 From: Randy Dunlap To: linux-kernel@vger.kernel.org Cc: Randy Dunlap , Ayush Singh , Greg Kroah-Hartman , Johan Hovold , Alex Elder , greybus-dev@lists.linaro.org Subject: [PATCH] greybus: BeaglePlay driver needs CRC_CCITT Date: Mon, 30 Oct 2023 21:09:09 -0700 Message-ID: <20231031040909.21201-1-rdunlap@infradead.org> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Mon, 30 Oct 2023 21:09:35 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781242661467886215 X-GMAIL-MSGID: 1781242661467886215 The gb-beagleplay driver uses crc_ccitt(), so it should select CRC_CCITT to make sure that the function is available. Fixes these build errors: s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_append_tx_u8': gb-beagleplay.c:(.text+0x2c0): undefined reference to `crc_ccitt' s390-linux-ld: drivers/greybus/gb-beagleplay.o: in function `hdlc_rx_frame': gb-beagleplay.c:(.text+0x6a0): undefined reference to `crc_ccitt' Fixes: ec558bbfea67 ("greybus: Add BeaglePlay Linux Driver") Signed-off-by: Randy Dunlap Cc: Ayush Singh Cc: Greg Kroah-Hartman Cc: Johan Hovold Cc: Alex Elder Cc: greybus-dev@lists.linaro.org Reviewed-by: Ayush Singh --- drivers/greybus/Kconfig | 1 + 1 file changed, 1 insertion(+) diff -- a/drivers/greybus/Kconfig b/drivers/greybus/Kconfig --- a/drivers/greybus/Kconfig +++ b/drivers/greybus/Kconfig @@ -20,6 +20,7 @@ if GREYBUS config GREYBUS_BEAGLEPLAY tristate "Greybus BeaglePlay driver" depends on SERIAL_DEV_BUS + select CRC_CCITT help Select this option if you have a BeaglePlay where CC1352 co-processor acts as Greybus SVC.