| Message ID | 20231030100022.9262-4-moudy.ho@mediatek.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp2096072vqb;
Mon, 30 Oct 2023 03:06:12 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IEvoVBLHcjkdk6tEIpU82BMgKOMeWu6Omg/SDzw1vunnVGjXTaLJB/H9AT9iY2AxWxsAXlY
X-Received: by 2002:a17:902:ea0d:b0:1cc:4f55:db72 with SMTP id
s13-20020a170902ea0d00b001cc4f55db72mr2362013plg.0.1698660372403;
Mon, 30 Oct 2023 03:06:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1698660372; cv=none;
d=google.com; s=arc-20160816;
b=CBWfppOJbcrejswsP0oB8HyGcznIsSauKyx/DKrIvmI7S2NJzbY5bz/447MzJkVQpS
G9taC35wcauyZCBDFPsrtxaAVrgZ/GIbBLu+vSCl92zK5pYiKeCswX9pSyunQ0zqB54f
N6j/Fc+V+Nvz6Ts4cY+5F7r2sip/5ar52U6OwxEahKDdoNGVR9gGBbbey8oTQMGztO2f
XY27jUeVSWxsMgj0l29pIPpzu3cuDQ2k5pB1T8EhBBNS0XSXyHbbFeVClc8XfFBbfJjb
sf5EMHGv0Ji21/CXkU9lhPDJilDIReW8ia86O48nZSJsRURbLJP2llNQxy67KFSWS6k+
1Vgw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:mime-version:references:in-reply-to:message-id
:date:subject:cc:to:from:dkim-signature;
bh=ToxDj4Jh9UEI1Nb/YtvDgd8K3/Q8XFBBACqcPBFHRYc=;
fh=N25l34UKybvwssildkJfWZzd7U86IAOGhJYPnp0TxMk=;
b=jQG5ROl56+ZBLDQ8lirjpoKKpWJF+v56ehETzeefaPaT/BBzmnUIcQQ45fx/hg6+/C
J0pviypmTD3PkAHVAqfP2yqKxR/jzID2sKZylPTYbR5ldS+MJ+AS353eAmTUPpmbzMUV
fyYz89Xcggtg5W8W1/YJQUuAI6XG3pL1Gw3T5CaTK+2qN0TNJmM468dfdlYQLHOKatXK
lYaUr7ZhGJpmoWeAmFvwY7/IzNde5eS1xGZfHJ+g4xKczPCeOQlaO+7Kotnh4BJOk9S7
xhK+brsi0585eLkQH3gh1xj2Rh3+IUiFervboiLANsCVSLL7q+dtOuNwu5+jpbLzh2K7
TFnw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@mediatek.com header.s=dk header.b=utcSVT0w;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.36 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=mediatek.com
Received: from pete.vger.email (pete.vger.email. [23.128.96.36])
by mx.google.com with ESMTPS id
i13-20020a17090332cd00b001cc5d28bb2csi114633plr.151.2023.10.30.03.06.12
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 30 Oct 2023 03:06:12 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.36 as permitted sender) client-ip=23.128.96.36;
Authentication-Results: mx.google.com;
dkim=pass header.i=@mediatek.com header.s=dk header.b=utcSVT0w;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 23.128.96.36 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=mediatek.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by pete.vger.email (Postfix) with ESMTP id 322B580765DD;
Mon, 30 Oct 2023 03:05:13 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S232493AbjJ3KDH (ORCPT <rfc822;zxc52fgh@gmail.com> + 31 others);
Mon, 30 Oct 2023 06:03:07 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55904 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S232911AbjJ3KBD (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 30 Oct 2023 06:01:03 -0400
Received: from mailgw02.mediatek.com (unknown [210.61.82.184])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33E131700;
Mon, 30 Oct 2023 03:00:33 -0700 (PDT)
X-UUID: 25411c7e770b11ee8051498923ad61e6-20231030
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=mediatek.com; s=dk;
h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From;
bh=ToxDj4Jh9UEI1Nb/YtvDgd8K3/Q8XFBBACqcPBFHRYc=;
b=utcSVT0wKvhKehYCl/VuBY3FO/YIJFAK03+xdvnTbLCqRSltWbKMvq/erSZiLpuOGa6fS2yvFIsLV/m36PTsWqXOcmmzS2CJFihvLvR+3XGF7IFJXyhANNJroyC86tRIX3NbLl3HSE8vsl5pmMOgUYhLwTNtbZySELS7U3Z9bO4=;
X-CID-P-RULE: Release_Ham
X-CID-O-INFO: VERSION:1.1.32,REQID:f7b3f16b-dcb5-4aeb-9a65-d333931879dd,IP:0,U
RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION:
release,TS:0
X-CID-META: VersionHash:5f78ec9,CLOUDID:78c3cb94-10ce-4e4b-85c2-c9b5229ff92b,B
ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U
RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO,
DKR:0,DKP:0,BRR:0,BRE:0
X-CID-BVR: 0
X-CID-BAS: 0,_,0,_
X-CID-FACTOR: TF_CID_SPAM_SNR
X-UUID: 25411c7e770b11ee8051498923ad61e6-20231030
Received: from mtkmbs11n1.mediatek.inc [(172.21.101.185)] by
mailgw02.mediatek.com
(envelope-from <moudy.ho@mediatek.com>)
(Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256)
with ESMTP id 1356428682; Mon, 30 Oct 2023 18:00:24 +0800
Received: from mtkmbs11n1.mediatek.inc (172.21.101.185) by
mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
15.2.1118.26; Mon, 30 Oct 2023 18:00:23 +0800
Received: from mtksdccf07.mediatek.inc (172.21.84.99) by
mtkmbs11n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id
15.2.1118.26 via Frontend Transport; Mon, 30 Oct 2023 18:00:23 +0800
From: Moudy Ho <moudy.ho@mediatek.com>
To: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>
CC: <dri-devel@lists.freedesktop.org>,
<linux-mediatek@lists.infradead.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-media@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Moudy Ho <moudy.ho@mediatek.com>
Subject: [PATCH v8 03/16] dt-bindings: media: mediatek: mdp3: add config for
MT8195 RDMA
Date: Mon, 30 Oct 2023 18:00:09 +0800
Message-ID: <20231030100022.9262-4-moudy.ho@mediatek.com>
X-Mailer: git-send-email 2.18.0
In-Reply-To: <20231030100022.9262-1-moudy.ho@mediatek.com>
References: <20231030100022.9262-1-moudy.ho@mediatek.com>
MIME-Version: 1.0
Content-Type: text/plain
X-MTK: N
X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID,
DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,
SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]);
Mon, 30 Oct 2023 03:05:13 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1781174498452014910
X-GMAIL-MSGID: 1781174498452014910
|
| Series |
introduce more MDP3 components in MT8195
|
|
Commit Message
Moudy Ho (何宗原)
Oct. 30, 2023, 10 a.m. UTC
Added the configuration for MT8195 RDMA. In comparison to MT8183, it no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox. Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- .../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-)
Comments
On Mon, Oct 30, 2023 at 06:00:09PM +0800, Moudy Ho wrote: > Added the configuration for MT8195 RDMA. In comparison to MT8183, it > no longer shares SRAM with RSZ, and there are now preconfigured 5 mbox. > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../bindings/media/mediatek,mdp3-rdma.yaml | 26 ++++++++++++++++++- > 1 file changed, 25 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > index c043204cf210..504334a76fb3 100644 > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml > @@ -22,6 +22,7 @@ properties: > compatible: > enum: > - mediatek,mt8183-mdp3-rdma > + - mediatek,mt8195-mdp3-rdma > - mediatek,mt8195-vdo1-rdma > > reg: > @@ -58,7 +59,7 @@ properties: > > mboxes: > minItems: 1 > - maxItems: 2 > + maxItems: 5 > > interrupts: > maxItems: 1 > @@ -98,6 +99,29 @@ allOf: > - mboxes > - mediatek,gce-events > > + - if: > + properties: > + compatible: > + contains: > + const: mediatek,mt8195-mdp3-rdma > + > + then: > + properties: > + clocks: > + items: > + - description: RDMA clock > + > + mboxes: > + items: > + - description: used for 1st data pipe from RDMA > + - description: used for 2nd data pipe from RDMA > + - description: used for 3rd data pipe from RDMA > + - description: used for 4th data pipe from RDMA > + - description: used for the data pipe from SPLIT Following the prior comments, add these entries to the top-level 'mboxes' and then here just put 'minItems: 5'. Rob
On Mon, 2023-10-30 at 14:26 -0500, Rob Herring wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On Mon, Oct 30, 2023 at 06:00:09PM +0800, Moudy Ho wrote: > > Added the configuration for MT8195 RDMA. In comparison to MT8183, > it > > no longer shares SRAM with RSZ, and there are now preconfigured 5 > mbox. > > > > Signed-off-by: Moudy Ho <moudy.ho@mediatek.com> > > Reviewed-by: AngeloGioacchino Del Regno < > angelogioacchino.delregno@collabora.com> > > --- > > .../bindings/media/mediatek,mdp3-rdma.yaml | 26 > ++++++++++++++++++- > > 1 file changed, 25 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > index c043204cf210..504334a76fb3 100644 > > --- a/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3- > rdma.yaml > > @@ -22,6 +22,7 @@ properties: > > compatible: > > enum: > > - mediatek,mt8183-mdp3-rdma > > + - mediatek,mt8195-mdp3-rdma > > - mediatek,mt8195-vdo1-rdma > > > > reg: > > @@ -58,7 +59,7 @@ properties: > > > > mboxes: > > minItems: 1 > > - maxItems: 2 > > + maxItems: 5 > > > > interrupts: > > maxItems: 1 > > @@ -98,6 +99,29 @@ allOf: > > - mboxes > > - mediatek,gce-events > > > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: mediatek,mt8195-mdp3-rdma > > + > > + then: > > + properties: > > + clocks: > > + items: > > + - description: RDMA clock > > + > > + mboxes: > > + items: > > + - description: used for 1st data pipe from RDMA > > + - description: used for 2nd data pipe from RDMA > > + - description: used for 3rd data pipe from RDMA > > + - description: used for 4th data pipe from RDMA > > + - description: used for the data pipe from SPLIT > > Following the prior comments, add these entries to the top-level > 'mboxes' and then here just put 'minItems: 5'. > > Rob Hi Rob, Thanks for assisting with the review and suggesting an improved method in patch [2/16] and here for bounding related item quantites. I have a question regarding the current item description. It seems to imply a specific order. If the order of the description is different for any reason, should it be fully re-listed under 'allOf'? Sincerely, Moudy
diff --git a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml index c043204cf210..504334a76fb3 100644 --- a/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml +++ b/Documentation/devicetree/bindings/media/mediatek,mdp3-rdma.yaml @@ -22,6 +22,7 @@ properties: compatible: enum: - mediatek,mt8183-mdp3-rdma + - mediatek,mt8195-mdp3-rdma - mediatek,mt8195-vdo1-rdma reg: @@ -58,7 +59,7 @@ properties: mboxes: minItems: 1 - maxItems: 2 + maxItems: 5 interrupts: maxItems: 1 @@ -98,6 +99,29 @@ allOf: - mboxes - mediatek,gce-events + - if: + properties: + compatible: + contains: + const: mediatek,mt8195-mdp3-rdma + + then: + properties: + clocks: + items: + - description: RDMA clock + + mboxes: + items: + - description: used for 1st data pipe from RDMA + - description: used for 2nd data pipe from RDMA + - description: used for 3rd data pipe from RDMA + - description: used for 4th data pipe from RDMA + - description: used for the data pipe from SPLIT + + required: + - mediatek,gce-events + - if: properties: compatible: