In preparation for providing a new API to the sev-guest driver for sending
an SNP guest message, move the SNP command mutex to the snp_guest_dev
structure.
Signed-off-by: Nikunj A Dadhania <nikunj@amd.com>
Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>
---
drivers/virt/coco/sev-guest/sev-guest.c | 18 +++++++++++-------
1 file changed, 11 insertions(+), 7 deletions(-)
@@ -35,6 +35,9 @@ struct snp_guest_dev {
struct device *dev;
struct miscdevice misc;
+ /* Mutex to serialize the shared buffer access and command handling. */
+ struct mutex cmd_mutex;
+
void *certs_data;
struct aesgcm_ctx *ctx;
/* request and response are in unencrypted memory */
@@ -98,7 +101,7 @@ static inline u64 __snp_get_msg_seqno(struct snp_guest_dev *snp_dev)
{
u64 count;
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
/* Read the current message sequence counter from secrets pages */
count = *snp_dev->os_area_msg_seqno;
@@ -394,7 +397,7 @@ static int get_report(struct snp_guest_dev *snp_dev, struct snp_guest_request_io
struct snp_report_req req;
int rc, resp_len;
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
if (!arg->req_data || !arg->resp_data)
return -EINVAL;
@@ -434,7 +437,7 @@ static int get_derived_key(struct snp_guest_dev *snp_dev, struct snp_guest_reque
/* Response data is 64 bytes and max authsize for GCM is 16 bytes. */
u8 buf[64 + 16];
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
if (!arg->req_data || !arg->resp_data)
return -EINVAL;
@@ -472,7 +475,7 @@ static int get_ext_report(struct snp_guest_dev *snp_dev, struct snp_guest_reques
struct snp_report_resp *resp;
int ret, npages = 0, resp_len;
- lockdep_assert_held(&snp_cmd_mutex);
+ lockdep_assert_held(&snp_dev->cmd_mutex);
if (!arg->req_data || !arg->resp_data)
return -EINVAL;
@@ -557,12 +560,12 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned long
if (!input.msg_version)
return -EINVAL;
- mutex_lock(&snp_cmd_mutex);
+ mutex_lock(&snp_dev->cmd_mutex);
/* Check if the VMPCK is not empty */
if (is_vmpck_empty(snp_dev)) {
dev_err_ratelimited(snp_dev->dev, "VMPCK is disabled\n");
- mutex_unlock(&snp_cmd_mutex);
+ mutex_unlock(&snp_dev->cmd_mutex);
return -ENOTTY;
}
@@ -580,7 +583,7 @@ static long snp_guest_ioctl(struct file *file, unsigned int ioctl, unsigned long
break;
}
- mutex_unlock(&snp_cmd_mutex);
+ mutex_unlock(&snp_dev->cmd_mutex);
if (input.exitinfo2 && copy_to_user(argp, &input, sizeof(input)))
return -EFAULT;
@@ -699,6 +702,7 @@ static int __init sev_guest_probe(struct platform_device *pdev)
goto e_unmap;
}
+ mutex_init(&snp_dev->cmd_mutex);
platform_set_drvdata(pdev, snp_dev);
snp_dev->dev = dev;
snp_dev->layout = layout;