From patchwork Mon Oct 30 02:07:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Su Hui X-Patchwork-Id: 159465 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp1942668vqb; Sun, 29 Oct 2023 19:08:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IET66v6bYGFmrxyx6gLzKecHho4OEtr6KxfwbnWWqDXI6B5Pco3xCzPVAE0I07OBYOX/3W0 X-Received: by 2002:a05:6870:d18b:b0:1e9:b62d:dc72 with SMTP id a11-20020a056870d18b00b001e9b62ddc72mr9964058oac.12.1698631694500; Sun, 29 Oct 2023 19:08:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698631694; cv=none; d=google.com; s=arc-20160816; b=oClTToLA8RRobF2cV/VCxrlg2+C2UAa8EFmOHJ9jAYBqirwCNDlqFPiwY8+8qJgh36 X8LLowtFv9md7pxmorm/0ko1f7Q0ca7Sh/1H/6RLIBLyxFroXDIiq5G3jwltK8GL502J dNb3GhsvzoexjjEnVgnR54Z4KWqFPyeBS3HpoFccgZi842LqdsYDyJRtszFnP5Yu1lM4 oSnYupaHKVQAiFXp8WX24tga7om6AWP6Ork223/2zbe02RSSyaEibmT+i4lC2wo4ziGv UEdS1b4x6G+ocpJGQlbW+r8bM8Pyke2MfLUsvrU/fI8gK7fUSOrJKnn0W+iKhOwLENbU Qn+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=bINMwevq8OGFJvLolaCLPuHnk2hF+y1LlhjWrt/LPCw=; fh=tdN0gxRbNmj8gni2xpkpQRlD8wL7eIfsGcQFLKXU0k4=; b=cosknO+86cn7n5QTxBRwymXVxDunwUU8recjM4mVTpMocf/zEKgaNRGns0suHR7P2v relFB0ixE24R2+ijVnvnlQO2mhBr3oftRgyh3LRyZ5FAJqKiFutLLJxFdAw/95a8N6a7 3YWodalFtKWJ5utv9Z0NtXCzIH84qAVSMD5ls64fiTk5kEy+qlWyPDB6kQWIGx6sRQPb PEBjshCzTZzwW20XN4RVXKoVogYMZsB3vKlohCoVdIRM2SM4cAqXtDxBLMwthV0IBsVf yABcceBrjxJcXkwAmYSS0jq23d5EjiQiJBtkrNNUH5HGUSk1328m3KXesfoTUo82MBfj ns0Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id s127-20020a637785000000b005b881b8aecasi4320426pgc.440.2023.10.29.19.08.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 19:08:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id A93548040E81; Sun, 29 Oct 2023 19:08:13 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230331AbjJ3CIK (ORCPT + 31 others); Sun, 29 Oct 2023 22:08:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43410 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229569AbjJ3CII (ORCPT ); Sun, 29 Oct 2023 22:08:08 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id E712693; Sun, 29 Oct 2023 19:08:05 -0700 (PDT) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id BC42D6027E05D; Mon, 30 Oct 2023 10:08:02 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: jic23@kernel.org, lars@metafoo.de Cc: Su Hui , jean-baptiste.maneyrol@tdk.com, chenhuiz@axis.com, andy.shevchenko@gmail.com, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] iio: imu: inv_mpu6050: return callee's error code rather than -EINVAL Date: Mon, 30 Oct 2023 10:07:53 +0800 Message-Id: <20231030020752.67630-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,RDNS_NONE, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 29 Oct 2023 19:08:13 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781144427640590891 X-GMAIL-MSGID: 1781144427640590891 regmap_bulk_write()/regmap_bulk_read() return zero or negative error code, return the callee's error code is better than '-EINVAL'. Signed-off-by: Su Hui --- drivers/iio/imu/inv_mpu6050/inv_mpu_core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c index a9a5fb266ef1..5ded0781797c 100644 --- a/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c +++ b/drivers/iio/imu/inv_mpu6050/inv_mpu_core.c @@ -572,7 +572,7 @@ static int inv_mpu6050_sensor_set(struct inv_mpu6050_state *st, int reg, ind = (axis - IIO_MOD_X) * 2; result = regmap_bulk_write(st->map, reg + ind, &d, sizeof(d)); if (result) - return -EINVAL; + return result; return 0; } @@ -586,7 +586,7 @@ static int inv_mpu6050_sensor_show(struct inv_mpu6050_state *st, int reg, ind = (axis - IIO_MOD_X) * 2; result = regmap_bulk_read(st->map, reg + ind, &d, sizeof(d)); if (result) - return -EINVAL; + return result; *val = (short)be16_to_cpup(&d); return IIO_VAL_INT;