Message ID | 20231029230205.93277-6-dmitry.osipenko@collabora.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp1891889vqb; Sun, 29 Oct 2023 16:10:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpk7eUMB0q/ppYiKcXv7lccTwansLyjcIhC3VSOjbvzPqhD0COIhElsxxg4F2K1k+w5IWx X-Received: by 2002:a05:6a21:33a7:b0:17a:fe0a:c66c with SMTP id yy39-20020a056a2133a700b0017afe0ac66cmr14428976pzb.2.1698621007056; Sun, 29 Oct 2023 16:10:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698621007; cv=none; d=google.com; s=arc-20160816; b=rLueqbL3qbkDYHUR418Q8+47ZwustnO+6yqhVn4e2+algT1/tIuJkz3ZBjU12w+GrP JuBfsSX3rsSUIbtNJLGh/k0fT1IUXph5KwVXcY2vXwTM4xJl5/I+0JOY/ebm3jXKYxfy MxZfJ0DnpFTjxaP4ax7JzG5L8wmjdurWyZNHDyeZFFo8MugJWt7n3EnVSJ6kxueNij7z GcvRtONZzlm3RwLBcaSndx0OvJoco4SWfHpziik+s/e9/9qjzJ5M3Sjw1PaIqGs2wRoi KYw6/kTZsPli1YO3jE82ceXfx0E0I7pHOJrguL9000+wlIV7gnVpc7b/qHjNYeUGgy/2 cZDg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xWPnYDvf6DjGzD0P0Ek0j2bZ3W+V3/76LDf2dQbzMuY=; fh=5cel2jD5h+yPMXVwxbomyVhwojHUqATy6nFjd4aOh4o=; b=t2NB59t33qmK3QOTmRLff5G4yDsncqPelhr+x1DqGIJDWY1Zje6Z3ooGYsKiT9SZyt sd+0iuqH0ZrHHG35UQiUhJd9asQX8m2FlvyjLg7MzmE6jAf5+lv8cpX0DsaCF5XYT6lg pOXUPdbjsLADD0U2n2K3QGmiEQlBiQjl006h2YFAXJoSSJH22g9PRrIaN5cB0MDTI7IV QOn2Fb0dLa6l9RvIMHaqXfEj15v8iUl0C0KPAhvmRgsWrfEFnVXYigz3XuJVVtLIsZ+V LMgAucZeqORJQWeWYeUq0LSMjnINeRuZf5GLvJoR8PwUx/F/rkV8t0AeqXrF7+rTAZsC hj8Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=h4GZgR0L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id cl2-20020a056a02098200b005855f67e490si4367423pgb.690.2023.10.29.16.10.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Oct 2023 16:10:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=h4GZgR0L; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 07028804869D; Sun, 29 Oct 2023 16:10:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232338AbjJ2XJm (ORCPT <rfc822;zxc52fgh@gmail.com> + 31 others); Sun, 29 Oct 2023 19:09:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56874 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232757AbjJ2XJP (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sun, 29 Oct 2023 19:09:15 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 50999658B for <linux-kernel@vger.kernel.org>; Sun, 29 Oct 2023 16:03:56 -0700 (PDT) Received: from workpc.. (109-252-153-31.dynamic.spd-mgts.ru [109.252.153.31]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dmitry.osipenko) by madras.collabora.co.uk (Postfix) with ESMTPSA id B013C6607385; Sun, 29 Oct 2023 23:02:32 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698620553; bh=JEnVqea8F9PfIoRTIpDPPiewdAcM8Ofed+XPNsSrPBQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h4GZgR0LNwo/2QeIv6jRwELl1gLnMhUOnkGBFpuyQxI1yqeYYs7Wk0nZ2av/VrEYm FnzCXjWoQ+t/iyGT1pmHTIz63pACLzLRXVtzKl9sW0j84K+4HxqbEAnke0XfKaHnp2 gwxzNxM+Wb54/DXAby0hPqXUdk5UoyXCgoqbi86yyTzh88Qhp69yWjZ3fsxFUojJgA LXuDlZ4QcAUW0Y2CuOvebEtMxOQZ6UhBtOA3bxzJ+LEk+sDSGNkcf1Bt2mILUEDfk9 Tr+on7Fkk+XcYGfWY0G3hOZelPnB2xUzzelAaUCAckYmxf5PqLOoYlM+9HMuTlHCmL VKhXo794QwNeg== From: Dmitry Osipenko <dmitry.osipenko@collabora.com> To: David Airlie <airlied@gmail.com>, Gerd Hoffmann <kraxel@redhat.com>, Gurchetan Singh <gurchetansingh@chromium.org>, Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, =?utf-8?q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>, Qiang Yu <yuq825@gmail.com>, Steven Price <steven.price@arm.com>, Boris Brezillon <boris.brezillon@collabora.com>, Emma Anholt <emma@anholt.net>, Melissa Wen <mwen@igalia.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kernel@collabora.com, virtualization@lists.linux-foundation.org Subject: [PATCH v18 05/26] drm/shmem-helper: Remove obsoleted is_iomem test Date: Mon, 30 Oct 2023 02:01:44 +0300 Message-ID: <20231029230205.93277-6-dmitry.osipenko@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231029230205.93277-1-dmitry.osipenko@collabora.com> References: <20231029230205.93277-1-dmitry.osipenko@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sun, 29 Oct 2023 16:10:06 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1781133221303647801 X-GMAIL-MSGID: 1781133221303647801 |
Series |
Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers
|
|
Commit Message
Dmitry Osipenko
Oct. 29, 2023, 11:01 p.m. UTC
Everything that uses the mapped buffer should be agnostic to is_iomem.
The only reason for the is_iomem test is that we're setting shmem->vaddr
to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove
the obsoleted is_iomem test to clean up the code.
Suggested-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
---
drivers/gpu/drm/drm_gem_shmem_helper.c | 6 ------
1 file changed, 6 deletions(-)
Comments
On Mon, 30 Oct 2023 02:01:44 +0300 Dmitry Osipenko <dmitry.osipenko@collabora.com> wrote: > Everything that uses the mapped buffer should be agnostic to is_iomem. > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove > the obsoleted is_iomem test to clean up the code. > > Suggested-by: Thomas Zimmermann <tzimmermann@suse.de> > Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> Reviewed-by: Boris Brezillon <boris.brezillon@collabora.com> > --- > drivers/gpu/drm/drm_gem_shmem_helper.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c > index 154585ddae08..2cc0601865f6 100644 > --- a/drivers/gpu/drm/drm_gem_shmem_helper.c > +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c > @@ -315,12 +315,6 @@ int drm_gem_shmem_vmap_locked(struct drm_gem_shmem_object *shmem, > > if (obj->import_attach) { > ret = dma_buf_vmap(obj->import_attach->dmabuf, map); > - if (!ret) { > - if (drm_WARN_ON(obj->dev, map->is_iomem)) { > - dma_buf_vunmap(obj->import_attach->dmabuf, map); > - return -EIO; > - } > - } > } else { > pgprot_t prot = PAGE_KERNEL; >
On Mon, 30 Oct 2023 02:01:44 +0300, Dmitry Osipenko wrote: > Everything that uses the mapped buffer should be agnostic to is_iomem. > The only reason for the is_iomem test is that we're setting shmem->vaddr > to the returned map->vaddr. Now that the shmem->vaddr code is gone, remove > the obsoleted is_iomem test to clean up the code. > > > [ ... ] Acked-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
diff --git a/drivers/gpu/drm/drm_gem_shmem_helper.c b/drivers/gpu/drm/drm_gem_shmem_helper.c index 154585ddae08..2cc0601865f6 100644 --- a/drivers/gpu/drm/drm_gem_shmem_helper.c +++ b/drivers/gpu/drm/drm_gem_shmem_helper.c @@ -315,12 +315,6 @@ int drm_gem_shmem_vmap_locked(struct drm_gem_shmem_object *shmem, if (obj->import_attach) { ret = dma_buf_vmap(obj->import_attach->dmabuf, map); - if (!ret) { - if (drm_WARN_ON(obj->dev, map->is_iomem)) { - dma_buf_vunmap(obj->import_attach->dmabuf, map); - return -EIO; - } - } } else { pgprot_t prot = PAGE_KERNEL;