diff mbox series

[net-next] net: xscale: Drop unused PHY number

Message ID 20231028-ixp4xx-eth-id-v1-1-57be486d7f0f@linaro.org
State New
Headers
Series [net-next] net: xscale: Drop unused PHY number |

Commit Message

Linus Walleij Oct. 28, 2023, 8:48 p.m. UTC 
  For some cargoculted reason on incomplete cleanup, we have a
PHY number which refers to nothing and gives confusing messages
about PHY 0 on all ports.

Print the name of the actual PHY device instead.

Reported-by: Howard Harte <hharte@magicandroidapps.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 drivers/net/ethernet/xscale/ixp4xx_eth.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)


---
base-commit: 0bb80ecc33a8fb5a682236443c1e740d5c917d1d
change-id: 20231028-ixp4xx-eth-id-7d2b9f1021c8

Best regards,

Comments

patchwork-bot+netdevbpf@kernel.org Nov. 2, 2023, 5:51 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 28 Oct 2023 22:48:35 +0200 you wrote:
> For some cargoculted reason on incomplete cleanup, we have a
> PHY number which refers to nothing and gives confusing messages
> about PHY 0 on all ports.
> 
> Print the name of the actual PHY device instead.
> 
> Reported-by: Howard Harte <hharte@magicandroidapps.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> 
> [...]

Here is the summary with links:
  - [net-next] net: xscale: Drop unused PHY number
    https://git.kernel.org/netdev/net/c/d280783c3ad9

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/xscale/ixp4xx_eth.c b/drivers/net/ethernet/xscale/ixp4xx_eth.c
index 3b0c5f177447..711f2727fa33 100644
--- a/drivers/net/ethernet/xscale/ixp4xx_eth.c
+++ b/drivers/net/ethernet/xscale/ixp4xx_eth.c
@@ -154,7 +154,6 @@  typedef void buffer_t;
 
 /* Information about built-in Ethernet MAC interfaces */
 struct eth_plat_info {
-	u8 phy;		/* MII PHY ID, 0 - 31 */
 	u8 rxq;		/* configurable, currently 0 - 31 only */
 	u8 txreadyq;
 	u8 hwaddr[ETH_ALEN];
@@ -1520,7 +1519,7 @@  static int ixp4xx_eth_probe(struct platform_device *pdev)
 	if ((err = register_netdev(ndev)))
 		goto err_phy_dis;
 
-	netdev_info(ndev, "%s: MII PHY %i on %s\n", ndev->name, plat->phy,
+	netdev_info(ndev, "%s: MII PHY %s on %s\n", ndev->name, phydev_name(phydev),
 		    npe_name(port->npe));
 
 	return 0;