diff mbox series

f2fs-tools: use total_node_count when creating a new node block in fsck

Message ID 20231027153043.1381438-1-daeho43@gmail.com
State New
Headers
Series f2fs-tools: use total_node_count when creating a new node block in fsck |

Commit Message

Daeho Jeong Oct. 27, 2023, 3:30 p.m. UTC 
  From: Daeho Jeong <daehojeong@google.com>

We might allocate more node blocks than total_valid_node_count, when we
recreate quota files.

Signed-off-by: Daeho Jeong <daehojeong@google.com>
---
 fsck/segment.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Chao Yu Nov. 15, 2023, 2:52 p.m. UTC | #1 
On 2023/10/27 23:30, Daeho Jeong wrote:
> From: Daeho Jeong <daehojeong@google.com>
> 
> We might allocate more node blocks than total_valid_node_count, when we
> recreate quota files.
> 
> Signed-off-by: Daeho Jeong <daehojeong@google.com>

Reviewed-by: Chao Yu <chao@kernel.org>

Thanks,
diff mbox series

Patch

diff --git a/fsck/segment.c b/fsck/segment.c
index 4b05fd4..4ea0a6f 100644
--- a/fsck/segment.c
+++ b/fsck/segment.c
@@ -36,8 +36,8 @@  int reserve_new_block(struct f2fs_sb_info *sbi, block_t *to,
 				ERR_MSG("Not enough space\n");
 				return -ENOSPC;
 			}
-			if (is_node && fsck->chk.valid_node_cnt >
-					sbi->total_valid_node_count) {
+			if (is_node && fsck->chk.valid_node_cnt >=
+						sbi->total_node_count) {
 				ERR_MSG("Not enough space for node block\n");
 				return -ENOSPC;
 			}