From patchwork Fri Oct 27 14:40:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frederic Weisbecker X-Patchwork-Id: 158975 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp655528vqb; Fri, 27 Oct 2023 07:43:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGtEWtaf21f4e81EcrUTjjXYcp/cE55V8eFKB+sAaYLRdViMsu+fpk78K9T+6oMC6AiVSqM X-Received: by 2002:a81:bd41:0:b0:5a7:b893:6f64 with SMTP id n1-20020a81bd41000000b005a7b8936f64mr2673725ywk.16.1698417782682; Fri, 27 Oct 2023 07:43:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698417782; cv=none; d=google.com; s=arc-20160816; b=VWxJfyWljljIBm8zOYAnuZt+zvuMdiIRRp5UxRm27x6DPOxWVjrasN+Tn6LXl2m8GZ z1Wrd/ZpgoZLpT8M52AoZmTOKjxS/78ns5nV5Ew3m7ls/jhBUnwupGpwFCKw8KRVp2js v5tonEnzNgFLDf5C5xPUNX2dCpBkK6D98s1UTxUCVERb5XKZyv3QjwCdLlTpDrhlxmUB R7L490HQwAUWmqmiO5pLpFIrASdQFterwfJ9EarcXKBpkSF91aE2YhJY+zZR4GG6ksC6 J0uVAsiA8jHA/8KIF2nIEhUAVtkEzs3Z+MxSz/p4JD9c07L7o6qKXMjys/SNpeINSioj RFww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=zEXPCBMJ1AEA/oLOYEucr76mHLC2MYFA9+I5Pi5epjw=; fh=iUkoi/K8IT/RJJVBdiQ8XO07tR0wG9xibh5YtxOmKQw=; b=plr6C7NCtas082e1tFJm0XKK2h6YuXxGIm+f2Tc2s73aOerc0VrVIPKLESxXlo9kRy uw8ATRVG2cGSBnn76Z0kZNAeLdQJyQoUZ6p9kXKb9nHI3aZ9qxeC1n/OCCjcege2zHha W39kdi0/QP0IMZ46slAqhp80m0fhvk1ELVisJvnY1y9NW+ZL9UPzEtyhzprBffz5iWEG 56qAFwrjWAzKM99uMJwGqS3YGHK5ALTTpxfh21d/MW/dVSBtgtnPY+UIXrB6i2PBCjgM MPsjUVRc5kAsWeCp/xyqwZjDLPYspb//LSaWcy8Y7WJk0AWCpGnEi7pE8GM02dsG/Q/S GHVg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wf3XrB4l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id x127-20020a81a085000000b005a7af4e22a8si2607605ywg.29.2023.10.27.07.42.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 27 Oct 2023 07:43:02 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=Wf3XrB4l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 006E98040EB9; Fri, 27 Oct 2023 07:41:19 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346000AbjJ0OlO (ORCPT + 25 others); Fri, 27 Oct 2023 10:41:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346044AbjJ0OlM (ORCPT ); Fri, 27 Oct 2023 10:41:12 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83935194; Fri, 27 Oct 2023 07:41:10 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1E9E5C433AB; Fri, 27 Oct 2023 14:41:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698417670; bh=1Gy2J4196Ason/4s+Q9DcJjUAQ+dsGogthDv6LJxxNs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wf3XrB4lbonjZ8b33Z/v5oowVFoMi9EgCyHv+7NQ4QwyevXljSj2ViB9KjmbkkCqf K2of/gnVoYyBDuYM1WWpRf+guN9Ka6iJMgrP05eTQ1cT7fhn5jIgCi9owyDdoHGc9V IXEg0Kf6DonMuMOmePd4mCY8YLDYisAYaZ0y57KDLAVzwn7rH9CoCUlyOP1vlqU51C MHF/EBlT15HIyU1fHoALOy0HUfLqC/kOJsgBbQD5yyufZyBHWX8zjez9y9zsQ80y8W QUT5TRyLk5u8+tgcofiL3v9H7CljFt9txqp7JKkeV9wzLXMU7WReeiPzc3h/FaQR+9 zL1XMUmKg0riQ== From: Frederic Weisbecker To: LKML Cc: Frederic Weisbecker , Boqun Feng , Joel Fernandes , Josh Triplett , Mathieu Desnoyers , Neeraj Upadhyay , "Paul E . McKenney" , Steven Rostedt , Uladzislau Rezki , rcu , Zqiang , "Liam R . Howlett" , Peter Zijlstra , Naresh Kamboju Subject: [PATCH 3/4] rcu/tasks-trace: Handle new PF_IDLE semantics Date: Fri, 27 Oct 2023 16:40:49 +0200 Message-Id: <20231027144050.110601-4-frederic@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231027144050.110601-1-frederic@kernel.org> References: <20231027144050.110601-1-frederic@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Fri, 27 Oct 2023 07:41:19 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780920124578160797 X-GMAIL-MSGID: 1780920124578160797 The commit: cff9b2332ab7 ("kernel/sched: Modify initial boot task idle setup") has changed the semantics of what is to be considered an idle task in such a way that the idle task of an offline CPU may not carry the PF_IDLE flag anymore. However RCU-tasks-trace tests the opposite assertion, still assuming that idle tasks carry the PF_IDLE flag during their whole lifecycle. Remove this assumption to avoid spurious warnings but keep the initial test verifying that the idle task is the current task on any offline CPU. Reported-by: Naresh Kamboju Fixes: cff9b2332ab7 ("kernel/sched: Modify initial boot task idle setup") Suggested-by: Joel Fernandes Suggested-by: Paul E . McKenney" Signed-off-by: Frederic Weisbecker --- kernel/rcu/tasks.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/rcu/tasks.h b/kernel/rcu/tasks.h index a604f59aee0b..732ad5b39946 100644 --- a/kernel/rcu/tasks.h +++ b/kernel/rcu/tasks.h @@ -1551,7 +1551,7 @@ static int trc_inspect_reader(struct task_struct *t, void *bhp_in) } else { // The task is not running, so C-language access is safe. nesting = t->trc_reader_nesting; - WARN_ON_ONCE(ofl && task_curr(t) && !is_idle_task(t)); + WARN_ON_ONCE(ofl && task_curr(t) && (t != idle_task(task_cpu(t)))); if (IS_ENABLED(CONFIG_TASKS_TRACE_RCU_READ_MB) && ofl) n_heavy_reader_ofl_updates++; }