Message ID | 20231027053903.1886-1-daniel.starke@siemens.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp381119vqb; Thu, 26 Oct 2023 22:42:59 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHzvoRcmD58tQXudMFBx0Zxu2At2dEvn19+8N29DfzEYfJutVw2aKrWwH4qIx3qUwbJYwL3 X-Received: by 2002:a81:b306:0:b0:59b:ca2f:6eff with SMTP id r6-20020a81b306000000b0059bca2f6effmr1397224ywh.40.1698385379020; Thu, 26 Oct 2023 22:42:59 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698385379; cv=none; d=google.com; s=arc-20160816; b=J2AQUybTDjl89N+GOPnluLvtTZ68KWfGkIqY3wtO4ZG6ugkTdWiW2LwnQ3WYrX2T7X oRXdZCwz98OKvOkpLwOpFRmleFOkHIOSo5DVdItPUrYnl2iNfyr/qCISpiwXWTgZvU2a TS/wboo6weeyKDSh5sXYJyT3LD+a735H4g5HXJPJto81DU6RWZc5O0z7Kff+uLGczvnC En+HS/VpNvR3bsJPeQ4s7ujHiafP3U2v9nvFmJywotJh61N18XaHEDKVyN9OiOa2XnAI ueFbcEk7UvxkOJzhPubEpUXljnllgCuqnDZNfr1RvIbKvWz+c33RMg5YU1lnq91Bmd1P dXSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:feedback-id:content-transfer-encoding :mime-version:message-id:date:subject:cc:to:from:dkim-signature; bh=/KZ/e7ZMbAbly9okDCQ6zH4k2JlUxSD/DyA86W16Z+k=; fh=5YXR7RtUzZ11YkjdXTzgd3M62+HIxQ5O+Fdh381pAu0=; b=qJLEZtx72ZwIsMTxYfROYGSuLH541MHJx6JbnHl5DixNjr2NuNxbXgJp9QO8qclLQd 8vC8uw2QAEWza8AU8TLVHfoFl9qG+T9R2KvV7RiWopmUos7ec40JiwT4hccHsaGLugPN 3Wf9fBMLKMnV+I7CX2S8bvLNl43+4Nabtzjl3ueetfwHxyFrbNt4IgpQaV0sdMPfK/K/ YdvuQO3BMrXdRkOqdmqD8eWk6Cw/mH1QAK2fJBjOXVsDLZC38L2ESo5aBTlnTRaICXbE ZBD37V2LOWcBfAfD3MW9ulO7QzrsctInAGl9P4aIOW4z/B7mz+YB2iIi/de6+ZqdxFnV HAkQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qIxsC0d8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id w15-20020a81490f000000b005a7b55dc16bsi1397950ywa.41.2023.10.26.22.42.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 22:42:58 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@siemens.com header.s=fm1 header.b=qIxsC0d8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=siemens.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6576A81896E9; Thu, 26 Oct 2023 22:41:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230200AbjJ0Flb (ORCPT <rfc822;aposhian.dev@gmail.com> + 26 others); Fri, 27 Oct 2023 01:41:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42116 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229604AbjJ0Fl3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 27 Oct 2023 01:41:29 -0400 X-Greylist: delayed 61 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 26 Oct 2023 22:41:25 PDT Received: from mta-65-225.siemens.flowmailer.net (mta-65-225.siemens.flowmailer.net [185.136.65.225]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 047BF1AA for <linux-kernel@vger.kernel.org>; Thu, 26 Oct 2023 22:41:25 -0700 (PDT) Received: by mta-65-225.siemens.flowmailer.net with ESMTPSA id 202310270540212c492c79708ef8c715 for <linux-kernel@vger.kernel.org>; Fri, 27 Oct 2023 07:40:21 +0200 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=fm1; d=siemens.com; i=daniel.starke@siemens.com; h=Date:From:Subject:To:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:Cc; bh=/KZ/e7ZMbAbly9okDCQ6zH4k2JlUxSD/DyA86W16Z+k=; b=qIxsC0d8D+pXUIy5HcRwCfSS1WpXHiH8s3D6Ak5jTZ7MpK2O05CQDZGIvX9MQNm5RyRrYJ CrR0NQK5q0lyRT46rCCdw7VD9/DwUjUIHHZbcgCSpxD5ptxYZpnrzWnU00xV3+JZJsCsMM8e 9BgUVbVIhmm6lEYXrOXJj1YSkv8ak=; From: "D. Starke" <daniel.starke@siemens.com> To: linux-serial@vger.kernel.org, gregkh@linuxfoundation.org, jirislaby@kernel.org, ilpo.jarvinen@linux.intel.com Cc: linux-kernel@vger.kernel.org, Daniel Starke <daniel.starke@siemens.com> Subject: [PATCH 1/1] tty: n_gsm: add copyright Siemens Mobility GmbH Date: Fri, 27 Oct 2023 07:39:03 +0200 Message-Id: <20231027053903.1886-1-daniel.starke@siemens.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Flowmailer-Platform: Siemens Feedback-ID: 519:519-314044:519-21489:flowmailer X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_MSPIKE_H5,RCVD_IN_MSPIKE_WL, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Thu, 26 Oct 2023 22:41:59 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780886147120813958 X-GMAIL-MSGID: 1780886147120813958 |
Series |
[1/1] tty: n_gsm: add copyright Siemens Mobility GmbH
|
|
Commit Message
D. Starke
Oct. 27, 2023, 5:39 a.m. UTC
From: Daniel Starke <daniel.starke@siemens.com> More than 1/3 of the n_gsm code has been contributed by us in the last 1.5 years, completing conformance with the standard and stabilizing the driver: - added UI (unnumbered information) frame support - added PN (parameter negotiation) message handling and function support - added optional keep-alive control link supervision via test messages - added TIOCM_OUT1 and TIOCM_OUT2 to allow responder to operate as modem - added TIOCMIWAIT support on virtual ttys - added additional ioctls and parameters to configure the new functions - added overall locking mechanism to avoid data race conditions - added outgoing data flow to decouple physical from virtual tty handling for better performance and to avoid dead-locks - fixed advanced option mode implementation - fixed convergence layer type 2 implementation - fixed handling of CLD (multiplexer close down) messages - fixed broken muxer close down procedure - and many more bug fixes With this most of our initial RFC has been implemented. It gives the driver a quality boost unseen in the decade before. Add a copyright notice to the n_gsm files to highlight this contribution. Link: https://lore.kernel.org/all/20220225080758.2869-1-daniel.starke@siemens.com/ Signed-off-by: Daniel Starke <daniel.starke@siemens.com> --- drivers/tty/n_gsm.c | 1 + include/uapi/linux/gsmmux.h | 1 + 2 files changed, 2 insertions(+)
Comments
On Fri, Oct 27, 2023 at 07:39:03AM +0200, D. Starke wrote: > From: Daniel Starke <daniel.starke@siemens.com> > > More than 1/3 of the n_gsm code has been contributed by us in the last > 1.5 years, completing conformance with the standard and stabilizing the > driver: > - added UI (unnumbered information) frame support > - added PN (parameter negotiation) message handling and function support > - added optional keep-alive control link supervision via test messages > - added TIOCM_OUT1 and TIOCM_OUT2 to allow responder to operate as modem > - added TIOCMIWAIT support on virtual ttys > - added additional ioctls and parameters to configure the new functions > - added overall locking mechanism to avoid data race conditions > - added outgoing data flow to decouple physical from virtual tty handling > for better performance and to avoid dead-locks > - fixed advanced option mode implementation > - fixed convergence layer type 2 implementation > - fixed handling of CLD (multiplexer close down) messages > - fixed broken muxer close down procedure > - and many more bug fixes > > With this most of our initial RFC has been implemented. It gives the driver > a quality boost unseen in the decade before. > > Add a copyright notice to the n_gsm files to highlight this contribution. > > Link: https://lore.kernel.org/all/20220225080758.2869-1-daniel.starke@siemens.com/ > Signed-off-by: Daniel Starke <daniel.starke@siemens.com> > --- > drivers/tty/n_gsm.c | 1 + > include/uapi/linux/gsmmux.h | 1 + > 2 files changed, 2 insertions(+) Nit, you didn't include what changed from v1 below the --- line. I'll take this now, but be more careful in the future. thanks, greg k-h
diff --git a/drivers/tty/n_gsm.c b/drivers/tty/n_gsm.c index 1f3aba607cd5..647e06b656bf 100644 --- a/drivers/tty/n_gsm.c +++ b/drivers/tty/n_gsm.c @@ -2,6 +2,7 @@ /* * n_gsm.c GSM 0710 tty multiplexor * Copyright (c) 2009/10 Intel Corporation + * Copyright (c) 2022/23 Siemens Mobility GmbH * * * THIS IS A DEVELOPMENT SNAPSHOT IT IS NOT A FINAL RELEASE * * diff --git a/include/uapi/linux/gsmmux.h b/include/uapi/linux/gsmmux.h index 4c878d84dbda..3a93f17ca943 100644 --- a/include/uapi/linux/gsmmux.h +++ b/include/uapi/linux/gsmmux.h @@ -1,4 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */ +/* Copyright (c) 2022/23 Siemens Mobility GmbH */ #ifndef _LINUX_GSMMUX_H #define _LINUX_GSMMUX_H