From patchwork Thu Oct 26 22:33:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: andrey.konovalov@linux.dev X-Patchwork-Id: 158694 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp212033vqb; Thu, 26 Oct 2023 15:34:10 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6fatoZ+6ShDomPeQaNzVfhIOvbvKHHyh3g6miBlfWc4ecuhyncE6+TTvPLM24iYQPWx43 X-Received: by 2002:a25:dfc7:0:b0:d0f:846c:ef7b with SMTP id w190-20020a25dfc7000000b00d0f846cef7bmr769592ybg.17.1698359650067; Thu, 26 Oct 2023 15:34:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698359650; cv=none; d=google.com; s=arc-20160816; b=Pw8/vsN+/l8cx8FHhs9UYUg8BTstT6h1zqC5SmL3/ICyEZAbWOwcnJhzmDd6FKsIaO OwBgdAmul0Awb7cG2jHdGHFV7YsAu9jSdT8+zL+1zVvLVLySjQoBh/K7S5o6DMN0z+T3 inxFnN2SGN+5mcfRHql0nJ80MeIkyGSjkLns1dJpgEK8EsJLCc13mvTp4XSL5MAdTRwB tNv2q0BM5SfaewXpZIVkRhvL4Kdl9ev+dRKM7Kfa16LJdod29yD8kMCbTKD2pCswR61C +4spmSVRidWqjJdx0pNKZRQnIw60gYRyReVslt5EkUiYqtl8B1rRJwWiReGvTdbDkUeq X/gA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=7wiIXHVKZViLnzrPPkXa8K3V9xAsF9dc3+hDNlwl8Us=; fh=qWoxmPN1zRqnLSoCWGpfFsDtzJsx/SGdqx98lbP+Uho=; b=YHi+MvRVezMw9thMIQSa4kq/IANVd+ClHB+93YDApeoLtRcincc8i6bDEAAl4AgIsz s3sLNzj0mexMke8D5YhAVCQp06anvL3vqPLZ69wn5Sc+0pCamTUgXs0yMJuTcNkUsQWj bxwG9eCD+K7USC10ACojOjFA1YDGqkPmlGJzgQrfXThBA+weAfYWlMR0s7V+WNIpZx/g CnD82jiYPNxHAM0dabDCH3shrTalYnlI9nKNl7+1/IW7NgPWirl/6N64n9cX0Q0kkyrH 8SLOnFg/ZNc5Ix73nJ/vXXJMc0Ijbc3G+tYmoT0aFpbkBRY6dp2O0GPNCPwBkb5qzS+B 1NRw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=DockHeTS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4]) by mx.google.com with ESMTPS id r193-20020a2576ca000000b00da03d81221bsi692582ybc.566.2023.10.26.15.34.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 15:34:10 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) client-ip=2620:137:e000::3:4; Authentication-Results: mx.google.com; dkim=pass header.i=@linux.dev header.s=key1 header.b=DockHeTS; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:4 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linux.dev Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by howler.vger.email (Postfix) with ESMTP id A322C82B929F; Thu, 26 Oct 2023 15:34:07 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344955AbjJZWdw (ORCPT + 26 others); Thu, 26 Oct 2023 18:33:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59390 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229694AbjJZWdv (ORCPT ); Thu, 26 Oct 2023 18:33:51 -0400 Received: from out-183.mta1.migadu.com (out-183.mta1.migadu.com [IPv6:2001:41d0:203:375::b7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D1BC591 for ; Thu, 26 Oct 2023 15:33:48 -0700 (PDT) X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1698359625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=7wiIXHVKZViLnzrPPkXa8K3V9xAsF9dc3+hDNlwl8Us=; b=DockHeTSLWJS3ERDQQ+vQdQYjzFI2cE8pqfjeWbPs+7eooLKzDkjxQGpB3HmA5VqHJGkSp W6Ygtk0ICvM35OJJe8Yeyf4vzFXFxOh1hmy3yWs8cwlUkj25F2MZo/ficlYUspPUSNbCTG ypIvUVDuxmxvQYyAUsT6qT6DD9WW/sc= From: andrey.konovalov@linux.dev To: Andrew Morton Cc: Andrey Konovalov , Marco Elver , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , Oscar Salvador , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: [PATCH] fix for "lib/stackdepot: allow users to evict stack traces" Date: Fri, 27 Oct 2023 00:33:40 +0200 Message-Id: <20231026223340.333159-1-andrey.konovalov@linux.dev> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]); Thu, 26 Oct 2023 15:34:07 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780859168415270193 X-GMAIL-MSGID: 1780859168415270193 From: Andrey Konovalov Commit "lib/stackdepot: allow users to evict stack traces" adds another user for depot_fetch_stack, which holds a write lock. Thus, we need to update the lockdep annotation. Signed-off-by: Andrey Konovalov --- lib/stackdepot.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c index 3a8f045696fd..cf707ff32d7d 100644 --- a/lib/stackdepot.c +++ b/lib/stackdepot.c @@ -388,7 +388,7 @@ static struct stack_record *depot_fetch_stack(depot_stack_handle_t handle) size_t offset = parts.offset << DEPOT_STACK_ALIGN; struct stack_record *stack; - lockdep_assert_held_read(&pool_rwlock); + lockdep_assert_held(&pool_rwlock); if (parts.pool_index > pools_num) { WARN(1, "pool index %d out of bounds (%d) for stack id %08x\n",