From patchwork Thu Oct 26 18:18:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Hortmann X-Patchwork-Id: 158632 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp77423vqb; Thu, 26 Oct 2023 11:18:44 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHbsDUZZB22f7utb2OdseUBA0FgQ6ZBkmYdHUc87AG1IzbDUrB9e+Tc5PviHxVIMbk19K+t X-Received: by 2002:a25:4104:0:b0:d9c:a920:9ae1 with SMTP id o4-20020a254104000000b00d9ca9209ae1mr133830yba.32.1698344323968; Thu, 26 Oct 2023 11:18:43 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698344323; cv=none; d=google.com; s=arc-20160816; b=F2Tds3bHh/KM2tpQC5vZR/NwGllF/B0FS/scvdQgp4pXup4YNY0/FkBZ4uRf4zJTez puG4PXUNsJDeeeU0yjnHkCrs0TsK/3gES7Lp4B2Kb1rce02n98USE0r/naDOhPWuAmU3 a3DIlYePZuyRmuNYTUFlXrArknT3ZNLDPlzcbFNUdmKfqWxb1yrx0wkMdjTspUZ+3OaT 4XBC8SwlNaZkHhFsA9RGcw9tIJrvn+tw47l5xugGHWZotC6A3v/+juDrR9Y2UKEBtz6Z B/28O0Shzagp1btBzmLmHIIGsEGep43aPemoW9pJ2yfuDdl9cmBlz744iyKC+z57ByKt lBBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-disposition:mime-version:message-id :subject:cc:to:from:date:dkim-signature; bh=vTA02l0ubFVwBtbEfhw+KExb6bkxv2C0e8twmLrMufI=; fh=V9VK+XjB17lLLrHQIBVbMgPga2HrXk567vRC0rbWjUE=; b=PdvOycNo6tKUAQphtn78sbEFYKm9NLheCh5V5mZVdpt7FYOCv4HamMd5hL8YDBfdVS zFi1Y3/linA8jY/RwjNM4gCku+olH4dtLXY6aSMvkNJVQ8FDvzkZCBumi0kuOgNcgOrT 9sKSUmMI+waQ2reDUCUUT2ZY5XdtPmdV1dihBEEwtTh/2YLF/GFWbrhvbAErvG7rRUv5 0c7k4haUNt9dG/XWoTss/4WY4jPjMWTZpU+8EV9WsV+QDNbdHsniZZSI+tU9w0oG1M3m TWQyhjzihmRwVfFX+na6hYr8d4g30HOFxvjUBwNd0H8y1nySK1TREOpEpsIEGdotlFYw 9E5w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=J0NwBsvC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id j185-20020a2555c2000000b00d9ffbe11c19si10150380ybb.381.2023.10.26.11.18.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 11:18:43 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=J0NwBsvC; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 84A7D839233E; Thu, 26 Oct 2023 11:18:41 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231676AbjJZSS2 (ORCPT + 26 others); Thu, 26 Oct 2023 14:18:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231701AbjJZSS0 (ORCPT ); Thu, 26 Oct 2023 14:18:26 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D6F7E1BD for ; Thu, 26 Oct 2023 11:18:24 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-9cc6c92d1e9so36040366b.1 for ; Thu, 26 Oct 2023 11:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698344303; x=1698949103; darn=vger.kernel.org; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=vTA02l0ubFVwBtbEfhw+KExb6bkxv2C0e8twmLrMufI=; b=J0NwBsvC9wBnqtFFoewVnsHvlxPqQTjLUnS6at9Dm+82kS3TWTMaeRLkBbEOzjIJUx uRTWkFJWImp/8B5khUz+eP0cdU2kUqaNBQujCgU6VVKzKrjlgDe5xvCGqkPpnZRMPfAE 7eO5qLHR3wHF2KvkpvPnxP8sqWlX3Ap7g5vcENXnrev9FL4TDP8b24pOgONDJ1rLsj81 JAbS+kggMFHHCBCG0zke+vPToWOsvRsj4RIVX6it44/g3OaWHOU+7b8KWHX5HAC7O3yP oHgPxgTRSmDVTm6BdNyna/erkm2nd4cYHvM132vpU9GmtCQpmK2EVCz2WZs7yKqfyubO kqGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698344303; x=1698949103; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vTA02l0ubFVwBtbEfhw+KExb6bkxv2C0e8twmLrMufI=; b=cpW/uIIoA0cWPsSfEgOatRNXceb72QyKChMZxREj46OtGgh70ryGaQ7ZYwglI9UprT ySaU/p7CXBDKtejBJV7aFwU9txD4gZppEEv9na6M7WgLGAx5y6KQxM8YeHhPKb1rBbec HFDYwp3ZQDt8a0xe/PYIXvDtWn069KzJ7SxutulgphInbTMfRtuM5npFQVwktL/xl6BP vP4J8MOUsa6LV+7Xb3E0F2rD1P80Eh1lAtElN5N/lHqm/pGM/TmAA66EuR/HGmXRmPFB 1EKDNPfkkERsk09SURbffp9vWe5Bqdzfeha7kWgOc/kjqguih9C85dRiNH/QnLZeDMp5 Zr0A== X-Gm-Message-State: AOJu0YxC/LbEX+o77DMYADcjbSSBY0S2f7ZYycHCucUsFQca3G7KgKs+ +KsvvBbEXF0jkpj3V4xNPvw= X-Received: by 2002:a17:907:2d27:b0:9c7:5db4:8080 with SMTP id gs39-20020a1709072d2700b009c75db48080mr348999ejc.7.1698344302945; Thu, 26 Oct 2023 11:18:22 -0700 (PDT) Received: from matrix-ESPRIMO-P710 (p579356c7.dip0.t-ipconnect.de. [87.147.86.199]) by smtp.gmail.com with ESMTPSA id p6-20020a1709060e8600b0098e78ff1a87sm11985037ejf.120.2023.10.26.11.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 11:18:22 -0700 (PDT) Date: Thu, 26 Oct 2023 20:18:21 +0200 From: Philipp Hortmann To: Greg Kroah-Hartman , linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Cc: Dan Carpenter Subject: [PATCH] staging: rtl8192e: Fix line break issue at priv->rx_buf[priv->rx_idx] Message-ID: <20231026181821.GA21819@matrix-ESPRIMO-P710> MIME-Version: 1.0 Content-Disposition: inline X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Thu, 26 Oct 2023 11:18:41 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780843097650181112 X-GMAIL-MSGID: 1780843097650181112 Fix line break at priv->rx_buf[priv->rx_idx] to increase readability. Suggested-by: Dan Carpenter Signed-off-by: Philipp Hortmann --- Tested with rtl8192e (WLL6130-D99) in Mode n (12.5 MB/s) Transferred this patch over wlan connection of rtl8192e. --- drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c index d2a8a9543579..995daab906c9 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -1610,8 +1610,7 @@ static void _rtl92e_rx_normal(struct net_device *dev) skb = new_skb; skb->dev = dev; - priv->rx_buf[priv->rx_idx] = - skb; + priv->rx_buf[priv->rx_idx] = skb; *((dma_addr_t *)skb->cb) = dma_map_single(&priv->pdev->dev, skb_tail_pointer(skb), priv->rxbuffersize, DMA_FROM_DEVICE);