diff mbox series

[-next] fs: Remove unneeded semicolon

Message ID 20231026005634.6581-1-yang.lee@linux.alibaba.com
State New
Headers
Series [-next] fs: Remove unneeded semicolon |

Commit Message

Yang Li Oct. 26, 2023, 12:56 a.m. UTC 
  ./fs/proc/base.c:3829:2-3: Unneeded semicolon

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7057
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
 fs/proc/base.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Oleg Nesterov Oct. 26, 2023, 3:03 p.m. UTC | #1 
On 10/26, Yang Li wrote:
>
> @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
>  	for_each_thread(task, pos) {
>  		if (!nr--)
>  			goto found;
> -	};
> +	}

Ah, I forgot to remove this semicolon :/

This is on top of

	document-while_each_thread-change-first_tid-to-use-for_each_thread.patch

perhaps this cleanup can be folded into the patch above along with Yang's sob ?

If Yang doesn't object.

Oleg.
Andrew Morton Oct. 26, 2023, 3:23 p.m. UTC | #2 
On Thu, 26 Oct 2023 17:03:35 +0200 Oleg Nesterov <oleg@redhat.com> wrote:

> On 10/26, Yang Li wrote:
> >
> > @@ -3826,7 +3826,7 @@ static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
> >  	for_each_thread(task, pos) {
> >  		if (!nr--)
> >  			goto found;
> > -	};
> > +	}
> 
> Ah, I forgot to remove this semicolon :/
> 
> This is on top of
> 
> 	document-while_each_thread-change-first_tid-to-use-for_each_thread.patch
> 
> perhaps this cleanup can be folded into the patch above along with Yang's sob ?

The above is in mainline, so no squashing.  I added your acked-by.
diff mbox series

Patch

diff --git a/fs/proc/base.c b/fs/proc/base.c
index bfe9547d16f9..dd31e3b6bf77 100644
--- a/fs/proc/base.c
+++ b/fs/proc/base.c
@@ -3826,7 +3826,7 @@  static struct task_struct *first_tid(struct pid *pid, int tid, loff_t f_pos,
 	for_each_thread(task, pos) {
 		if (!nr--)
 			goto found;
-	};
+	}
 fail:
 	pos = NULL;
 	goto out;