From patchwork Wed Oct 25 18:03:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Morse X-Patchwork-Id: 158198 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:d641:0:b0:403:3b70:6f57 with SMTP id cy1csp138431vqb; Wed, 25 Oct 2023 11:05:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGCRKlarwJAK1V/VpcbTVdCg12rqhM5iQC/mi+jxrKSGZfusVnx1zWqMXiGd31IY+Q/k5sz X-Received: by 2002:a05:6102:1005:b0:457:6b29:9486 with SMTP id q5-20020a056102100500b004576b299486mr15128080vsp.33.1698257101950; Wed, 25 Oct 2023 11:05:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698257101; cv=none; d=google.com; s=arc-20160816; b=kcPLtwfp41lkfGtaqK+XB/M2J3zE8Hyv9gBF0R9VvMSeGokcjnBtxq9JBWo5cJMDgx qicK0LRTGnfixzL16rci0T7o+f200iWA1dPFhyGHf1QDcdd59jHf9iyjnqVv63jtVf8U RC23ZsIT1ym+8tVKjEPtR6awQv2dezqlCY9JL+V6RAJUjMfba50g7nSyAowuBU+J9RIk EU2P8yGF4GaNMshx961m/WTBoxiPMjIG7ixGq/j5VQjaCJ/CsnOQTGL9/CVHTjc7uRoy DD0appnYPa0gVkhNf577kBED/OE45bu4k+8TKE/bj7eoIRwu65YnVezHUAfeZKilg2hS oxpg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=Y728JWkQ0n8eY13e4n7rw4iGfj3LAYGB5X/HQguR0aw=; fh=xjsbdB8NZJzbiqygyESgWUxyd4BI3/oiWXjD1LwrF60=; b=ApBe7ePS+ayGZ8PUZnfB2+mWiJ9l41cuxX69OHNlAYv9N2iB5fU2C5cMR64h7HVUIX rgu4qnOCPfLjxTzJFolcTU6YfcM+inzcSumj/yQOF3v0IuD22TdiYSoyAr9chfF60PX2 4H5G6r0km1nUmxJUiSQ0hiqKbYIABUsncUoE3fk+96NZwGTuvMFMjtkPShUdj9Dmwhq7 2M4zHLTa1e3u6KOLVi0RTmuPRBxaIRR34iAQpPYl2wg2dY9Gi4KniMGThqu8DiiBA15Q /oyBY+adgXxYPsEahsYQAOTxfs+cph5xlbQK22JBKyxN+ijdLMdbaaheH8CgtQu1S7sz MhRg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from groat.vger.email (groat.vger.email. [23.128.96.35]) by mx.google.com with ESMTPS id g3-20020a67e283000000b00452d9b2fd58si1311631vsf.392.2023.10.25.11.05.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 11:05:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) client-ip=23.128.96.35; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.35 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id BD506802AFCD; Wed, 25 Oct 2023 11:04:58 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229625AbjJYSEt (ORCPT + 26 others); Wed, 25 Oct 2023 14:04:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230035AbjJYSEr (ORCPT ); Wed, 25 Oct 2023 14:04:47 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id F14F2123 for ; Wed, 25 Oct 2023 11:04:43 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5202A1FB; Wed, 25 Oct 2023 11:05:25 -0700 (PDT) Received: from merodach.members.linode.com (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6DFB83F738; Wed, 25 Oct 2023 11:04:40 -0700 (PDT) From: James Morse To: x86@kernel.org, linux-kernel@vger.kernel.org Cc: Fenghua Yu , Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , H Peter Anvin , Babu Moger , James Morse , shameerali.kolothum.thodi@huawei.com, D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, Frederic Weisbecker Subject: [PATCH v7 01/24] tick/nohz: Move tick_nohz_full_mask declaration outside the #ifdef Date: Wed, 25 Oct 2023 18:03:22 +0000 Message-Id: <20231025180345.28061-2-james.morse@arm.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20231025180345.28061-1-james.morse@arm.com> References: <20231025180345.28061-1-james.morse@arm.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Wed, 25 Oct 2023 11:04:58 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780751639155561928 X-GMAIL-MSGID: 1780751639155561928 tick_nohz_full_mask lists the CPUs that are nohz_full. This is only needed when CONFIG_NO_HZ_FULL is defined. tick_nohz_full_cpu() allows a specific CPU to be tested against the mask, and evaluates to false when CONFIG_NO_HZ_FULL is not defined. The resctrl code needs to pick a CPU to run some work on, a new helper prefers housekeeping CPUs by examining the tick_nohz_full_mask. Hiding the declaration behind #ifdef CONFIG_NO_HZ_FULL forces all the users to be behind an ifdef too. Move the tick_nohz_full_mask declaration, this lets callers drop the ifdef, and guard access to tick_nohz_full_mask with IS_ENABLED() or something like tick_nohz_full_cpu(). The definition does not need to be moved as any callers should be removed at compile time unless CONFIG_NO_HZ_FULL is defined. Tested-by: Shaopeng Tan Tested-by: Peter Newman Reviewed-by: Shaopeng Tan Acked-by: Reinette Chatre # for resctrl dependency CC: Frederic Weisbecker Signed-off-by: James Morse --- No changes since v6 include/linux/tick.h | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/include/linux/tick.h b/include/linux/tick.h index 716d17f31c45..0fb903838dfb 100644 --- a/include/linux/tick.h +++ b/include/linux/tick.h @@ -164,9 +164,16 @@ static inline u64 get_cpu_idle_time_us(int cpu, u64 *unused) { return -1; } static inline u64 get_cpu_iowait_time_us(int cpu, u64 *unused) { return -1; } #endif /* !CONFIG_NO_HZ_COMMON */ +/* + * Mask of CPUs that are nohz_full. + * + * Users should be guarded by CONFIG_NO_HZ_FULL or a tick_nohz_full_cpu() + * check. + */ +extern cpumask_var_t tick_nohz_full_mask; + #ifdef CONFIG_NO_HZ_FULL extern bool tick_nohz_full_running; -extern cpumask_var_t tick_nohz_full_mask; static inline bool tick_nohz_full_enabled(void) {