From patchwork Wed Oct 25 15:25:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dario Binacchi X-Patchwork-Id: 158172 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6b8b:b0:164:83eb:24d7 with SMTP id ta11csp2738401rwb; Wed, 25 Oct 2023 08:28:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF6OOAL4izjNWYUELELFqEaMCeTQWNsNKLP6RnRQ0izlc8VNFTVI5rZS7Rryu+u1ZtSV/Qa X-Received: by 2002:a05:6870:13ca:b0:1ea:29a:8628 with SMTP id 10-20020a05687013ca00b001ea029a8628mr14978677oat.15.1698247687856; Wed, 25 Oct 2023 08:28:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698247687; cv=none; d=google.com; s=arc-20160816; b=T2d5HkgLRhvzHNmoMFTm3qgqqnXypR0akp1aSlx9xPkvcByCULWuvqxN4s1iPtJ46D 2ZTk5C/jS+gzVtcBChqZP7FO8sYQOS/8/1gKR60mPljVZMtH4MgCX9af8j3VOx5opvHQ 5lLef0DrZ2Ik0IgcHL5VMDau5mweG5x/bSiqv9YAIRov3VQBXu/kvKx9ovx/vt+Hhxrw sDQ3UbVWOOPUZ1Zt/SFxPTaCr6avmU1mCPyIpN358BIlXLMJ8I2PaK3Q2jlJGvX7uZKd HbFcggNAqhBbqosGVpi0yrYpdDX5l46di+X4vxg2qyNdh1nK4JXlJFvDOuv5CHjgHcfr YQoA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=N6kIXcR1VU3TM5nz+Od8WlpDMDBhPdIZjdnlTVp9UJg=; fh=1VObC5A+oI3eO2Of4E6qwoPtcw+uKAqnPGn2H3ojoIM=; b=Q9hPoaMDWN//cik+QOIVF1EJ/kNmCK57l4CPhAk327WPm+1FGr/KtAXcdejv4mjiRV Wxjn+dVh4T6KIFjgbQ14mC/0xMJ2OcSM4kIIXpz5Sh2Jv2HzqtIvnyVwQJ8b3B9ZjLYZ 1/OIBfpbX9dDzlH4+7FRiwBv6J53bEqphJzHzbzS5LNTaShe/+lkousdfqsyn0DBTDp8 hiDV1reALjPhT5xI8vDEDm90fiHf1ZPvMzFWG7gq+sFql4wVcrA1MvFeyD85UzWhIVkA 6g2T0bdtNxpYFbKkmT7blZstK7WZZa6nZ6qMruZMRKqcriPptQPzBrBMAGLY3xJDL3R8 x2CQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ISrtjaY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id w4-20020a816204000000b0059f4ea770c5si12345265ywb.268.2023.10.25.08.28.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 08:28:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@amarulasolutions.com header.s=google header.b=ISrtjaY1; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=amarulasolutions.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id C7FD0801C89E; Wed, 25 Oct 2023 08:28:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344472AbjJYP1y (ORCPT + 26 others); Wed, 25 Oct 2023 11:27:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40654 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344795AbjJYP1S (ORCPT ); Wed, 25 Oct 2023 11:27:18 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DC301B6 for ; Wed, 25 Oct 2023 08:26:14 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id a640c23a62f3a-9c603e235d1so893607466b.3 for ; Wed, 25 Oct 2023 08:26:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; t=1698247572; x=1698852372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=N6kIXcR1VU3TM5nz+Od8WlpDMDBhPdIZjdnlTVp9UJg=; b=ISrtjaY1JTvN7+81n9yRw1qgEnccwmIX9L5gOS0S5U8+uVbNcy36UuSpZn1k2gzq64 0KtaPfveXQZFPX1gJSWaBg3IcIlkvmBu0uE8DqaD5XBmxD/UNcGWHdhK9CFIrw+LvKCe 6dpDwOyGVdG8fjJnpLxiaoaSCxG76gvtCXf4c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698247572; x=1698852372; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=N6kIXcR1VU3TM5nz+Od8WlpDMDBhPdIZjdnlTVp9UJg=; b=mpdO99axGDBmM7TIiAaf/HrDu70sqfoXr8O/yXlwZiZ8AALtoiBtLX52luBfKvnddC ypwJZlHl/kKxr6IA8edIPLIfOiHYFC4hMYhRHzBo8knwmarzWQIm4lLaRTG8pUBH6ePx LiAMpjkf+flUUZQGP1W7s+Ef4mDQG/68v1u1uE6l51OtKoLU4OV3z14d/K1RzRLW4hAj yAsHN7mGQS9c6SlE8jnK+jxpFdpM8QrGbS6pA0W8mMOius18q5bAKcDcJ9l6loTQXo4V rZhKztF12EOBHwsu3ANIER3elJ0sbzrvRWyevv86AZcnKYXGCz5a2xDfNxyBCtTBLuPD U6Dw== X-Gm-Message-State: AOJu0YxTCp7N8EiYAnSB8RDzT2Uhl5KfveMPpJ3IjH1LTME7cYHzYk3m sJ2EHjXS01SfFSiHncc0BIOx7XAx+nNMFNpgPIoeKg== X-Received: by 2002:a17:907:c386:b0:9c7:fd91:4309 with SMTP id tm6-20020a170907c38600b009c7fd914309mr8380498ejc.0.1698247572476; Wed, 25 Oct 2023 08:26:12 -0700 (PDT) Received: from dario-ThinkPad-T14s-Gen-2i.homenet.telecomitalia.it (host-82-50-51-252.retail.telecomitalia.it. [82.50.51.252]) by smtp.gmail.com with ESMTPSA id u24-20020a170906409800b009bf94de8971sm10110156ejj.70.2023.10.25.08.26.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 08:26:12 -0700 (PDT) From: Dario Binacchi To: linux-kernel@vger.kernel.org Cc: Dario Binacchi , Baolu Lu , Joerg Roedel , Jonathan Hunter , Krishna Reddy , Robin Murphy , Thierry Reding , Will Deacon , iommu@lists.linux.dev, linux-tegra@vger.kernel.org Subject: [PATCH v2] iommu/tegra-smmu: drop error checking for debugfs_create_dir() Date: Wed, 25 Oct 2023 17:25:58 +0200 Message-ID: <20231025152609.2042815-1-dario.binacchi@amarulasolutions.com> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 25 Oct 2023 08:28:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780741767659805579 X-GMAIL-MSGID: 1780741767659805579 The return value of debugfs_create_dir() should be checked using the IS_ERR() function. The patch, however, drops the check statement without fixing it because the subsequent functions (i. e. debugfs_create_file()) can handle the case where `@parent` is an error pointer. Suggested-by: Baolu Lu Signed-off-by: Dario Binacchi --- Changes in v2: - drop the error checking statement drivers/iommu/tegra-smmu.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/iommu/tegra-smmu.c b/drivers/iommu/tegra-smmu.c index e445f80d0226..3e573148d18c 100644 --- a/drivers/iommu/tegra-smmu.c +++ b/drivers/iommu/tegra-smmu.c @@ -1056,9 +1056,6 @@ DEFINE_SHOW_ATTRIBUTE(tegra_smmu_clients); static void tegra_smmu_debugfs_init(struct tegra_smmu *smmu) { smmu->debugfs = debugfs_create_dir("smmu", NULL); - if (!smmu->debugfs) - return; - debugfs_create_file("swgroups", S_IRUGO, smmu->debugfs, smmu, &tegra_smmu_swgroups_fops); debugfs_create_file("clients", S_IRUGO, smmu->debugfs, smmu,