[v3,4/7] regulator: dt-bindings: whitelist system-critical-regulator property for fixed-regulator
Message ID | 20231025084614.3092295-5-o.rempel@pengutronix.de |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2454594vqx; Wed, 25 Oct 2023 01:46:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG7TMrf1qBg3nCTVyd50OlTsu+I3wUKCn9ACXo2SXqf+hBAshSvGoOLowuyRfQwNnyp/Bu9 X-Received: by 2002:a81:834a:0:b0:59b:ce0b:7829 with SMTP id t71-20020a81834a000000b0059bce0b7829mr15219817ywf.35.1698223614900; Wed, 25 Oct 2023 01:46:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698223614; cv=none; d=google.com; s=arc-20160816; b=0sDEMQKjCsUHjsmPGxew5JRkDcQ5TykwLB54SIe1MB+xMFix9LDHQOFMU70RIwxxmx hvAFEqblYXKC46lY8V6SsVtsgcXunGrrm+8K7pTPxzxAlWlYh1+0SZ7otHTHihRbpgwB w53AunkSNS0jevaPeR3X48cUNkICZ8qFr0osBkYpjJtjIabO/PWMAzl913Gb2uSmq2+p hjWsNdxJgGra6yhzxg2ZOEn34gDpyaLxmRxmsf53zQI2oGUfShMLwD1pKsTZSIiXlRL6 Wb8fJQdU6bYKB4IwekpSfuqLnRmtaeRcQL+L+IZnGdqzQvYvksfcv/ziQ/MAfxsGTlNB KeXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=FnOv1EA5M8cRIIVNv66akuO1LzVF2C98nFZoTc8ufjE=; fh=04ly7V1xWE1eBTBwtRUQiwjHX8ICozxkXNJpuSLZLOA=; b=BU9wtr+i2KY0uwX6SI5Iug/gd81BJgZ6ZAnqahgd5Z8bBVX9wc+nttrOMIYByQ+Gum PmVGEcwWhBpXMTdf3Z11dKT1sv2ViSWWNabRAXgQfWI4jZlJlhLRIgSWtlEBsDYhPONI ZbTe6BqY7CdKbzoao4D05a2E8I15i8HOciGIROrn4YS23vFTffB/5Vwk9vHwjxfY4RLV Z5x3lgH5SB62fgOoEHoRp4cedabUJGMxFotV0i2HvvMiiZaOv0ScY8pOn66I5iNPSfVW /7Y9hvoN9eHY7Gvk5mA5po21+8Ni6DRhaZ9XMylFBceauGYrzQBk1KZMcQu+ys/QW3+i tFBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id w14-20020a0dd40e000000b005a7cce3a27dsi11049908ywd.320.2023.10.25.01.46.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Oct 2023 01:46:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 8AC068020130; Wed, 25 Oct 2023 01:46:52 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234364AbjJYIql (ORCPT <rfc822;aposhian.dev@gmail.com> + 26 others); Wed, 25 Oct 2023 04:46:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56236 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234006AbjJYIq2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 25 Oct 2023 04:46:28 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31683183 for <linux-kernel@vger.kernel.org>; Wed, 25 Oct 2023 01:46:26 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <ore@pengutronix.de>) id 1qvZWq-0002CD-9k; Wed, 25 Oct 2023 10:46:16 +0200 Received: from [2a0a:edc0:0:1101:1d::ac] (helo=dude04.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <ore@pengutronix.de>) id 1qvZWp-0048Wd-CC; Wed, 25 Oct 2023 10:46:15 +0200 Received: from ore by dude04.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from <ore@pengutronix.de>) id 1qvZWp-00CySu-12; Wed, 25 Oct 2023 10:46:15 +0200 From: Oleksij Rempel <o.rempel@pengutronix.de> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org> Cc: Oleksij Rempel <o.rempel@pengutronix.de>, kernel@pengutronix.de, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: [PATCH v3 4/7] regulator: dt-bindings: whitelist system-critical-regulator property for fixed-regulator Date: Wed, 25 Oct 2023 10:46:11 +0200 Message-Id: <20231025084614.3092295-5-o.rempel@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231025084614.3092295-1-o.rempel@pengutronix.de> References: <20231025084614.3092295-1-o.rempel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ore@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 25 Oct 2023 01:46:52 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780716525120096355 X-GMAIL-MSGID: 1780716525120096355 |
Series |
regulator: add under-voltage support
|
|
Commit Message
Oleksij Rempel
Oct. 25, 2023, 8:46 a.m. UTC
Allow fixed-regulator to be marked as system-critical by whitelisting
the 'system-critical-regulator' property.
This property indicating that the fixed-regulator is critical to system
stability or functionality, aligning with the recent changes in the
regulator core handling of under-voltage events for system-critical
regulators.
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
---
.../devicetree/bindings/regulator/fixed-regulator.yaml | 2 ++
1 file changed, 2 insertions(+)
Comments
On Wed, Oct 25, 2023 at 10:46:11AM +0200, Oleksij Rempel wrote: > Allow fixed-regulator to be marked as system-critical by whitelisting > the 'system-critical-regulator' property. > > This property indicating that the fixed-regulator is critical to system > stability or functionality, aligning with the recent changes in the > regulator core handling of under-voltage events for system-critical > regulators. Why would this need to be something we explicitly enable for a given regulator? Surely this is a property of the creativity of hardware engineers rather than the regulator itself. Also please avoid the use of the outdated terms whitelist and blacklist, pass and block lists are often a good alternative.
On Wed, Oct 25, 2023 at 01:41:45PM +0100, Mark Brown wrote: > On Wed, Oct 25, 2023 at 10:46:11AM +0200, Oleksij Rempel wrote: > > Allow fixed-regulator to be marked as system-critical by whitelisting > > the 'system-critical-regulator' property. > > > > This property indicating that the fixed-regulator is critical to system > > stability or functionality, aligning with the recent changes in the > > regulator core handling of under-voltage events for system-critical > > regulators. > > Why would this need to be something we explicitly enable for a given > regulator? Surely this is a property of the creativity of hardware > engineers rather than the regulator itself. :) > Also please avoid the use of the outdated terms whitelist and blacklist, > pass and block lists are often a good alternative. ack
diff --git a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml index ce7751b9129c..9ff9abf2691a 100644 --- a/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml +++ b/Documentation/devicetree/bindings/regulator/fixed-regulator.yaml @@ -105,6 +105,8 @@ properties: description: Interrupt signaling a critical under-voltage event. + system-critical-regulator: true + required: - compatible - regulator-name