From patchwork Wed Oct 25 00:53:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Andr=C3=A9_Almeida?= X-Patchwork-Id: 157780 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2293066vqx; Tue, 24 Oct 2023 17:54:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEpYhiZtbK5rFTRvm/yN6gi0k1cF5fr47uzL0vk4FLjLywEAK/ZvphR7IFdeehwldPTJnRY X-Received: by 2002:a25:374a:0:b0:da0:3b6c:fc22 with SMTP id e71-20020a25374a000000b00da03b6cfc22mr3416033yba.31.1698195248344; Tue, 24 Oct 2023 17:54:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698195248; cv=none; d=google.com; s=arc-20160816; b=C+tTQ0Gh2lRM1xyFuLgNdegG8tydwQsL1koSGRC+SvyzdBwh4LDjiFg6nfnrXBBaAB DPl25UwskYYGDP9ZqdZKt8A+M8Ih4EeEMhA1eeZEftFIiN2aaAh5I5eC6thutW+wmnjN twpGqO4V4VPeYo+Hk4j+D3M54bBSUhqMeDMwKEQ988kNSdR7uQ5BNsM1w7VVIH5HgNqi pSTedbjsW2i0zyOmE88IJ4V+HXmANKerbEDBDXNTimXodCro+f73m1YU7pH9QV4Mplt9 IVBDFvJ0Sa+7gGCwkXLUPba19yW1HJTASsrSq3JVTytUmnClVC50u/bMCo/fqr2CpYKS hXgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dQbTPqJByKTPRLvnAel3VnOmQ8OJEdk4CamVdOalghI=; fh=oozRrKarZZG8EJ8TWYFtLglEZVoKmF8bWYorcz/JMDw=; b=as0R5K5sJTQx5FmfmnAONdmX173Mlqw8DjywxN8Hm11Qd3qHL08iuLo5kGfXLrpGSS hP2VmgmEJBcW1MsX6UEY3fPrxAiVLSnf4kdx3DZmvwDP7xr6ESTJTeifLqFWsCcS2iQu ptSQinj5ZGmpIUOdXSZrQFKjKROM+IMfl1uuSor5Wsb2tGQOzA4fdOOPcQ+IwHcaq3/D Liiltk+106ydegxqyYg1XSh5iyOGMIVG9DOhdAGSkH8w8gj8prORrHN42LRqUIMd3FPo g/XRxQw3snJIKdCK2kijh+gXM86DIviXqHn3M+SoUSOstiEDBb/7QLLSXbj6fx35spB1 lywg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=hthFN61C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id d34-20020a25ade2000000b00da0735957fasi422129ybe.701.2023.10.24.17.54.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 17:54:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=fail header.i=@igalia.com header.s=20170329 header.b=hthFN61C; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 701B9802189C; Tue, 24 Oct 2023 17:54:05 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229830AbjJYAxv (ORCPT + 26 others); Tue, 24 Oct 2023 20:53:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229470AbjJYAxn (ORCPT ); Tue, 24 Oct 2023 20:53:43 -0400 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C708FD7D for ; Tue, 24 Oct 2023 17:53:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=dQbTPqJByKTPRLvnAel3VnOmQ8OJEdk4CamVdOalghI=; b=hthFN61C8pMIVQZ9RcWSEyznZC DCeWLPIkDfiSIsBrhvaJDxWCUUTEfmCVssQ1H32zqZhFNWHFykB/dHTnX0gjyyu1gf9x9v0J7XyQ+ C7yJkfnSuooedqn98rRf9GBdD0x7sgem+HcqZwo6Njr+7NHky5TXnUM9ye6cAAGFXZf8kDobb9L3B 1inDoSVQ8yliZsA1h/+ihIVj6U8wxx7xY2XvdY8ad5vNS3U6K7W+9uHPMiSw7gr7a/5OZZ2LVaaDS JRfQnttuCmahd0DJbWb/julEFp9GlpOdd8HFFnlvGEPk+6WQlZy+jyc6ae6iSRa0KDfJAMaax/gUf Ip2CnGdA==; Received: from [191.193.179.125] (helo=steammachine.lan) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim) id 1qvS9R-006qog-CV; Wed, 25 Oct 2023 02:53:37 +0200 From: =?utf-8?q?Andr=C3=A9_Almeida?= To: dri-devel@lists.freedesktop.org, amd-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: kernel-dev@igalia.com, alexander.deucher@amd.com, christian.koenig@amd.com, pierre-eric.pelloux-prayer@amd.com, Simon Ser , Rob Clark , Pekka Paalanen , Daniel Vetter , Daniel Stone , =?utf-8?b?J01hcmVrIE9sxaHDoWsn?= , Dave Airlie , =?utf-8?q?Michel_D=C3=A4nzer?= , Randy Dunlap , =?utf-8?q?Andr=C3=A9_Almeida?= Subject: [PATCH v8 2/6] drm: introduce DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP Date: Tue, 24 Oct 2023 21:53:14 -0300 Message-ID: <20231025005318.293690-3-andrealmeid@igalia.com> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231025005318.293690-1-andrealmeid@igalia.com> References: <20231025005318.293690-1-andrealmeid@igalia.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 17:54:05 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780686780961570360 X-GMAIL-MSGID: 1780686780961570360 From: Simon Ser This new kernel capability indicates whether async page-flips are supported via the atomic uAPI. DRM clients can use it to check for support before feeding DRM_MODE_PAGE_FLIP_ASYNC to the kernel. Make it clear that DRM_CAP_ASYNC_PAGE_FLIP is for legacy uAPI only. Signed-off-by: Simon Ser Reviewed-by: André Almeida Reviewed-by: Alex Deucher Signed-off-by: André Almeida --- drivers/gpu/drm/drm_ioctl.c | 5 +++++ include/uapi/drm/drm.h | 10 +++++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_ioctl.c b/drivers/gpu/drm/drm_ioctl.c index 77590b0f38fa..a96e7acb9071 100644 --- a/drivers/gpu/drm/drm_ioctl.c +++ b/drivers/gpu/drm/drm_ioctl.c @@ -301,6 +301,11 @@ static int drm_getcap(struct drm_device *dev, void *data, struct drm_file *file_ case DRM_CAP_CRTC_IN_VBLANK_EVENT: req->value = 1; break; + case DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP: + req->value = drm_core_check_feature(dev, DRIVER_ATOMIC) && + dev->mode_config.async_page_flip && + !dev->mode_config.atomic_async_page_flip_not_supported; + break; default: return -EINVAL; } diff --git a/include/uapi/drm/drm.h b/include/uapi/drm/drm.h index 794c1d857677..58baefe32c23 100644 --- a/include/uapi/drm/drm.h +++ b/include/uapi/drm/drm.h @@ -713,7 +713,8 @@ struct drm_gem_open { /** * DRM_CAP_ASYNC_PAGE_FLIP * - * If set to 1, the driver supports &DRM_MODE_PAGE_FLIP_ASYNC. + * If set to 1, the driver supports &DRM_MODE_PAGE_FLIP_ASYNC for legacy + * page-flips. */ #define DRM_CAP_ASYNC_PAGE_FLIP 0x7 /** @@ -773,6 +774,13 @@ struct drm_gem_open { * :ref:`drm_sync_objects`. */ #define DRM_CAP_SYNCOBJ_TIMELINE 0x14 +/** + * DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP + * + * If set to 1, the driver supports &DRM_MODE_PAGE_FLIP_ASYNC for atomic + * commits. + */ +#define DRM_CAP_ATOMIC_ASYNC_PAGE_FLIP 0x15 /* DRM_IOCTL_GET_CAP ioctl argument type */ struct drm_get_cap {