From patchwork Tue Oct 24 19:17:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?VmlsbGUgU3lyasOkbMOk?= X-Patchwork-Id: 157677 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2154766vqx; Tue, 24 Oct 2023 12:17:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHJFsK4J8hhtxQlxnF7p3aMrvEEE0g92rpLWi7MafgpcZAfTK6zb0ec4iPVP4SfHhhuxvRy X-Received: by 2002:a17:903:244f:b0:1ca:495c:77d with SMTP id l15-20020a170903244f00b001ca495c077dmr12936169pls.18.1698175061067; Tue, 24 Oct 2023 12:17:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698175061; cv=none; d=google.com; s=arc-20160816; b=iOcbNuZgpGbJY3DArbTojWQCP8IiPBa1uc6FktZ05loRY+JwhDKH4HNDxvK1HnQDJQ jRv2IQZwMugM6eoLZOMaKm27dFwYyR8Ys0tu1gtSGTwu4Eh8JEBVMjIcWImOCsxj82sI gShHgL9TIs4XQur3sv5z7Tc9eLrhFL+PQEiReL/4nzOMPTGdElH+o3ZDKzxHgIYDYJ2d DG/2DSuOmNUQRP/GrLnWiGQaRWyqMaQ5Rrs9Jwv6NG1kfpvYpSCUO8DQ4iqjusiRtk3r PvppKPsBl3qQ6HAiVqJ89B8n3TnJiuPytbXJAPs/xEYGarU8XrZg1yCS8gQhLISyH+XL jnlA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=ikQY0uEB4KHLims12Vi2DBcYJVjhgTL1N5hVfqrr1QQ=; fh=5dd+yZaSM5r1RhK83vA4++n3GlTBZASjd+EB6beB7HU=; b=mENZV88xmWJIG0GQ9RwLrQ6PNgxN9A9aji6ld2xjZ+EBm9idomDFEj9BPU8lhQLXaT BMylO7IUfLS03l3j7g8bjRmlhUsLhFPk4o9anyDYby2nl0Rh8Lbh9vlkoHSj3Ly8kExx cH6fAkLIh+VDF2NHKsUw0NhqFz8Cb+/OB5RG3MrLh/DVC2wp+hyV8MTw1Ts1t43qV33A xiyE4JjVQFUUyQYHBSOBLc0t7TfKTTOhN/faMGbc2Zc0qN4/mSQFd8nPRT5c9UfXRVYr NiVWzejTgPAxjTBINSCUyzzRyHlVMHvKeJEJwRVltNIniSr9PGjHTaFcypE5Jb9EXSWG N/Fg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="OWJCPw/H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from pete.vger.email (pete.vger.email. [2620:137:e000::3:6]) by mx.google.com with ESMTPS id u7-20020a17090341c700b001c9f6df8a7csi9295687ple.531.2023.10.24.12.17.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 12:17:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) client-ip=2620:137:e000::3:6; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b="OWJCPw/H"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:6 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by pete.vger.email (Postfix) with ESMTP id B84E2802C907; Tue, 24 Oct 2023 12:17:38 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at pete.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344247AbjJXTR1 (ORCPT + 27 others); Tue, 24 Oct 2023 15:17:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45966 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344021AbjJXTRZ (ORCPT ); Tue, 24 Oct 2023 15:17:25 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC49710C3; Tue, 24 Oct 2023 12:17:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698175043; x=1729711043; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=WGKgHwucaZd6y0NQGPmgV3sCFZELqEJC0AJNAp25S3g=; b=OWJCPw/HfGmnd98i63Lyj+3lQTn8uoeir1Za6t93XhOsWteUxIs4ked+ eQg6NsJHJgB+NOWfkpKQEsYpF644twv3HCoV9pfRMi5NcdqRQh/dL7MTT xInxCkVCaYs4AooSTnCCs18WtLqZLWV8ec5jHl4RVyOgOn1NAIF/hzhAb cSTTOMj5b61D1CnKVLN+lH5EfRRgreRMBO5Ho4wBH/7D1BdosiqSBXqQd Yz7dT1KnnK0QeUn8IPhTShGwbBXqjiW02ubtF+pKUDXRSk5v7rPRigbj2 82OPm67cnw873KMdEF+lVim4Yi0eo9sjzqjymWMKyi+LnBypVWf/8aB2Y g==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="418269767" X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="418269767" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 12:17:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="902303518" X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="902303518" Received: from stinkpipe.fi.intel.com (HELO stinkbox) ([10.237.72.74]) by fmsmga001.fm.intel.com with SMTP; 24 Oct 2023 12:14:59 -0700 Received: by stinkbox (sSMTP sendmail emulation); Tue, 24 Oct 2023 22:17:19 +0300 From: Ville Syrjala To: linux-pm@vger.kernel.org Cc: linux-kernel@vger.kernel.org, intel-gfx@lists.freedesktop.org, Zhang Rui , Wang Wendy , "Rafael J . Wysocki" , Srinivas Pandruvada Subject: [PATCH v2] powercap: intel_rapl: Downgrade BIOS locked limits pr_warn() to pr_debug() Date: Tue, 24 Oct 2023 22:17:19 +0300 Message-ID: <20231024191719.4041-1-ville.syrjala@linux.intel.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231004183455.27797-1-ville.syrjala@linux.intel.com> References: <20231004183455.27797-1-ville.syrjala@linux.intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on pete.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (pete.vger.email [0.0.0.0]); Tue, 24 Oct 2023 12:17:38 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780665612993872281 X-GMAIL-MSGID: 1780665612993872281 From: Ville Syrjälä Before the refactoring the pr_warn() only triggered when someone explicitly tried to write to a BIOS locked limit. After the refactoring the warning is also triggering during system resume. The user can't do anything about this so printing scary warnings doesn't make sense Keep the printk but make it pr_debug() instead of pr_warn() to make it clear it's not a serious issue. Cc: Zhang Rui Cc: Wang Wendy Cc: Rafael J. Wysocki Cc: Srinivas Pandruvada Fixes: 9050a9cd5e4c ("powercap: intel_rapl: Cleanup Power Limits support") Signed-off-by: Ville Syrjälä --- drivers/powercap/intel_rapl_common.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/powercap/intel_rapl_common.c b/drivers/powercap/intel_rapl_common.c index 40a2cc649c79..2feed036c1cd 100644 --- a/drivers/powercap/intel_rapl_common.c +++ b/drivers/powercap/intel_rapl_common.c @@ -892,7 +892,7 @@ static int rapl_write_pl_data(struct rapl_domain *rd, int pl, return -EINVAL; if (rd->rpl[pl].locked) { - pr_warn("%s:%s:%s locked by BIOS\n", rd->rp->name, rd->name, pl_names[pl]); + pr_debug("%s:%s:%s locked by BIOS\n", rd->rp->name, rd->name, pl_names[pl]); return -EACCES; }