Message ID | 20231024155739.3861342-4-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2040103vqx; Tue, 24 Oct 2023 08:58:01 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE7vyBMdmo8enOGBA80FOoxZ95m1aD3+trpJjdcdLk2oCrnTPVBxeqcUr0rcw7vG1G4nLsi X-Received: by 2002:a17:90a:a091:b0:274:9409:bbca with SMTP id r17-20020a17090aa09100b002749409bbcamr9157682pjp.3.1698163080827; Tue, 24 Oct 2023 08:58:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698163080; cv=none; d=google.com; s=arc-20160816; b=NekBk3uKmE2k+aLAKdqxq7V3TZXApo1wHi7PFI6DTr+TsHZyjfbwDoGHrPHSpIzrXp 3oJr2q+4d2GEcH7HbTAFNBHWXJn1o/b0kH9UK9cqaL6XKMF7xc3saSnZ+9Z6la53Is5I SW52o37NfJ0g/ZPOxgc1Bj/8eJqnlXmLbRPj7dKHLsQJTQ/b4mohwHsFOR1PqW5j2jJ0 EuOm3iwiAfRLH1y/gwaJVq0upnulv8Dfm5xOHv28BBRQpA9IQZjNB/8Cqbra9kdw5jtL MppV/NmbnWLm32A7zCXhAsJ0MrlWbSZNZwQeKulrA3D3ueLH8u6gbdkZ0t2Vna9TNX8h EUnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=hPE2pnr7DK4gVhE7qCMFk/zgMfcel5BuZUSj0XD71MA=; fh=4fCGr/vcT8BP5WO1Zwkta5BK+bnwH5aUY2dV04P1PeQ=; b=WU1BWJave6u45epeRfogYERgnsJ4oHDEdZdlKmR3s505vqapwth7us/lIqqPJN4Ha/ eKTsIBTI7JKs3TWF/u77gQtVC5CuAVNUGGITtyyrFjIWOJwO+ZrOeeLbJydr6A1o8ZCd yKC2IYBLOHsDBpDEciIBySnRu8X4nJ2+alYXldToBSZfQlpiyOagEyrNPHZSg1FhJM8K dFhJWqb9QOWYvVlBsHmwFFkkgPyMZd+RCCp7WqgG7AcUABZ7tNjrN8VlbYb+Illk5n+M LQ9Ygus513HnDfet02QxoyV/POMSkCa5VL3RFW4vH59+UghpR2s2aK5ywqN/5DSSVAzB 80yA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Vax2yMUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id om3-20020a17090b3a8300b002792440fc3bsi11676705pjb.185.2023.10.24.08.58.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 08:58:00 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Vax2yMUP; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 3B55C802B12C; Tue, 24 Oct 2023 08:57:57 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343958AbjJXP5u (ORCPT <rfc822;aposhian.dev@gmail.com> + 27 others); Tue, 24 Oct 2023 11:57:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44382 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234788AbjJXP5s (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 24 Oct 2023 11:57:48 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4450CDE for <linux-kernel@vger.kernel.org>; Tue, 24 Oct 2023 08:57:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698163067; x=1729699067; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=yFwM2WjkU3iKZYfcHCR7ptmZ6IIfrOEWKYyPqqzrsNU=; b=Vax2yMUP30TFX288W+7OGLcVMNJagyQbW7stnJ0iGoNE0Rzn9gBI1xh7 rG6IaRIaXZmjsj8uwF8ndc8m3sXV9gRA0gnn3TEiTmDNJV+QA2Uup7IUD iPFaaxlIkdXDhXvFGXkuS7BkU4gMAWdwKNbBxyWynH8qJRj+I4zpTu/gE 1LfUx0qWVJJMlv8F/pz2YHemtfUFVmogQc0pgLXf0yWGOCcTg/07f8i4o 7vOpbE3EfbafL0XCoIFozm2qZzvlYwZ/XNPRxb5VjOPK9OfIG1G0Juj1r U8kegV0a/WBdxKKoAveYFvAYMFXYr3bHVhKjyNMXglPR+xdsQzwQjnktV g==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="8649775" X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="8649775" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 08:57:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="902233852" X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="902233852" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga001.fm.intel.com with ESMTP; 24 Oct 2023 08:55:22 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id 2A9C281C; Tue, 24 Oct 2023 18:57:42 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, Jani Nikula <jani.nikula@intel.com>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Hans de Goede <hdegoede@redhat.com> Subject: [PATCH v2 3/7] drm/i915/dsi: Replace check with a (missing) MIPI sequence name Date: Tue, 24 Oct 2023 18:57:35 +0300 Message-Id: <20231024155739.3861342-4-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20231024155739.3861342-1-andriy.shevchenko@linux.intel.com> References: <20231024155739.3861342-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Tue, 24 Oct 2023 08:57:57 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780653050599940030 X-GMAIL-MSGID: 1780653050599940030 |
Series |
drm/i915/dsi: 2nd attempt to get rid of IOSF GPIO
|
|
Commit Message
Andy Shevchenko
Oct. 24, 2023, 3:57 p.m. UTC
Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Tue, Oct 24, 2023 at 06:57:35PM +0300, Andy Shevchenko wrote: > Names of the MIPI sequence steps are sequential and defined, no > need to check for the gaps. However in seq_name the MIPI_SEQ_END > is missing. Add it there, and drop unneeded NULL check in > sequence_name(). > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com> Andi
diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c index 22b89e68e6de..1014051a6866 100644 --- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c +++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c @@ -658,6 +658,7 @@ static const fn_mipi_elem_exec exec_elem[] = { */ static const char * const seq_name[] = { + [MIPI_SEQ_END] = "MIPI_SEQ_END", [MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET", [MIPI_SEQ_INIT_OTP] = "MIPI_SEQ_INIT_OTP", [MIPI_SEQ_DISPLAY_ON] = "MIPI_SEQ_DISPLAY_ON", @@ -673,7 +674,7 @@ static const char * const seq_name[] = { static const char *sequence_name(enum mipi_seq seq_id) { - if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id]) + if (seq_id < ARRAY_SIZE(seq_name)) return seq_name[seq_id]; return "(unknown)";