From patchwork Tue Oct 24 15:06:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yi Liu X-Patchwork-Id: 157552 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp2010328vqx; Tue, 24 Oct 2023 08:11:08 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/NIwTWkb9jY5GWPJrhSWs8DIE1H6E4/GfP4sjm7BZA3UQf83q+EsMA6b7QWREBxUCSRDY X-Received: by 2002:a17:902:ead2:b0:1ca:7f91:aa5d with SMTP id p18-20020a170902ead200b001ca7f91aa5dmr11473198pld.16.1698160268179; Tue, 24 Oct 2023 08:11:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698160268; cv=none; d=google.com; s=arc-20160816; b=bIR9miNYQjh5NPnJyFr+PIYYiOuKgX5QCxWaV8p3e+U9vgAVmZGERu1ySHncRuKd7J VCmb4moEoZsZQq3PWRddMJcxvm6YYuH0fU9EUWU180Fs7jo1Ck0UoGo9uSGWCHYYwU2/ pbLbGQ7GUl3EnnStD8IA1XFjz5yS9+yMt0pwzB92OJr9BomMwiurmwmukWdx3QlSIUtu Sxpb2QrTpiGdSym8gF6NR7KzsHJ+GHWu7NlzSukyPz2lldJ+saitv0yimCzfAHwTMqBb CCC2CGj/Yvej/zTwflvk40k/JIDC3hl2oEvdf5EcnLzo0qZ6U1PiU+TciwDIcPJ34SdP buhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=xi+Vm6QuI6F0gDwun1t1cY9L25VOMXbWCG18PWQ/mbs=; fh=ncJBVmsnOSqrX1O37yfYEzicwaA2e7ARxnsU7aiysyE=; b=tFPawzdrsKEX4r2Pejsx0WffWoga3nr9IygFzAH+xYdD/H5a8Fw47AXJ46NyvlQNVK eEeN6HBXs+s7//4K/jLEwZnPLMJWRz04lCDjNNmWYyCzs3nCaVqx9gTY/aKDw+W1bCPs OvUer9gpAnzgMHKuUTMa/lnefrIRimnM7HbycPZ4zsyHK9hHJ/1YgJLn/dWr3DICRNLJ dzbXrXw3GQlOtHEbTcanGheNQXTAtgbH269qWqQz8WHHAMJYW6ok2E+O/76Cf4qGGJc4 /Z7C7uDrsrm20Lv3GaYcuxFdH6fS24vJSiHMOloRCDIKd0FceVPzheSnQ0UI9G8MApgz HuBQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SUzLvutk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id jb22-20020a170903259600b001bbe13e753esi8085506plb.310.2023.10.24.08.11.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 08:11:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=SUzLvutk; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 8789380CB175; Tue, 24 Oct 2023 08:10:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233841AbjJXPK3 (ORCPT + 27 others); Tue, 24 Oct 2023 11:10:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55780 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234687AbjJXPKM (ORCPT ); Tue, 24 Oct 2023 11:10:12 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31B8810F5; Tue, 24 Oct 2023 08:10:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698160206; x=1729696206; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=QKBOqCJPnh6h05S/Q8c3RcBvwQLEe/d639sV2r2Ld/Y=; b=SUzLvutkyKzw7ev1DJc/2DOc1V4dB5FN4ezRKIykaxxOldLpGjh33AWG aElBHU3WiEQbcn7EN1ZlnsuDL79sxKPS+cclTyy6ucrHSvvGjYyxMB0qE OncKSET0MJB/otekNjNcNKashn/amPuVfKuTDbdpmdJvNz1d/p2/3/qI9 c2kUW2Y5NXKsBuU+k1ox1O0KxovCLlTFcrX0u9M13J8CIrYvMVv4G0xWc Vi32WRRlHEO+ziBjqBhby8a0k2aNTCRZ+qzLkfvnJf6EEo8ItPOFwtwre /yb0/PeD3XUxwEeAWQJ/6p3KDrb9o+sEkjQi4h+qzekmccn3yi+L2huDk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10873"; a="418203093" X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="418203093" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2023 08:06:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.03,248,1694761200"; d="scan'208";a="6486191" Received: from 984fee00a4c6.jf.intel.com ([10.165.58.231]) by fmviesa001.fm.intel.com with ESMTP; 24 Oct 2023 08:06:23 -0700 From: Yi Liu To: joro@8bytes.org, alex.williamson@redhat.com, jgg@nvidia.com, kevin.tian@intel.com, robin.murphy@arm.com, baolu.lu@linux.intel.com Cc: cohuck@redhat.com, eric.auger@redhat.com, nicolinc@nvidia.com, kvm@vger.kernel.org, mjrosato@linux.ibm.com, chao.p.peng@linux.intel.com, yi.l.liu@intel.com, yi.y.sun@linux.intel.com, peterx@redhat.com, jasowang@redhat.com, shameerali.kolothum.thodi@huawei.com, lulu@redhat.com, suravee.suthikulpanit@amd.com, iommu@lists.linux.dev, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, zhenzhong.duan@intel.com, joao.m.martins@oracle.com Subject: [PATCH v6 08/10] iommu: Add iommu_copy_struct_from_user helper Date: Tue, 24 Oct 2023 08:06:07 -0700 Message-Id: <20231024150609.46884-9-yi.l.liu@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231024150609.46884-1-yi.l.liu@intel.com> References: <20231024150609.46884-1-yi.l.liu@intel.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 24 Oct 2023 08:10:53 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780650101241445323 X-GMAIL-MSGID: 1780650101241445323 From: Nicolin Chen Wrap up the data type/pointer/len sanity and a copy_struct_from_user call for iommu drivers to copy driver specific data via struct iommu_user_data. And expect it to be used in the domain_alloc_user op for example. Signed-off-by: Nicolin Chen Co-developed-by: Yi Liu Signed-off-by: Yi Liu --- include/linux/iommu.h | 41 +++++++++++++++++++++++++++++++++++++++++ 1 file changed, 41 insertions(+) diff --git a/include/linux/iommu.h b/include/linux/iommu.h index a86ce9cb3547..9417b9e0616b 100644 --- a/include/linux/iommu.h +++ b/include/linux/iommu.h @@ -280,6 +280,47 @@ struct iommu_user_data { size_t len; }; +/** + * __iommu_copy_struct_from_user - Copy iommu driver specific user space data + * @dst_data: Pointer to an iommu driver specific user data that is defined in + * include/uapi/linux/iommufd.h + * @src_data: Pointer to a struct iommu_user_data for user space data info + * @data_type: The data type of the @dst_data. Must match with @src_data.type + * @data_len: Length of current user data structure, i.e. sizeof(struct _dst) + * @min_len: Initial length of user data structure for backward compatibility. + * This should be offsetofend using the last member in the user data + * struct that was initially added to include/uapi/linux/iommufd.h + */ +static inline int +__iommu_copy_struct_from_user(void *dst_data, + const struct iommu_user_data *src_data, + unsigned int data_type, size_t data_len, + size_t min_len) +{ + if (src_data->type != data_type) + return -EINVAL; + if (WARN_ON(!dst_data || !src_data)) + return -EINVAL; + if (src_data->len < min_len || data_len < src_data->len) + return -EINVAL; + return copy_struct_from_user(dst_data, data_len, + src_data->uptr, src_data->len); +} + +/** + * iommu_copy_struct_from_user - Copy iommu driver specific user space data + * @kdst: Pointer to an iommu driver specific user data that is defined in + * include/uapi/linux/iommufd.h + * @user_data: Pointer to a struct iommu_user_data for user space data info + * @data_type: The data type of the @kdst. Must match with @user_data->type + * @min_last: The last memember of the data structure @kdst points in the + * initial version. + * Return 0 for success, otherwise -error. + */ +#define iommu_copy_struct_from_user(kdst, user_data, data_type, min_last) \ + __iommu_copy_struct_from_user(kdst, user_data, data_type, sizeof(*kdst), \ + offsetofend(typeof(*kdst), min_last)) + /** * struct iommu_ops - iommu ops and capabilities * @capable: check capability