From patchwork Tue Oct 24 12:51:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Vecera X-Patchwork-Id: 157410 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1916447vqx; Tue, 24 Oct 2023 05:52:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFbeoFk3dZJ6sspYNglgAG4CJuaLdrKgtvnK66/g6E/gurF9CQ+SuqWLcNzBDu11xwD8Zz8 X-Received: by 2002:a17:90a:c70c:b0:267:f9c4:c0a8 with SMTP id o12-20020a17090ac70c00b00267f9c4c0a8mr9091183pjt.4.1698151946786; Tue, 24 Oct 2023 05:52:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698151946; cv=none; d=google.com; s=arc-20160816; b=SpO/22bb1/EdyuIcc94Yw3aleuQV8Y46noJxFeLfD2CpOOewtrKkO+H4BuEwyW9vrb x7ouT2sZaw7RZr/0ZCI30F5wZCfYtqchVE7x1WZWxrLckBfhBYbMyVQAAvztqVqwoK1I kSZyEKFfROCQNDA3AMPJguHuDbdH9TYTMIJaW/cOo8eNP0EvHkavD2Ep/1FK8Ql7Yuaf 31idUocN8CdJeNAk4ZuxITnVTIs0Y2jWYXwezwKUuAi1Lg1MlrzY77aOuYTgstTboPMS 2gi5P8ngaOM2nGiAFQLomM/Db04GDPZ6gn+Evs0aJE5uejQuNngr0YAicQ73lIrb/m/M O59Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Q8xEvrw5kPl+Kn6m0vz2m9HYGcHh0NovL+ylnmM6Mjc=; fh=M+PX9+iJWgAcFwsqeQjxdhjfP9EjwnPuV3/CSKHEUU4=; b=Q5P3fDpWCFPr23FnxszaUkMwJT60RzxC9tf1sxPScqJpffBT9Yxhs78E0h/tIg+Pkr mXNucV6o1sDNYMJz5+vfwWzgKDmkHLmd221xQVjQrgJYIyV76sC80trIKVnMr6VnMYiG mTz3kVz8FvYms3jv3NttCBeWVxh9p9uphILXxKPY4u+uefNyT2WM+OwzbLo3b9Vx8toX sc9BYnnwrqL5qH4zRAMzvKx2K1Lsc0amqwPovbR2WKV17ZJAVkaNxxwrlz2eK5dColuj AIQRXWlg2BOU+Kd+FxOrB52HPpiieP+fi7oFNc1XJNRDw5YHsOG67OEgQx2Wb5az1QUQ LrxQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PFReqZwz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from agentk.vger.email (agentk.vger.email. [23.128.96.32]) by mx.google.com with ESMTPS id h23-20020a17090adb9700b002769b4b64e7si10873917pjv.20.2023.10.24.05.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 05:52:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) client-ip=23.128.96.32; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=PFReqZwz; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.32 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id A36878041EA5; Tue, 24 Oct 2023 05:52:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234400AbjJXMwE (ORCPT + 26 others); Tue, 24 Oct 2023 08:52:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54048 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234364AbjJXMwC (ORCPT ); Tue, 24 Oct 2023 08:52:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 839F890 for ; Tue, 24 Oct 2023 05:51:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698151880; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Q8xEvrw5kPl+Kn6m0vz2m9HYGcHh0NovL+ylnmM6Mjc=; b=PFReqZwzdA7mD+0K/rC3Av/1E+rX/mYLNERU3o2XHQaFMrVWN5cua2ZCv6IP84NI5xcReV tSQ1VziLdAW2MXBWMY+QSK7PXSyBvL3pygg32cnvaLmogcMduw2zCTQSoClJlMIdXrj9H/ Aj0XYD4qhYxMSbBCGZCsdEQ3wbgeSvg= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-635-tXnH1RsiM6Clwt0Q6F78EA-1; Tue, 24 Oct 2023 08:51:12 -0400 X-MC-Unique: tXnH1RsiM6Clwt0Q6F78EA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E336088CC4D; Tue, 24 Oct 2023 12:51:11 +0000 (UTC) Received: from p1.luc.com (unknown [10.43.2.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6DC568C0A; Tue, 24 Oct 2023 12:51:10 +0000 (UTC) From: Ivan Vecera To: netdev@vger.kernel.org Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, Jacob Keller Subject: [PATCH net-next 1/2] i40e: Do not call devlink_port_type_clear() Date: Tue, 24 Oct 2023 14:51:08 +0200 Message-ID: <20231024125109.844045-1-ivecera@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.5 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 24 Oct 2023 05:52:24 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780640866298040885 X-GMAIL-MSGID: 1780641375794696693 Do not call devlink_port_type_clear() prior devlink port unregister and let devlink core to take care about it. Reproducer: [root@host ~]# rmmod i40e [ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared without a software interface reference, device type not supported by the kernel? [ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared without a software interface reference, device type not supported by the kernel? Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") Signed-off-by: Ivan Vecera Reviewed-by: Jiri Pirko Tested-by: Pucha Himasekhar Reddy (A Contingent worker at Intel) --- drivers/net/ethernet/intel/i40e/i40e_devlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_devlink.c b/drivers/net/ethernet/intel/i40e/i40e_devlink.c index 74bc111b4849..cc4e9e2addb7 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_devlink.c +++ b/drivers/net/ethernet/intel/i40e/i40e_devlink.c @@ -231,6 +231,5 @@ int i40e_devlink_create_port(struct i40e_pf *pf) **/ void i40e_devlink_destroy_port(struct i40e_pf *pf) { - devlink_port_type_clear(&pf->devlink_port); devlink_port_unregister(&pf->devlink_port); }