From patchwork Tue Oct 24 12:42:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Vecera X-Patchwork-Id: 157406 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1912379vqx; Tue, 24 Oct 2023 05:44:21 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEHMf3mR+mDrx3s+lLYRM2e/mVKuK0d/NzyU4j5eAXX38H8z6z5flkiX74JQ/fvVuMP0Au/ X-Received: by 2002:a05:6a21:66c5:b0:15e:9c50:73ee with SMTP id ze5-20020a056a2166c500b0015e9c5073eemr2604045pzb.53.1698151460954; Tue, 24 Oct 2023 05:44:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698151460; cv=none; d=google.com; s=arc-20160816; b=fbguuceTu9K3ht5CrWyHqW89bxvCBXY6w7fJqkDIjlnfRFA3bZd6dnY1s20h77ek3d fNGCAWfGk1tfUYAFJoqgHsA7+n5uoQaX2G5WdZVwQiex+71YXsSZNs3nE6r30R3mLfiX 6QzQnQmXJMxhK+sJwrUJxo+SKZ+/fK7bdiGmCNqXf1yDoJ6/IPAfg0wh1UD8+/jpKSyj uQcHL6hwOOMYYm0ef8dCPApLj59HEUDYMSilrnMgQbRqcshbS/cObSfP+KN2Un6H2wsh O5jLObvqt62JifUv1Bf3JMkoh+h9BgQn5TLk2gUCXineZnKdMv46YvaGZI5yQNCl52KI +jHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Q8xEvrw5kPl+Kn6m0vz2m9HYGcHh0NovL+ylnmM6Mjc=; fh=M+PX9+iJWgAcFwsqeQjxdhjfP9EjwnPuV3/CSKHEUU4=; b=g/4cQulMBLXg9KsDRRaDcI0XW+PGibQgABwG1cHQkSrafekqrJnOdWCpRgzMf3Z3g3 5PkP+osIRUGCOjDp2siXH3BGuNd/BSkkAnVvprgU84ph4QX7/JZw79CqH1eRk24EtcOn ftHP3WyEBN1AhjlyOjRjckCjO7h0lFR7F2fN4jeH8XUQ057DHUWdaynu+7egfVHTDVGu objsoMlfMZTztpmasASoVvwdbwbCyWV5KFBzNVNC94QFYXjWKhydfrIfQHl7iOo9nrEm ceOg6BB5vN36udQaiWNQVxCu3+sjvulOls998601DoNgu94Dcg3/sKCdocw3KmFwbx3E pl+Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iyT+irvR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from fry.vger.email (fry.vger.email. [2620:137:e000::3:8]) by mx.google.com with ESMTPS id o7-20020aa79787000000b006b43657e872si8353454pfp.184.2023.10.24.05.44.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Oct 2023 05:44:20 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) client-ip=2620:137:e000::3:8; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=iyT+irvR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:8 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id F15EC8031AF9; Tue, 24 Oct 2023 05:44:18 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234378AbjJXMnx (ORCPT + 26 others); Tue, 24 Oct 2023 08:43:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60926 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234342AbjJXMnv (ORCPT ); Tue, 24 Oct 2023 08:43:51 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 61AB3CC for ; Tue, 24 Oct 2023 05:43:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1698151385; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Q8xEvrw5kPl+Kn6m0vz2m9HYGcHh0NovL+ylnmM6Mjc=; b=iyT+irvRW7JI7wjQ80nWXtvUElO359/gvjsjA8wUOBIP5LzvL7hu1mPF9xSVYeMIzYMaCZ Bag90OTg3wpzzTvoAfK61CAut7g1KK7O2SGuaP+oRnEpPngKd8s5Cskh0/asJVlnFc1D4y TLGCYZB8Y7hFbZXQQ8+5S4mo4gtPEXU= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-664-8snoKRPkNl-P2UWdzztT7A-1; Tue, 24 Oct 2023 08:42:50 -0400 X-MC-Unique: 8snoKRPkNl-P2UWdzztT7A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AA90B85C1A5; Tue, 24 Oct 2023 12:42:49 +0000 (UTC) Received: from p1.luc.com (unknown [10.43.2.183]) by smtp.corp.redhat.com (Postfix) with ESMTP id 239342166B26; Tue, 24 Oct 2023 12:42:48 +0000 (UTC) From: Ivan Vecera To: netdev@vger.kernel.org Cc: Jesse Brandeburg , Tony Nguyen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , intel-wired-lan@lists.osuosl.org, linux-kernel@vger.kernel.org, Jacob Keller Subject: [PATCH 1/2] i40e: Do not call devlink_port_type_clear() Date: Tue, 24 Oct 2023 14:42:44 +0200 Message-ID: <20231024124245.837908-1-ivecera@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 24 Oct 2023 05:44:19 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780640866298040885 X-GMAIL-MSGID: 1780640866298040885 Do not call devlink_port_type_clear() prior devlink port unregister and let devlink core to take care about it. Reproducer: [root@host ~]# rmmod i40e [ 4539.964699] i40e 0000:02:00.0: devlink port type for port 0 cleared without a software interface reference, device type not supported by the kernel? [ 4540.319811] i40e 0000:02:00.1: devlink port type for port 1 cleared without a software interface reference, device type not supported by the kernel? Fixes: 9e479d64dc58 ("i40e: Add initial devlink support") Signed-off-by: Ivan Vecera --- drivers/net/ethernet/intel/i40e/i40e_devlink.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/intel/i40e/i40e_devlink.c b/drivers/net/ethernet/intel/i40e/i40e_devlink.c index 74bc111b4849..cc4e9e2addb7 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_devlink.c +++ b/drivers/net/ethernet/intel/i40e/i40e_devlink.c @@ -231,6 +231,5 @@ int i40e_devlink_create_port(struct i40e_pf *pf) **/ void i40e_devlink_destroy_port(struct i40e_pf *pf) { - devlink_port_type_clear(&pf->devlink_port); devlink_port_unregister(&pf->devlink_port); }