[1/6] dt-bindings: arm64: dts: mediatek: Add mt8183-kukui-katsu

Message ID 20231024000724.57714-2-hsinyi@chromium.org
State New
Headers
Series Add a few mt8183 follower boards. |

Commit Message

Hsin-Yi Wang Oct. 24, 2023, 12:02 a.m. UTC
  Add katsu and katsu sku38 which uses different audio codec.

Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
---
 Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++
 1 file changed, 6 insertions(+)
  

Comments

Conor Dooley Oct. 24, 2023, 3:15 p.m. UTC | #1
On Mon, Oct 23, 2023 at 05:02:24PM -0700, Hsin-Yi Wang wrote:
> Add katsu and katsu sku38 which uses different audio codec.
> 
> Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> ---
>  Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> index a5999b3afc35..fe8c488a3207 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> @@ -235,6 +235,12 @@ properties:
>          items:
>            - const: google,kappa
>            - const: mediatek,mt8183
> +      - description: Google Katsu (ASUS Chromebook Detachable CZ1)
> +        items:
> +          - enum:
> +              - google,katsu
> +              - google,katsu-sku38

This seems a little odd - does the non sku38 not have an sku of its own?

> +          - const: mediatek,mt8183
>        - description: Google Kodama (Lenovo 10e Chromebook Tablet)
>          items:
>            - enum:
> -- 
> 2.42.0.758.gaed0368e0e-goog
>
  
Hsin-Yi Wang Oct. 24, 2023, 7:46 p.m. UTC | #2
On Tue, Oct 24, 2023 at 8:15 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Mon, Oct 23, 2023 at 05:02:24PM -0700, Hsin-Yi Wang wrote:
> > Add katsu and katsu sku38 which uses different audio codec.
> >
> > Signed-off-by: Hsin-Yi Wang <hsinyi@chromium.org>
> > ---
> >  Documentation/devicetree/bindings/arm/mediatek.yaml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > index a5999b3afc35..fe8c488a3207 100644
> > --- a/Documentation/devicetree/bindings/arm/mediatek.yaml
> > +++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
> > @@ -235,6 +235,12 @@ properties:
> >          items:
> >            - const: google,kappa
> >            - const: mediatek,mt8183
> > +      - description: Google Katsu (ASUS Chromebook Detachable CZ1)
> > +        items:
> > +          - enum:
> > +              - google,katsu
> > +              - google,katsu-sku38
>
> This seems a little odd - does the non sku38 not have an sku of its own?
>

It's actually sku32. I'll update that in the next version. Thanks.

> > +          - const: mediatek,mt8183
> >        - description: Google Kodama (Lenovo 10e Chromebook Tablet)
> >          items:
> >            - enum:
> > --
> > 2.42.0.758.gaed0368e0e-goog
> >
  

Patch

diff --git a/Documentation/devicetree/bindings/arm/mediatek.yaml b/Documentation/devicetree/bindings/arm/mediatek.yaml
index a5999b3afc35..fe8c488a3207 100644
--- a/Documentation/devicetree/bindings/arm/mediatek.yaml
+++ b/Documentation/devicetree/bindings/arm/mediatek.yaml
@@ -235,6 +235,12 @@  properties:
         items:
           - const: google,kappa
           - const: mediatek,mt8183
+      - description: Google Katsu (ASUS Chromebook Detachable CZ1)
+        items:
+          - enum:
+              - google,katsu
+              - google,katsu-sku38
+          - const: mediatek,mt8183
       - description: Google Kodama (Lenovo 10e Chromebook Tablet)
         items:
           - enum: