From patchwork Mon Oct 23 18:58:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Detlev Casanova X-Patchwork-Id: 157036 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1492949vqx; Mon, 23 Oct 2023 12:01:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGkPBfXMDR8qTShNyU3rgwiMlPOwGYaf/cHSABqzSeet+2NEZWZEUgl2c9k8WVzgfqRnC/U X-Received: by 2002:a17:90b:398:b0:27d:1df4:26f3 with SMTP id ga24-20020a17090b039800b0027d1df426f3mr8064521pjb.15.1698087696962; Mon, 23 Oct 2023 12:01:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698087696; cv=none; d=google.com; s=arc-20160816; b=Q6/y4cn5r+cm8E4Mzk2KQt1L7f0vCGfP4sFl2pY/tg7fugLXXDMIARdFms+w4tKrFB eJ4r/VP0TeGc7+w1aiPV3ReIVyyXpVuItkq3oOTgmw93lBKZr52Kws7+qSsvRQV55dqW A+UFlRUZ1nkmYwclL7FfNynxO3HiexJOS0NeBTlvzmAWTbYPtka00AK8/doU0s6DzKDY G1osq8TgKxKEOUUIuaIMuUllsYOqzBlLJ/iUpqsFr1ZNhMl8MSniJ+twGLDaTJTaPnZH Nqk9neGLMJlPu0s+6Fv3AKaEAXljYvEYrfjCCAfYMz6ypoBmkkgjvvqm6z6VVtqUUZbI i85Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=oltyvAu9KFPRkU5Ffml8zU2V6aF+pX2zZ/h2FUb/PCQ=; fh=GOsa8F24+MtjXStpkMMOXboEdQI7NAG5aXV0YSmfysM=; b=HoxAKjVv2ch3p1lnP0tJ68K0naRgR16J4StrWjoMFUp06w8Rs8jZOtd5v91sLB+djT UPYC+6gABKGGotrGgVY0Cr/NA3GJWfKlA86pK3HaZSkHyD1EkG35Ju5Cpnsj4JVaAhYf M9GeQIJLkCTaFUw9Yr2AUHNdhewf4hpc7YDKe3pgiYoCZiBZtrQmXvrAJaq+IqX08Gga i1yuAlft/HJqygvIqcwKQ9JjH8B2nk6CcE78oeDLsaW9FBU2mysK+VdsTk02f+DacyXe CQqhWcV3ECh/SLKZDhxkO32ekSpvQOKmipQhtsFCzoU3Ts9qKX9LsSkTbm2zlLMU+oo5 X6yg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=cWgRGnDw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id 26-20020a17090a005a00b0027d29e618f7si6959230pjb.78.2023.10.23.12.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 12:01:36 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@collabora.com header.s=mail header.b=cWgRGnDw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id 545528061379; Mon, 23 Oct 2023 12:00:23 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231256AbjJWTAD (ORCPT + 27 others); Mon, 23 Oct 2023 15:00:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56014 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231222AbjJWS7z (ORCPT ); Mon, 23 Oct 2023 14:59:55 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1E59B110; Mon, 23 Oct 2023 11:59:54 -0700 (PDT) Received: from arisu.mtl.collabora.ca (mtl.collabora.ca [66.171.169.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: detlev) by madras.collabora.co.uk (Postfix) with ESMTPSA id F289366071EF; Mon, 23 Oct 2023 19:59:51 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1698087592; bh=1kYYBVVZKlPmwQg0v2fZqPSvNTFy7yF+ri1uhcr4paQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cWgRGnDwnr9wDW8Ok2OdHR5TTS6eRV580VatM6gq1t88ShZCxLOHfs5fWSUaAYJCh 8cdW6wfW8JuXxtNKQFJlmx0X0zPrRZhv2yAukJDZLdyEx2eJBwRj3rZjX2DeLwwPuv fipVzVCvER+XX3g0W1V7WdT5NegPO1Tv2m6D6+Qhe2rAQt7ZIipOc2xe877WkqK9oW ZGQyoVopLsR2zfpEw9XI8BuEjtVwLC7TMiUGTRKb0D0z/pIThSo5a1ydKhZs0XwQ90 qCFFNf19BKPuK33r+VvE41tq703k77vo9gIzNPQhU3MW+EvxfLhX0K+NiY6aVDne25 lKgm0TfBI3VaA== From: Detlev Casanova To: linux-kernel@vger.kernel.org Cc: linux-media@vger.kernel.org, Daniel Almeida , Mauro Carvalho Chehab , Detlev Casanova Subject: [PATCH 1/5] media: visl: Fix params permissions/defaults mismatch Date: Mon, 23 Oct 2023 14:58:21 -0400 Message-ID: <20231023185850.67082-2-detlev.casanova@collabora.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231023185850.67082-1-detlev.casanova@collabora.com> References: <20231023185850.67082-1-detlev.casanova@collabora.com> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Mon, 23 Oct 2023 12:00:23 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780574004958926642 X-GMAIL-MSGID: 1780574004958926642 `false` was used as the keep_bitstream_buffers parameter permissions. This looks more like a default value for the parameter, so change it to 0 to avoid confusion. Signed-off-by: Detlev Casanova --- drivers/media/test-drivers/visl/visl-core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/test-drivers/visl/visl-core.c b/drivers/media/test-drivers/visl/visl-core.c index 9970dc739ca5..df6515530fbf 100644 --- a/drivers/media/test-drivers/visl/visl-core.c +++ b/drivers/media/test-drivers/visl/visl-core.c @@ -74,7 +74,7 @@ MODULE_PARM_DESC(visl_dprintk_nframes, " the number of frames to trace with dprintk"); bool keep_bitstream_buffers; -module_param(keep_bitstream_buffers, bool, false); +module_param(keep_bitstream_buffers, bool, 0); MODULE_PARM_DESC(keep_bitstream_buffers, " keep bitstream buffers in debugfs after streaming is stopped");