Message ID | 20231023160539.1537355-1-arnd@kernel.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1397226vqx; Mon, 23 Oct 2023 09:06:33 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHtSP9h8PqJ3hmj7e6wI34OT//YdX8upDq03e5UzgaeakroUnDO1qHwN4Ii5YhVYCIdAjkb X-Received: by 2002:a05:6a00:84f:b0:6bd:b3b9:649f with SMTP id q15-20020a056a00084f00b006bdb3b9649fmr11424559pfk.7.1698077192357; Mon, 23 Oct 2023 09:06:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698077192; cv=none; d=google.com; s=arc-20160816; b=AAeBGacTQF9bUclyqqp3p14jZjErPSinTSM0yI0QniSgMdHOF5yLO88wrww32rzDwz AeAxzm+RkZrlDJ+cuK+SCUrDBcJRZAvXAkWxVHG68gRe08F2g16scLQb2MYfI6CTmYVE 7i/rYP0lOL+L++lUl4oDkmifuAI8824mLlJ19uyHEimHtW+EPpwtOoTlUIut/oLbVTcQ njpY5uXuryq1nTm/0HEs2MXtECPnPHdIXnmYZ18JSE7/h53QOkhGK2ppvv+2tK6KZs00 djQZkGmrrF2cNpckLiHUlFX+fOOthnKsjpuqBXRGdJoG8T0clgHDL4rAZMN+jBMsWVqb eMdw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=s5SCwWfOIQ6220GajhkiboNtdSuvP3xvmLo5FVgY9x4=; fh=PU2XAJLNWGeVyB4Y7WsAvzTXOGVtgVL6qGs3oEaf7AE=; b=q/getfJUjWNPpDsICGsM3LQfs1Z5Is+/RMmRqDclX4gyeZw4C3kTRMxn+2QgCgN6Ey R1kzFcHEyk2NbB+GI3MkEq5P4oVGBhkE73hd1UZlljImJ2MsT4ZpI4d5BVAJbsGYQdlM 9id4XGCS8kolffl3XBwnzqhs+iNedz1V/rpDcSVol01vKJeHKaD5xZu3fXgu7/ozgHji gnqHAHEv5wsPICQHphsqE5uE9ixiya6yoLU+9svTcEH5LR7zCQEyvQetes38bOxE5LIz R8DAgwo6gV2IVjIUitcm1jsqEqUdqSFnssAlKNCPyvg6WWBRKrxKdDaYl6MwgI0W/nn4 aRNA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOvXabiO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id g6-20020a636b06000000b00578a98c0687si7038281pgc.99.2023.10.23.09.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 09:06:32 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=YOvXabiO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 7C86D8092DA8; Mon, 23 Oct 2023 09:06:06 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229512AbjJWQFt (ORCPT <rfc822;aposhian.dev@gmail.com> + 27 others); Mon, 23 Oct 2023 12:05:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230519AbjJWQFr (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 23 Oct 2023 12:05:47 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F78510A; Mon, 23 Oct 2023 09:05:45 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9D854C433C8; Mon, 23 Oct 2023 16:05:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698077145; bh=rC/hNZ7Bswy153IHNZJNcZBlr9hop+G6Sg6aUKxjdIg=; h=From:To:Cc:Subject:Date:From; b=YOvXabiOgl0nH2oPF9hfgJhkEJP+UUFp0h9KGCfx88oPj6u6WfzTBffoVLAWwFkUQ /r6lXvTN2pi/mjokglO3uUrDRNCuIxaAkmOL1L4egSVv0boGU9kmN/e0BVksgEngpK rj3xv41RK+MXX1QUkSdbNjV3b1Wq88e+qakIoWJFdGNEk5behSD1BBk6txm7dcEIqm xa45GHtj1Umi4uRUAfmXpyQV/udasf+RYsglGut5t9DB7D+FRfFCE9FpkjG6Mk+lTi RnF3PYmo5ccnkN7Ua77vb+Rx16ZTpNsFNgyCASyd3HjN4BAAhiVPVC2uJEV6QjfNpJ KbCskka5IO7Yg== From: Arnd Bergmann <arnd@kernel.org> To: Martin Tuma <martin.tuma@digiteqautomotive.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Hans Verkuil <hverkuil-cisco@xs4all.nl> Cc: Arnd Bergmann <arnd@arndb.de>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] media: pci: mgb4: add COMMON_CLK dependency Date: Mon, 23 Oct 2023 18:05:31 +0200 Message-Id: <20231023160539.1537355-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 09:06:06 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780562990370898783 X-GMAIL-MSGID: 1780562990370898783 |
Series |
[1/2] media: pci: mgb4: add COMMON_CLK dependency
|
|
Commit Message
Arnd Bergmann
Oct. 23, 2023, 4:05 p.m. UTC
From: Arnd Bergmann <arnd@arndb.de> This driver fails to build when HAVE_CLK and COMMON_CLK are disabled: x86_64-linux-ld: vmlinux.o: in function `mgb4_remove': mgb4_core.c:(.text+0x1915e8c): undefined reference to `clkdev_drop' x86_64-linux-ld: mgb4_core.c:(.text+0x1915e98): undefined reference to `clk_hw_unregister' Add a Kconfig dependency to enforce a clean build. Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/media/pci/mgb4/Kconfig | 1 + 1 file changed, 1 insertion(+)
Comments
On 23. 10. 23 18:05, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > This driver fails to build when HAVE_CLK and COMMON_CLK are disabled: > > x86_64-linux-ld: vmlinux.o: in function `mgb4_remove': > mgb4_core.c:(.text+0x1915e8c): undefined reference to `clkdev_drop' > x86_64-linux-ld: mgb4_core.c:(.text+0x1915e98): undefined reference to `clk_hw_unregister' > > Add a Kconfig dependency to enforce a clean build. > > Fixes: 0ab13674a9bd ("media: pci: mgb4: Added Digiteq Automotive MGB4 driver") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/media/pci/mgb4/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig > index 13fad15a434c..f2a05a1c8ffa 100644 > --- a/drivers/media/pci/mgb4/Kconfig > +++ b/drivers/media/pci/mgb4/Kconfig > @@ -2,6 +2,7 @@ > config VIDEO_MGB4 > tristate "Digiteq Automotive MGB4 support" > depends on VIDEO_DEV && PCI && I2C && DMADEVICES && SPI && MTD && IIO > + depends on COMMON_CLK > select VIDEOBUF2_DMA_SG > select IIO_BUFFER > select IIO_TRIGGERED_BUFFER Reviewed-by: Martin Tůma <martin.tuma@digiteqautomotive.com>
diff --git a/drivers/media/pci/mgb4/Kconfig b/drivers/media/pci/mgb4/Kconfig index 13fad15a434c..f2a05a1c8ffa 100644 --- a/drivers/media/pci/mgb4/Kconfig +++ b/drivers/media/pci/mgb4/Kconfig @@ -2,6 +2,7 @@ config VIDEO_MGB4 tristate "Digiteq Automotive MGB4 support" depends on VIDEO_DEV && PCI && I2C && DMADEVICES && SPI && MTD && IIO + depends on COMMON_CLK select VIDEOBUF2_DMA_SG select IIO_BUFFER select IIO_TRIGGERED_BUFFER