Message ID | 20231023151704.670240-1-colin.i.king@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1367302vqx; Mon, 23 Oct 2023 08:17:15 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWQvJwKcS0ylo0YtsWibtmKLpHGQzw26xJDznsEXPlQcn+SxJmZmkd4x6LhLG03wmPUcF4 X-Received: by 2002:a05:6a20:54a6:b0:14e:509:1d7b with SMTP id i38-20020a056a2054a600b0014e05091d7bmr7703224pzk.8.1698074235018; Mon, 23 Oct 2023 08:17:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698074235; cv=none; d=google.com; s=arc-20160816; b=qba+pgmKF9+CPk41yqxCOaoPCCUMRFxkN5pcDGXoyPQQnqkkMxshlBhkTJC121HU0O HWap7hdJoJAXD7cW1RAi+7mR99YErkrwYfAD58Ecx/a93PYz/sk6Ye0PcJKsQhevgQOk IPfHA95oA0UmRlh/rvuG/KP25cP8+K+T022SDPd02gkjQFFrmF6Hl4OzDkV8zTlWEAY1 dkr0V6MX2yZDIhPvs81quS7KtFhxediqwwqxXi+EudikXKmiWh2IZzJQya56dV7FgsN6 cf4YGJRFn3GcqbkdcmGCx0BemuS7NFXI22Jj3pVzwjfir3mUz1zqaA3rEX20WCd+9QsC EGXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=jAyRkZU+G6EHBgXjNlQRdapo8Bo6bVrz7BpJ95EsKKo=; fh=G18MNK+q8iHOzObp1njgWFXWWTtn3BCEGclI6+hJsEA=; b=eQkbBAYV/qkcA/5KRh8o6K0TmZgQvG2/9RSSSi2b/VRP86P0cb1MKPh9t6o2U1DuVT Yyg/RtF/HIpX8aE7XgbLghkp4QTlLHgjLcWpXYvCY57yhEVKQY7bHdo3qkMXa9SIj2qE 6oO+DYQrPZwgS/ME67cJEbm6Rj4LUSq+lQaB8DzDyuTLTP8nSKekQ3/uZRobtIqqoAOT JFvgX09/gr2Y6wBRzbcV2cml0IXkP+hlfKdvBxmkmvruek+QLIhILDz7uT+wHM6iilYd 3H2hfnyhfU88xA2xkLhR9Xil4cc3tmjpRB1DcgZNDoPZYaY5jKIVBGo6Lc6sByPYNO3h yOXw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Q6dWGkTc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id bx29-20020a056a02051d00b005a9e9e26549si3615877pgb.193.2023.10.23.08.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 08:17:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b=Q6dWGkTc; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 0499C80A265C; Mon, 23 Oct 2023 08:17:14 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230289AbjJWPRL (ORCPT <rfc822;aposhian.dev@gmail.com> + 27 others); Mon, 23 Oct 2023 11:17:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40252 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229686AbjJWPRK (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 23 Oct 2023 11:17:10 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65B21DD; Mon, 23 Oct 2023 08:17:07 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-32caaa1c493so2478832f8f.3; Mon, 23 Oct 2023 08:17:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1698074226; x=1698679026; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=jAyRkZU+G6EHBgXjNlQRdapo8Bo6bVrz7BpJ95EsKKo=; b=Q6dWGkTchYhEQO8eiI6BkdXC/b/J1vj+wusDdEoTU7V7vzZjByc8NWdV2sbqgdC+32 zqLEeQ8aTvTIhB+90Y9A04xw0KokWspnE0rGBlLwH8Ojw4qCK79HOoL9xqeVxDp7ErL9 nWiUbsxRaeMDkEAHWNcmQ5nUW30bhVhftAJIei66GCX1iJoFyrnDQb74VepsfRzhEt8i q/g+tdb5YAL8rYS0Ln3gTnE7rBJxCRUa3e0B6Ot7OVPMicv/Uvj1frjk0dxZYBD8zIvx cChf0icpsWJmXEFSVT0STLLTPIYzwRgCm368vKycSFGg1NavanNkzqu6cwZRCcg1MKz3 nkVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698074226; x=1698679026; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jAyRkZU+G6EHBgXjNlQRdapo8Bo6bVrz7BpJ95EsKKo=; b=xS+aCro8iZKZNN1gnyfTyQ7hR32myicRWn8tHQc5Dd8hQF0cHfqImxtM6tFQ7Ko45L tcoXW/+nfiAS18F5uXhO2RdaFPCCppijWdadTpqa2C8zDM96j6x5AZgBBWjxZkPY/TVQ fSbsDcPSvJjYIlOY3Lft98nNxOhJDhtDzpy0sIjNKtiaqpsEsKAKO7SYMxn3LUcTnEpo P0OBZCAJ/gfwR6bnwNgbhJAB0bM1bt8ThxA5EfwdJXl62TWO6evOWB8DEB7SWnjdocrv CRsxxXzBp2vxtvzCN+9CgfgsMLlJWoBXhhc3gPVWJnoPdl5Ny03N+krhocznRTYfWsea /ZDw== X-Gm-Message-State: AOJu0Yww4YD3qS1L5NIM/qoPO2GrT3a1Du1q4XJls7FxOftdPkImdVYl qQIyx75qsWkdmc2u5BRoy2o= X-Received: by 2002:adf:9dcb:0:b0:32d:a29a:b6ef with SMTP id q11-20020adf9dcb000000b0032da29ab6efmr6726291wre.23.1698074225584; Mon, 23 Oct 2023 08:17:05 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id b16-20020a5d5510000000b0032d2489a399sm7913701wrv.49.2023.10.23.08.17.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Oct 2023 08:17:05 -0700 (PDT) From: Colin Ian King <colin.i.king@gmail.com> To: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Matthias Brugger <matthias.bgg@gmail.com>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] ASoC: mediatek: mt8186: remove redundant assignments to variable tdm_con Date: Mon, 23 Oct 2023 16:17:04 +0100 Message-Id: <20231023151704.670240-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Mon, 23 Oct 2023 08:17:14 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780559889363078280 X-GMAIL-MSGID: 1780559889363078280 |
Series |
[next] ASoC: mediatek: mt8186: remove redundant assignments to variable tdm_con
|
|
Commit Message
Colin Ian King
Oct. 23, 2023, 3:17 p.m. UTC
There are two occurrences where variable tdm_con is being initialized
to zero and the next statement re-assigns tdm_con to a new value. The
initializations are redundant and can be removed.
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
---
sound/soc/mediatek/mt8186/mt8186-dai-tdm.c | 2 --
1 file changed, 2 deletions(-)
Comments
Il 23/10/23 17:17, Colin Ian King ha scritto: > There are two occurrences where variable tdm_con is being initialized > to zero and the next statement re-assigns tdm_con to a new value. The > initializations are redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.i.king@gmail.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
On Mon, 23 Oct 2023 16:17:04 +0100, Colin Ian King wrote: > There are two occurrences where variable tdm_con is being initialized > to zero and the next statement re-assigns tdm_con to a new value. The > initializations are redundant and can be removed. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: mediatek: mt8186: remove redundant assignments to variable tdm_con commit: 2e2a1613342658962250873cb8a0406bebdab9e3 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark
diff --git a/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c b/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c index 4148dceb3a4c..ef2801f84d27 100644 --- a/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c +++ b/sound/soc/mediatek/mt8186/mt8186-dai-tdm.c @@ -416,12 +416,10 @@ static int mtk_dai_tdm_hw_params(struct snd_pcm_substream *substream, regmap_update_bits(afe->regmap, ETDM_IN1_CON1, ETDM_IN_CON1_CTRL_MASK, tdm_con); /* ETDM_IN1_CON3 */ - tdm_con = 0; tdm_con = ETDM_IN_CON3_FS(tran_rate); regmap_update_bits(afe->regmap, ETDM_IN1_CON3, ETDM_IN_CON3_CTRL_MASK, tdm_con); /* ETDM_IN1_CON4 */ - tdm_con = 0; tdm_con = ETDM_IN_CON4_FS(tran_relatch_rate); if (slave_mode) { if (lrck_inv)