Message ID | 20231023053530.5525-5-raag.jadav@intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp1090419vqx; Sun, 22 Oct 2023 22:37:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEUPPFPaEQeO5xGCEhWL7cTB64DuI6440AC7m0Qjz6dGAIEsH4oUo54Iu9jQNKkmJqYYykW X-Received: by 2002:a05:6870:ebcb:b0:1ea:1b5e:fed4 with SMTP id cr11-20020a056870ebcb00b001ea1b5efed4mr11452609oab.39.1698039427114; Sun, 22 Oct 2023 22:37:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1698039427; cv=none; d=google.com; s=arc-20160816; b=mW31Wfm6HRO0vQW2awIWHSEdTk+Ao4kzgskeGZTppTA9vE95cKhPa8hB7XHVjILUod d+nNPsPy6PcFDilfD95bcRPpcPS19c4fn7PFaXXTOHDsW/bj2JItyObTloXOaYkFjBqQ 6ReOaoXgm/RIs7qsONoDrh/96SJedwiaxFEUuBg5qbPXqGc5UCt4RXFNcqdKuXsIJvym UBhWVeHT8YNACvElr2V9iySsdNr7C7ncorHmMQ92fuh7TnbB45JnS2d2JyiwEABixsr6 u+lyVKrUWw0Wdgjz+wGb1ptB5ThtXMUdg+JAP3xQ1M1U0lSsssvLPuC4oHDoOVFvFKUZ DYsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=sLdhtTPDhbdoxnL9UGOXFbOwGGz6MIHLSHHMKWfWUDc=; fh=jahFJYSZbW5wMNYi6sgvoYqPjA4Ed86fT1kpbcI5rrM=; b=Xd9jPu6Pe0KcfF4troCnzpVxZ52QaS0M38qhl2XXsKElIN8vB3ywtVnHrEPMLFouRy huleeG2UNhCLoFmtAflYYgd8GOiL4Xiu2ZGsQmb3/e3jZoy+t3T8rxy1QYftFh8AkLWu hr9nvYfys3IPp6TU56QdW4Uvo3L1FCGxVPEph3yJVRjSqv7o7FZjLnPVhanRZB1SzPO9 eM8oiXHQzfRscw3elnXubCOzBHAgBfjPBjKuG3LpyAe6oW1w/DLhUj0kr5uf7qgko7qO SCziLwXORk+FzZvoZXeG3Z63XLFBazwE1CdHGfI3l5toEVwp1zhr3IveHIFBUtVfj5P2 G5xA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JXpVVhVn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [23.128.96.33]) by mx.google.com with ESMTPS id j69-20020a638048000000b0058974d3c292si5681342pgd.191.2023.10.22.22.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Oct 2023 22:37:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) client-ip=23.128.96.33; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=JXpVVhVn; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.33 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id A4DB4805D541; Sun, 22 Oct 2023 22:37:04 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233282AbjJWFgh (ORCPT <rfc822;a1648639935@gmail.com> + 26 others); Mon, 23 Oct 2023 01:36:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229577AbjJWFg3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 23 Oct 2023 01:36:29 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D2A36D66; Sun, 22 Oct 2023 22:36:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1698039387; x=1729575387; h=from:to:cc:subject:date:message-id:in-reply-to: references; bh=4ahXNqa6c7vy2x9ujTqdFUKWTVtZ7enEGrd79rmm95E=; b=JXpVVhVn+sefPxYFftPtNWPtpCaeJrBxGwwdmXdS0vAwaG0KYxxcQiNs J3Vzg9k9QxnEL4KbnANhiiRwiS5XMoB8eFLUPWCszWlFua3IVBM672i+N u0tV58lwTgeF+u/5p7251+ZnisYi11w98es8IJ5ASWtNY17sEN8enAsmm PpkXKoIc9UKdfYhp0gox0XBncoA6ll7p+pxlPVeuCJcvzpLvstTk8Hhfj V6Fu+RJrnuy9yz/VnyCoBOjVdkuVqTJM/qGAwzTgaVhC65/p+w861DNhl OsESbfKVK+gprlnY52Xdn3y/LrqNlAOMzqp/AOGy4i2TAfwfCeJMUgDRX w==; X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="417905428" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="417905428" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2023 22:36:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10871"; a="734556690" X-IronPort-AV: E=Sophos;i="6.03,244,1694761200"; d="scan'208";a="734556690" Received: from inlubt0316.iind.intel.com ([10.191.20.213]) by orsmga006.jf.intel.com with ESMTP; 22 Oct 2023 22:36:14 -0700 From: Raag Jadav <raag.jadav@intel.com> To: rafael@kernel.org, len.brown@intel.com, robert.moore@intel.com, mika.westerberg@linux.intel.com, andriy.shevchenko@linux.intel.com, mark.rutland@arm.com, will@kernel.org, linux@roeck-us.net, Jonathan.Cameron@Huawei.com Cc: linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, acpica-devel@lists.linuxfoundation.org, linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hwmon@vger.kernel.org, mallikarjunappa.sangannavar@intel.com, bala.senthil@intel.com, Raag Jadav <raag.jadav@intel.com> Subject: [PATCH v2 4/6] ACPI: x86: use acpi_dev_uid_match() for matching _UID Date: Mon, 23 Oct 2023 11:05:28 +0530 Message-Id: <20231023053530.5525-5-raag.jadav@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20231023053530.5525-1-raag.jadav@intel.com> References: <20231023053530.5525-1-raag.jadav@intel.com> X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Sun, 22 Oct 2023 22:37:04 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780523390026444501 X-GMAIL-MSGID: 1780523390026444501 |
Series |
Refine _UID references across kernel
|
|
Commit Message
Raag Jadav
Oct. 23, 2023, 5:35 a.m. UTC
Convert manual _UID references to use the standard ACPI helper. Signed-off-by: Raag Jadav <raag.jadav@intel.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/acpi/x86/utils.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
Comments
On Mon, Oct 23, 2023 at 11:05:28AM +0530, Raag Jadav wrote: > Convert manual _UID references to use the standard ACPI helper. > Signed-off-by: Raag Jadav <raag.jadav@intel.com> > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Please, drop this tag, since I disagree with patch 1 implementation.
diff --git a/drivers/acpi/x86/utils.c b/drivers/acpi/x86/utils.c index 63d834dd3811..bc65ebfcdf76 100644 --- a/drivers/acpi/x86/utils.c +++ b/drivers/acpi/x86/utils.c @@ -184,8 +184,7 @@ bool acpi_device_override_status(struct acpi_device *adev, unsigned long long *s if (acpi_match_device_ids(adev, override_status_ids[i].hid)) continue; - if (!adev->pnp.unique_id || - strcmp(adev->pnp.unique_id, override_status_ids[i].uid)) + if (!acpi_dev_uid_match(adev, override_status_ids[i].uid)) continue; }