[RESEND] staging: media: atomisp: Removed duplicate comment and fixed comment format
Message ID | 20231021110058.85013-1-bergh.jonathan@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:ce89:0:b0:403:3b70:6f57 with SMTP id p9csp228991vqx; Sat, 21 Oct 2023 04:02:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH65TlnEHqXxCVNdB9dAz2HMbvnoaiOZlkrXiW3gl5jgzxczyPGHvB+qeBOzvJYXG5V9JmR X-Received: by 2002:a17:902:ca0b:b0:1c4:72c9:64ef with SMTP id w11-20020a170902ca0b00b001c472c964efmr3039616pld.40.1697886133335; Sat, 21 Oct 2023 04:02:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697886133; cv=none; d=google.com; s=arc-20160816; b=F5ez92Da42bk1aIUT0tV6DjPBmjcU8YF7EqYcOPyxkEguruorGboYY1v9ofLVH1lbW EQFhtHWCw/hPrS2VGMImg+waPMg+4pYYHYrkvEEZd+u1XXMW3ZBoj+mXYxfLG+Ss583S uRmnMFCJzidalZH8416wBWC4PgpqbgvtsjE4vfPP+U7IqE3VL6Cq20WUI4AGyk3BmsRw m5nauIdkUuZzMy/kyJx6VVtkbXVpeYqyKr3N4f5/Dn7mRWoofhj12kEajX4IyX6P/un/ Gj2eoELKrkXNWAMfh89pYqnizeBxTb0iJZbcE6zVTtJCU0UmZQ94T4jvCYzohE84P4Sz X3Cw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=W9Daja05OoueSFXSKgaA2RDObCdOKO/kxeq5hi1gOh8=; fh=dVuFjjn2xCEtcCE6rTwWJv+nCyRLFLAynnYrRyXSLno=; b=OuaoND/l2h1TcYT7MGjkycKhBo0v6z/RA880x9Db9YiyFFEj9vq0s0QY1fD8n8yE6s ktkC/mMF1i+rVgUexa+kVne7+PcEHL/O+vqyXKMemSMtALqH6DDKAwy0Xe2JIglLqmg/ muvq03g4qyy8FyWjswaQViFM1BTwWfKJCOTcv6m3/GnByxnOHXMr/iHngZBGKET0781l Dddyn5Zzm8uimxEDawepvhdKusRBCEXLvejw3iHCWWDO1oGIvV6gvQ9Q1SrmbLAfGA5f IHZgHXMp5t7LRA581l0cpyGhLx4xfYNRfFkgRfyyaP5b91ZGqzfenn7i/ThT8EHnaots 3uJQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="YIDSBn/Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id t9-20020a170902e84900b001b5589848absi3595406plg.234.2023.10.21.04.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 04:02:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="YIDSBn/Y"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 3438C8217EF3; Sat, 21 Oct 2023 04:02:12 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230308AbjJULCF (ORCPT <rfc822;a1648639935@gmail.com> + 26 others); Sat, 21 Oct 2023 07:02:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229583AbjJULCC (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 21 Oct 2023 07:02:02 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E38C499; Sat, 21 Oct 2023 04:01:58 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-5079c846dcfso2120043e87.2; Sat, 21 Oct 2023 04:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697886117; x=1698490917; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=W9Daja05OoueSFXSKgaA2RDObCdOKO/kxeq5hi1gOh8=; b=YIDSBn/YkwsFzD5tteiV4U2XRkvJPAzXvfCYyi4qlPEBsbinaQex6Vw4aDjbPnVXT4 89fJsQNlGzzKW7h66hzCD9W1SVy9Snmr5zgvNzHTkkSWOgjxcEhXWDFxZFEb23fw+dAx OCW3Mpy5BqvJnzXU1OiTYvPJ5blstAz83wqjWTvoV4I8BN3uH3xigraZ34dk5SRjaH/5 U4AeuNeh2ZOfo0X7eXY/VXmZaZGVVykA/xT3JmIOrG416IGQtfUfKSbVoTpkLx8wKEYJ cBHEhBmemplhlA/+Xihv4zaVQTuir1PqKtX8iKCgmw8X0xfT8D3wTbKF/M1rcScYYuLs cmeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697886117; x=1698490917; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=W9Daja05OoueSFXSKgaA2RDObCdOKO/kxeq5hi1gOh8=; b=q27K64B9XmlN7UmGeSKt/PYRJcU0zxMadcge5ouVNYn2Nfoi5/L1cPA8uS7ZnwBni8 qwp4KGZPaj5tc6uYK9lNisOXMbV7tV/X2LTGQ0cJs2DR/uCRQ+tw6K4aXQniyGBHbQ2k XuoRr3Iczxbaq7wY/dWOdyISi7JW2TTutWcEiAfHMVc9ioumlxwtKr34BTT+3ABypolQ cZD+hHBMuuMsRITjV/Gt6j3j+BVJKsgi0jMeVduUWvvzzftCtBIlWQz34nvKbaMVv/Vx aPJvtAqd04KiR/VvsnOBxF8CDMI41Jo2UfdgvAvhEgB1qFSHjCUM9/YhjRbMtDp7od4M bD1A== X-Gm-Message-State: AOJu0Yz4N1yy9SA62TknVW5MPpiqSv+f5HCSbpVjMzlTSTEz1niQF1YM JQS1va2TnJkbhPCBzBr5LrQ= X-Received: by 2002:a05:6512:1382:b0:507:a1dd:5a86 with SMTP id fc2-20020a056512138200b00507a1dd5a86mr3372712lfb.13.1697886116897; Sat, 21 Oct 2023 04:01:56 -0700 (PDT) Received: from HP-ENVY-Notebook.lan (81-229-94-10-no68.tbcn.telia.com. [81.229.94.10]) by smtp.googlemail.com with ESMTPSA id o13-20020ac24bcd000000b00507a622184dsm823093lfq.173.2023.10.21.04.01.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 21 Oct 2023 04:01:56 -0700 (PDT) From: Jonathan Bergh <bergh.jonathan@gmail.com> To: hdegoede@redhat.com, gregkh@linuxfoundation.org Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Jonathan Bergh <bergh.jonathan@gmail.com> Subject: [PATCH RESEND] staging: media: atomisp: Removed duplicate comment and fixed comment format Date: Sat, 21 Oct 2023 13:00:58 +0200 Message-Id: <20231021110058.85013-1-bergh.jonathan@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Sat, 21 Oct 2023 04:02:12 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780362650355907802 X-GMAIL-MSGID: 1780362650355907802 |
Series |
[RESEND] staging: media: atomisp: Removed duplicate comment and fixed comment format
|
|
Commit Message
Jonathan Bergh
Oct. 21, 2023, 11 a.m. UTC
Fixed the following issues:
* Removed a duplicate comment
* Fixed up minor comment format issue
Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
---
drivers/staging/media/atomisp/i2c/gc2235.h | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
Comments
Hi Jonathan, On 10/21/23 13:00, Jonathan Bergh wrote: > Fixed the following issues: > * Removed a duplicate comment > * Fixed up minor comment format issue > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Thank you for your patch, but please don't resend it every week. I did see the original patch and it looks fine but I have not had any time to work in atomisp support recently and this does not seem like something which needs to get merged urgently. I'll pick this up next time I have time to do a bunch of atomisp work. Regards, Hans > --- > drivers/staging/media/atomisp/i2c/gc2235.h | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h > index 55ea422291ba..ade28950db73 100644 > --- a/drivers/staging/media/atomisp/i2c/gc2235.h > +++ b/drivers/staging/media/atomisp/i2c/gc2235.h > @@ -74,9 +74,6 @@ > #define GC2235_COARSE_INTG_TIME_MIN 1 > #define GC2235_COARSE_INTG_TIME_MAX_MARGIN 6 > > -/* > - * GC2235 System control registers > - */ > /* > * GC2235 System control registers > */ > @@ -167,7 +164,7 @@ enum gc2235_tok_type { > GC2235_TOK_MASK = 0xfff0 > }; > > -/** > +/* > * struct gc2235_reg - MI sensor register format > * @type: type of the register > * @reg: 8-bit offset to register
On Sat, Oct 21, 2023 at 01:57:05PM +0200, Hans de Goede wrote: > Hi Jonathan, > > On 10/21/23 13:00, Jonathan Bergh wrote: > > Fixed the following issues: > > * Removed a duplicate comment > > * Fixed up minor comment format issue > > > > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com> Hi Hans, thanks for the msg. > > Thank you for your patch, but please don't resend > it every week. Apologies. I dont remember when i sent the original but I was cleaning up today and thought i would resend it. (I dont recall resending prior to today (?) but if so, apologies). > I did see the original patch and it looks fine but > I have not had any time to work in atomisp support > recently and this does not seem like something > which needs to get merged urgently. > > I'll pick this up next time I have time to do > a bunch of atomisp work. Yes, for sure, it was just a small thing. Thanks Hans br Jonathan
diff --git a/drivers/staging/media/atomisp/i2c/gc2235.h b/drivers/staging/media/atomisp/i2c/gc2235.h index 55ea422291ba..ade28950db73 100644 --- a/drivers/staging/media/atomisp/i2c/gc2235.h +++ b/drivers/staging/media/atomisp/i2c/gc2235.h @@ -74,9 +74,6 @@ #define GC2235_COARSE_INTG_TIME_MIN 1 #define GC2235_COARSE_INTG_TIME_MAX_MARGIN 6 -/* - * GC2235 System control registers - */ /* * GC2235 System control registers */ @@ -167,7 +164,7 @@ enum gc2235_tok_type { GC2235_TOK_MASK = 0xfff0 }; -/** +/* * struct gc2235_reg - MI sensor register format * @type: type of the register * @reg: 8-bit offset to register