From patchwork Fri Oct 20 22:27:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Steven Rostedt X-Patchwork-Id: 156355 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:6359:6b8b:b0:164:83eb:24d7 with SMTP id ta11csp31485rwb; Fri, 20 Oct 2023 15:28:27 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiHTq4/aQI2al9l+YXkwhHw+xha+VDvbb9zbsDEd2Xfkm4X89qZnBvsRzGjmnc7EIgAS+w X-Received: by 2002:a17:90b:33c3:b0:276:78f2:5d31 with SMTP id lk3-20020a17090b33c300b0027678f25d31mr4338098pjb.21.1697840907143; Fri, 20 Oct 2023 15:28:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697840907; cv=none; d=google.com; s=arc-20160816; b=jVdgAMoJqbIookwu92Yt3cLDRifp+0TwZpd2dyfluxMGO1VTlvbq5w0QnbgdDVZGKa wdKQGgiBwymxTFB3XUhZN9cndrwhPFzVe5tWYQSP6EfoRCIjmGyLahIuUpjzqdJtCsNQ hP/YFTHp1M4BDOf8hCyQjxjxUdtI2v5koG62Agryqw763aY5xrnUpQRvPxCC7GSgqTSL lcS8lGuICzQSHleEkDnd+4Wf0WM3Gng26Qll4vpPltRtzU++IE6jPthsB20amw1oGOrM JtE6p69Ehogixra/aEoiN6UQPiVU1E/2MNCC86qobd21YjYBCN1bjVyF0nmACjWYwgG5 /x9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:subject:cc:to:from:date :user-agent:message-id; bh=EQ4n0X3d+vxyb4mCeVAi9KsWxoMIvelJMSb0dI81Tgk=; fh=gMGlXfW0sFvPOGM7+SFGc+r78hw7cjZmPhaXb0CQaX0=; b=auq50C41GIH7VrSabpIBCu+srFEUqtZhYpjkOUQkcBhRWBt8oyZoC/dD4cH31c/Ob7 hOJVEfKQxf0TPqyCpEQYiAkVcfBetwxB6IYXsUtypzXIZ0trWRZUgwbFGQGLuOGpkKh6 Qxt4Cv2ZVKfiu4HgJP2UycgPERXqpKiPJ/j9B0S6qLaNLbBxp6qPwG96tIlG2qZN9etU SR2tJKsTcwbFZvDhzj4TwzwgAFV393jKBGani/hipeAcXFLNE/fAJYSP3owEc+TMNnSy cfTSh3+zUtrpbVxzWA7IUVB3FiurYpKwqw/jG0GAVWxxdkZ2m9Y1w4ADdtnUHlq8/CPW dFHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id 17-20020a17090a035100b00277453e82fesi2576503pjf.87.2023.10.20.15.28.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 15:28:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E3C188434ADE; Fri, 20 Oct 2023 15:28:15 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230188AbjJTW1q (ORCPT + 26 others); Fri, 20 Oct 2023 18:27:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34142 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229928AbjJTW1n (ORCPT ); Fri, 20 Oct 2023 18:27:43 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 997021A3 for ; Fri, 20 Oct 2023 15:27:41 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 400ABC433C9; Fri, 20 Oct 2023 22:27:41 +0000 (UTC) Received: from rostedt by gandalf with local (Exim 4.96) (envelope-from ) id 1qtxxz-00AQYF-2w; Fri, 20 Oct 2023 18:27:39 -0400 Message-ID: <20231020222739.722516559@goodmis.org> User-Agent: quilt/0.66 Date: Fri, 20 Oct 2023 18:27:14 -0400 From: Steven Rostedt To: linux-kernel@vger.kernel.org Cc: Masami Hiramatsu , Mark Rutland , Andrew Morton , Kees Cook , Nathan Chancellor Subject: [for-next][PATCH 1/6] eventfs: Use ERR_CAST() in eventfs_create_events_dir() References: <20231020222713.074741220@goodmis.org> MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 20 Oct 2023 15:28:15 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780315226907966879 X-GMAIL-MSGID: 1780315226907966879 From: Nathan Chancellor When building with clang and CONFIG_RANDSTRUCT_FULL=y, there is an error due to a cast in eventfs_create_events_dir(): fs/tracefs/event_inode.c:734:10: error: casting from randomized structure pointer type 'struct dentry *' to 'struct eventfs_inode *' 734 | return (struct eventfs_inode *)dentry; | ^ 1 error generated. Use the ERR_CAST() function to resolve the error, as it was designed for this exact situation (casting an error pointer to another type). Link: https://lore.kernel.org/linux-trace-kernel/20231018-ftrace-fix-clang-randstruct-v1-1-338cb214abfb@kernel.org Closes: https://github.com/ClangBuiltLinux/linux/issues/1947 Fixes: 5790b1fb3d67 ("eventfs: Remove eventfs_file and just use eventfs_inode") Reviewed-by: Kees Cook Signed-off-by: Nathan Chancellor Signed-off-by: Steven Rostedt (Google) --- fs/tracefs/event_inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/tracefs/event_inode.c b/fs/tracefs/event_inode.c index 1ccd100bc565..9f19b6608954 100644 --- a/fs/tracefs/event_inode.c +++ b/fs/tracefs/event_inode.c @@ -731,7 +731,7 @@ struct eventfs_inode *eventfs_create_events_dir(const char *name, struct dentry return NULL; if (IS_ERR(dentry)) - return (struct eventfs_inode *)dentry; + return ERR_CAST(dentry); ei = kzalloc(sizeof(*ei), GFP_KERNEL); if (!ei)