From patchwork Fri Oct 20 12:21:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavrilov Ilia X-Patchwork-Id: 156090 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp1015333vqb; Fri, 20 Oct 2023 05:21:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFa0WhcBfZjeyadt1I20mApbewc5KSBIuc193ISVD1m5Oy8Iu77UIDuiUwmrswgSBTlfIBX X-Received: by 2002:a05:6e02:1cac:b0:357:4c22:e032 with SMTP id x12-20020a056e021cac00b003574c22e032mr1891942ill.18.1697804507783; Fri, 20 Oct 2023 05:21:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697804507; cv=none; d=google.com; s=arc-20160816; b=ePcyeOJ0W15JUABLQaVZ2XbJsp2eNJ3fcy4d9TfdaYLrpxJ3iDok1zpPXqHhwmFIls cMXZS8jNynoz/UenYusdlfGtfoulE4Zv2Bh8dBlVwV4zS+JqUH2u0tqEKhht0Uxd9aYi RHg9TM+Kr0ReIbgppitTHCmrvoHOrk3S6+AKBOZ5WiyMhE0IZk6C5gUSTo3Z/lupX92A D+nCvWRpcAwv08xtlDzqLsuRk9wli6yg5noVqMz94afjObmt1x4sJ2uoewH88f196VTN MVjOnM5ibdlkgIZil0Jkx5bs0gAPDgd3tGCve+qOnjkJPy9yKC0kfO9IjR7ArGoYBD+v MCzw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:content-transfer-encoding :content-language:accept-language:message-id:date:thread-index :thread-topic:subject:cc:to:from:dkim-signature:dkim-filter; bh=MeYVgElruHgoPzcT+C8vkLtksDQKssoIBbZPZzRGhUY=; fh=WSN0yOt+MOVJjEcQL1kSZETYc1K4LDLv7A1ldWmqk4I=; b=bJWiRlLtGm3t+TJTYpNyxMzaIUkOWL60HW9c5ytSf0SaxRxYZpHSUBuTeJgNX7hVNx fL89MoLg/1FwxLLLs65zvKxXtWM0F9QYhQ/AgTnxrEhTK3SPEQ46olX+KK0IqttOEdfy L0egn3GPWskVfxGNQeFGrxQRUGBTK8lzzUJogg/BUF0/htptnA8XRZprbm8z81WmbZFm Tc7ObQnYdrSPSBz69GKy5OWyfM9fQ6kFEs/rl6VzgLZrjYUO2SyJ9jJvLtYZ2FWXXNCS JVwuYyK6Fs5YhDlIHb7pSTVx0dAd3ucnx2p6xfwS1a/0n/Kr4NBMa+TglrK06qo3ZklE p4dQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infotecs.ru header.s=mx header.b=IvFgiRPe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=infotecs.ru Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id v185-20020a6389c2000000b00573f9a427d6si1741985pgd.450.2023.10.20.05.21.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 05:21:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@infotecs.ru header.s=mx header.b=IvFgiRPe; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=NONE dis=NONE) header.from=infotecs.ru Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 99D41826EC42; Fri, 20 Oct 2023 05:21:45 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377373AbjJTMV0 (ORCPT + 25 others); Fri, 20 Oct 2023 08:21:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377028AbjJTMVY (ORCPT ); Fri, 20 Oct 2023 08:21:24 -0400 Received: from mx0.infotecs.ru (mx0.infotecs.ru [91.244.183.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B2353106; Fri, 20 Oct 2023 05:21:21 -0700 (PDT) Received: from mx0.infotecs-nt (localhost [127.0.0.1]) by mx0.infotecs.ru (Postfix) with ESMTP id 7D07110CD493; Fri, 20 Oct 2023 15:21:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx0.infotecs.ru 7D07110CD493 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=infotecs.ru; s=mx; t=1697804476; bh=MeYVgElruHgoPzcT+C8vkLtksDQKssoIBbZPZzRGhUY=; h=From:To:CC:Subject:Date:From; b=IvFgiRPeE2SzWWsBX+hylfJcub+A+eTAHHCkWRS87osccwTslTqcPvybB7V7jEF2S iOxdQrNhrnjca3jC0A2X8cNTtjkua5ZqjqiRBrqoriPVF1T0dThQkWe0uVv9FNqLU6 5lK1W+g/6uCU7rbok1xzve78RwJG+S2y2jZ7EqGc= Received: from msk-exch-01.infotecs-nt (msk-exch-01.infotecs-nt [10.0.7.191]) by mx0.infotecs-nt (Postfix) with ESMTP id 7A762300EAA4; Fri, 20 Oct 2023 15:21:16 +0300 (MSK) From: Gavrilov Ilia To: "David S. Miller" CC: Eric Dumazet , Jakub Kicinski , Paolo Abeni , Greg Kroah-Hartman , Sebastian Reichel , "Rafael J. Wysocki" , Chas Williams , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "lvc-project@linuxtesting.org" Subject: [PATCH net-next] net: atm: Remove redundant check. Thread-Topic: [PATCH net-next] net: atm: Remove redundant check. Thread-Index: AQHaA0/sv44EDzb/ykSk/HUfw6flbQ== Date: Fri, 20 Oct 2023 12:21:16 +0000 Message-ID: <20231020121853.3454896-1-Ilia.Gavrilov@infotecs.ru> Accept-Language: ru-RU, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.17.0.10] x-exclaimer-md-config: 208ac3cd-1ed4-4982-a353-bdefac89ac0a MIME-Version: 1.0 X-KLMS-Rule-ID: 5 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, disabled by settings X-KLMS-AntiSpam-Interceptor-Info: not scanned X-KLMS-AntiPhishing: Clean, bases: 2023/10/20 11:07:00 X-KLMS-AntiVirus: Kaspersky Security for Linux Mail Server, version 8.0.3.30, bases: 2023/10/20 09:36:00 #22238310 X-KLMS-AntiVirus-Status: Clean, skipped X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 20 Oct 2023 05:21:45 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780277059935296344 X-GMAIL-MSGID: 1780277059935296344 Checking the 'adev' variable is unnecessary, because 'cdev' has already been checked earlier. Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE. Fixes: 656d98b09d57 ("[ATM]: basic sysfs support for ATM devices") Signed-off-by: Gavrilov Ilia --- net/atm/atm_sysfs.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/net/atm/atm_sysfs.c b/net/atm/atm_sysfs.c index 466353b3dde4..54e7fb1a4ee5 100644 --- a/net/atm/atm_sysfs.c +++ b/net/atm/atm_sysfs.c @@ -116,8 +116,6 @@ static int atm_uevent(const struct device *cdev, struct kobj_uevent_env *env) return -ENODEV; adev = to_atm_dev(cdev); - if (!adev) - return -ENODEV; if (add_uevent_var(env, "NAME=%s%d", adev->type, adev->number)) return -ENOMEM;