From patchwork Fri Oct 20 10:55:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Srinivas Kandagatla X-Patchwork-Id: 156001 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp967736vqb; Fri, 20 Oct 2023 03:56:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEW/42p8skMf8ZqlcJqHGY+zI3YKrsinY6dTrmkX4HAl7awffDk2YOxxAI/KefUGsadWQqZ X-Received: by 2002:a05:6808:210f:b0:3a7:26fd:b229 with SMTP id r15-20020a056808210f00b003a726fdb229mr1623610oiw.48.1697799399861; Fri, 20 Oct 2023 03:56:39 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697799399; cv=none; d=google.com; s=arc-20160816; b=CusdPlQfWGeb9nxrRYfnQ/OMFbmqNcciuPngkDwgNOHHk8e4tzuc1gDJHfwh6eKtbz Qkbb2+q8E++/eALCMhLcW1+T3Kce/UzoMSXcs1Hb8Q2vtnnBNcxPKPsc1UVwisuUosDk e6cBPuxU4IH6RD8acAlsg8uX2P2I+TC9TeKYh2/7HtVUM1lb/H14NmLa8LogqzkUp+jw lSS9xxbkrS9Nvc1C/aVZ9y3NmWWciRS5/AcdVSI8aqByPvhnBDd4kJYykGGvdnVwZcj3 3HpBXg1jpjpU+21HUG3VsCF/Wy+e9onUrD6DM8hWHww91HAA8JD57pM/myBoJBy9SLKo /Sgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=+uq/c1O+wi+Li74Qe8dqIPXwWq5ovqnWT6YA9szi7Fs=; fh=mCFbQsDoPcHHklqeLHvDMbWIR4PSn/p3pJucmg4CCWE=; b=pszfu2oI95o+lXhoHOU665INzfSgrIk3DWjp9WjehHDkxXwAmDH59UIkFWqMLipAP2 4FYKivg5gQ988knvDt43ka5i1DWA4bHyomp/AzsQjoJc2C/PnzCJWhmoCy8LJcBwr/rv SGuWBDkQrH22y73DxWw+A/bnxBQJ+JpmTX7aeIUqGTgOkz5cmOdVgCdLApiJa9LcFHgD cpzTdhP2KHrbA0/FvJzk24q9LCkb7DLN6XKqsiXNz9c0gLbNwe4GFIvdNUJC1Pro2Oj9 yIZrK72xycQ6i5hMq+BWIugegzRTUFFX8EoUf+LnZy0/6IYYZ1C5w7+6/R3aTyfK0eYa fFcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="mN8QUuP/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id s62-20020a632c41000000b005b3e6867a01si1639531pgs.427.2023.10.20.03.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 03:56:39 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="mN8QUuP/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id BDF3183D10E6; Fri, 20 Oct 2023 03:56:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377122AbjJTK4Y (ORCPT + 25 others); Fri, 20 Oct 2023 06:56:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54514 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377025AbjJTK4K (ORCPT ); Fri, 20 Oct 2023 06:56:10 -0400 Received: from mail-wm1-x334.google.com (mail-wm1-x334.google.com [IPv6:2a00:1450:4864:20::334]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32E99119 for ; Fri, 20 Oct 2023 03:56:04 -0700 (PDT) Received: by mail-wm1-x334.google.com with SMTP id 5b1f17b1804b1-40806e4106dso4024685e9.1 for ; Fri, 20 Oct 2023 03:56:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1697799362; x=1698404162; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=+uq/c1O+wi+Li74Qe8dqIPXwWq5ovqnWT6YA9szi7Fs=; b=mN8QUuP/+XweH1SoMTJQEyvqUoVGVrK6DQLYbEVMBuXn5mEDsn+iMFU1gKxpF1dIuX 8B7WOarSVLK7A2O38jCuSy68vgsH+SoEpL/USC+nN7051WSSHfi1k5EHUrrQM2389skv plIQCtMEC76l7uOIZDgto2+XiFR/TyY9GsfJxf8d181FHir6P3hxUA5FgsQrmHg59h1g P4pmxYp3lwgG/UdX/wWuSQNwN76AES/ZqJh/S6bv5Mwgt654uLjCxvuAZw2Xb7xGk7uU idKRJbRYirqgmRE63PTcoB51gN9jevXsiK1N6jh4VIREoFHckCKtJeVnxAl01eQV8BiN p7NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697799362; x=1698404162; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+uq/c1O+wi+Li74Qe8dqIPXwWq5ovqnWT6YA9szi7Fs=; b=Tmi8pD1LzbcwWnRRGiXwvD5B7fZjXkNuohS5muFX5dmEpZdFgs2P3QMbzzEnbbx6vS oRZ1DvoDwR82QbNYGY/oDusiA8TMGME1stE/CSbClZAo7sbECr5gRKKwoN+Jj7SK2F5e rvl1kmhrBmRtouuRmy27+jDGqjchtntBdJX9upQOdt5j8iV5CbmnnqjuAZXHzm5UQZSF 4GtJhm/wzH3WJoKlDJotrayH6u3yuGSsrwZTIXDo3Il/H7t4MIDRw0gbP8ptJifHc997 /HLzTpJM3WKrMNxm6kPOgxiAricyU/8WdjVjlSNc4nLQ55t1I/UYk6Q5+tEKkM/Jih6W 8DgA== X-Gm-Message-State: AOJu0YwNIknM4kkOCJhPCwS7yKDhFEBSJEGxDGF7/GNeg/QQxghR+aUV ntxTB5S+kIKtBm1NIRjgxygHvg== X-Received: by 2002:a05:600c:1d26:b0:405:3924:3cad with SMTP id l38-20020a05600c1d2600b0040539243cadmr1373735wms.15.1697799362557; Fri, 20 Oct 2023 03:56:02 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id x9-20020a05600c420900b004065e235417sm6578937wmh.21.2023.10.20.03.56.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 03:56:01 -0700 (PDT) From: srinivas.kandagatla@linaro.org To: gregkh@linuxfoundation.org Cc: linux-kernel@vger.kernel.org, Luca Weiss , Douglas Anderson , Srinivas Kandagatla Subject: [PATCH 1/6] nvmem: qfprom: Mark core clk as optional Date: Fri, 20 Oct 2023 11:55:40 +0100 Message-Id: <20231020105545.216052-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231020105545.216052-1-srinivas.kandagatla@linaro.org> References: <20231020105545.216052-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 X-Spam-Status: No, score=2.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, RCVD_IN_SBL_CSS,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 20 Oct 2023 03:56:37 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780271703073791957 X-GMAIL-MSGID: 1780271703073791957 From: Luca Weiss On some platforms like sc7280 on non-ChromeOS devices the core clock cannot be touched by Linux so we cannot provide it. Mark it as optional as accessing qfprom for reading works without it but we still prohibit writing if we cannot provide the clock. Signed-off-by: Luca Weiss Reviewed-by: Douglas Anderson Signed-off-by: Srinivas Kandagatla --- drivers/nvmem/qfprom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c index 14814cba2dd6..525be03b7bba 100644 --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -423,12 +423,12 @@ static int qfprom_probe(struct platform_device *pdev) if (IS_ERR(priv->vcc)) return PTR_ERR(priv->vcc); - priv->secclk = devm_clk_get(dev, "core"); + priv->secclk = devm_clk_get_optional(dev, "core"); if (IS_ERR(priv->secclk)) return dev_err_probe(dev, PTR_ERR(priv->secclk), "Error getting clock\n"); - /* Only enable writing if we have SoC data. */ - if (priv->soc_data) + /* Only enable writing if we have SoC data and a valid clock */ + if (priv->soc_data && priv->secclk) econfig.reg_write = qfprom_reg_write; }