From patchwork Fri Oct 20 09:17:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Su Hui X-Patchwork-Id: 155902 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp926106vqb; Fri, 20 Oct 2023 02:18:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHl1n9elHzQoH7/qtrrA/aWAoks1fd1r0oGjpF93fHe3CwmZ/PaFtNL3IPRXV/lU/hqtqy+ X-Received: by 2002:a17:902:f7cd:b0:1c6:30d1:7214 with SMTP id h13-20020a170902f7cd00b001c630d17214mr1263133plw.55.1697793485202; Fri, 20 Oct 2023 02:18:05 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697793485; cv=none; d=google.com; s=arc-20160816; b=WMXCOmW6Pp9Q3z3TwVmgmbKs9zvHZvdlWRxLear46eizefW9K5ZZG3S9PJn/ambWXA G1NddmdgdBkIXc010HY37G4tXsQrkGVi4pVmnIdWoLZYpbaVl/OfMCk/BL0WSYIO6L9F sUWnBrU45yImbpd6l/TvqoPtn/G/KmQBrEHH8ym7uMV15+nqDypctXauMWvDWT1XumoR FCAocoTfDY6QsfIQyHxMPQjVnaRbsN/eXMFpuLq+TSPolEKuaUEGu+JN9hf76+8OvLYD 6xuwMlxWpsV/cd4cwv8DGrcU1f7QmhiVFPSW/CFiCwUmls0ibX5ZjDviVDWXywMX+4LF egoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=zgfGa9EL28deAdw15DOAj0cugglPIY+emo1+1cUlEus=; fh=vk0eLQHq4yQC1F9+t/KH5nxJfs6De3HIHIMYrKH7M6c=; b=Zppb2zqKdKzoAXNrBCRCCmxQQY2sfAiFaeCPDWK4Xy+gDTXsV70ipwCpaZ7DrHpiG4 +j6z9XUW0Jge13GbFUFTxFK9evBCWgwSVDQK2YEoWxjepkYfy445xxDWg0vYC0OvSB/3 hEWwMQBoFPuusMkf7Eku1svLXxiKmtqHiSg++H1Db5kow09y8Q1rJSMpDQqZLtavO4oo rgDakEXFIF+uJ55bMt3+FgzuccfmOGYWmcbeJCdb+op/F4vpSdv4Cdx3sDt4XeD2ZTHw LqPqUdpDsalk33nfCmfkQUeHw7Wy7HBEomBMn9R9ROM2h+X9xCagKH4lly9IRJnT+RmO iesg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from morse.vger.email (morse.vger.email. [23.128.96.31]) by mx.google.com with ESMTPS id d6-20020a170903230600b001ca6abecb27si1544607plh.498.2023.10.20.02.18.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 20 Oct 2023 02:18:05 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) client-ip=23.128.96.31; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.31 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 441FE83C2398; Fri, 20 Oct 2023 02:18:03 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1376614AbjJTJRp (ORCPT + 25 others); Fri, 20 Oct 2023 05:17:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41610 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1376523AbjJTJRn (ORCPT ); Fri, 20 Oct 2023 05:17:43 -0400 Received: from mail.nfschina.com (unknown [42.101.60.195]) by lindbergh.monkeyblade.net (Postfix) with SMTP id 7F890AB; Fri, 20 Oct 2023 02:17:40 -0700 (PDT) Received: from localhost.localdomain (unknown [180.167.10.98]) by mail.nfschina.com (Maildata Gateway V2.8.8) with ESMTPA id DB0366024D8BF; Fri, 20 Oct 2023 17:17:37 +0800 (CST) X-MD-Sfrom: suhui@nfschina.com X-MD-SrcIP: 180.167.10.98 From: Su Hui To: mchehab@kernel.org Cc: Su Hui , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] media: ddbridge: fix an error code problem in ddb_probe Date: Fri, 20 Oct 2023 17:17:23 +0800 Message-Id: <20231020091722.207022-1-suhui@nfschina.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Fri, 20 Oct 2023 02:18:03 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780265501328973622 X-GMAIL-MSGID: 1780265501328973622 Error code is assigned to 'stat', return 'stat' rather than '-1'. Signed-off-by: Su Hui --- drivers/media/pci/ddbridge/ddbridge-main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/pci/ddbridge/ddbridge-main.c b/drivers/media/pci/ddbridge/ddbridge-main.c index 91733ab9f58c..363badab7cf0 100644 --- a/drivers/media/pci/ddbridge/ddbridge-main.c +++ b/drivers/media/pci/ddbridge/ddbridge-main.c @@ -238,7 +238,7 @@ static int ddb_probe(struct pci_dev *pdev, ddb_unmap(dev); pci_set_drvdata(pdev, NULL); pci_disable_device(pdev); - return -1; + return stat; } /****************************************************************************/