diff mbox series

[net] net: ethernet: adi: adin1110: Fix uninitialized variable

Message ID 20231020062055.449185-1-ciprian.regus@analog.com
State New
Headers
Series [net] net: ethernet: adi: adin1110: Fix uninitialized variable |

Commit Message

Ciprian Regus Oct. 20, 2023, 6:20 a.m. UTC 
  From: Dell Jin <dell.jin.code@outlook.com>

The spi_transfer struct has to have all it's fields initialized to 0 in
this case, since not all of them are set before starting the transfer.
Otherwise, spi_sync_transfer() will sometimes return an error.

Fixes: a526a3cc9c8d ("net: ethernet: adi: adin1110: Fix SPI transfers")
Signed-off-by: Dell Jin <dell.jin.code@outlook.com>
Signed-off-by: Ciprian Regus <ciprian.regus@analog.com>
---
 drivers/net/ethernet/adi/adin1110.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jakub Kicinski Oct. 24, 2023, 12:11 a.m. UTC | #1 
On Fri, 20 Oct 2023 09:20:53 +0300 Ciprian Regus wrote:
> The spi_transfer struct has to have all it's fields initialized to 0 in
> this case, since not all of them are set before starting the transfer.
> Otherwise, spi_sync_transfer() will sometimes return an error.
> 
> Fixes: a526a3cc9c8d ("net: ethernet: adi: adin1110: Fix SPI transfers")

Applied, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/adi/adin1110.c b/drivers/net/ethernet/adi/adin1110.c
index ca66b747b7c5..d7c274af6d4d 100644
--- a/drivers/net/ethernet/adi/adin1110.c
+++ b/drivers/net/ethernet/adi/adin1110.c
@@ -296,3 +296,3 @@  static int adin1110_read_fifo(struct adin1110_port_priv *port_priv)
 	u32 header_len = ADIN1110_RD_HEADER_LEN;
-	struct spi_transfer t;
+	struct spi_transfer t = {0};
 	u32 frame_size_no_fcs;