Message ID | 20231019135342.1209152-1-ivecera@redhat.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2010:b0:403:3b70:6f57 with SMTP id fe16csp398640vqb; Thu, 19 Oct 2023 06:54:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFWrQ8MBvOl2+rCIoUiqKCVqhxK5gV/I9JTFbQ7NAt2zy4WbcanG3P6EOe49ElMO8F9dJpV X-Received: by 2002:a05:6359:6609:b0:168:af97:e92e with SMTP id sm9-20020a056359660900b00168af97e92emr34608rwb.11.1697723694183; Thu, 19 Oct 2023 06:54:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697723694; cv=none; d=google.com; s=arc-20160816; b=OqRze3/EZ8h64aU/KlwUk51M3JNrrxInw0dqltWPDZSkdY8urKJzYMF6W9/dM9QPFz u972xJWLKJKoQlRkOxfYWIXsMLRy/IK77QmFIfL9pdA1VumVfJT1mEK9UyOuqZWasuUn pRTypyXttYFENVUzRy4f6Zhz7WXbflMRFKy2NU2lTqhNAwL0h00uif3wAUmblb0nRU9i 6K+uvwY5SKhzwDdU3bih8J6JJxamFiU7FzS2P9Laa3UZ9IzNYUh3qAJy+HjzdkJ8dPFM pt3NkQv2USFdhrGv0MCUIqrvDy2zDM9ug5+l+OBX6AZ6yoH9qbjnJ1o871J6l3ovuEgV 7cng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=HhuLAtEC9vvHEOX4edXMkoJRK35YOO0BifovbLT07EE=; fh=Bqhr8Vc89ZQ1+t1hZG8SptT1vQ10zKd0D1fj05iYin0=; b=bnGFlBmV4AZBMdyhq0iz1v0eeGY3L7xNSn3IToeD2R7VVrccSrmjBlI2HaHKrmIFLC pVrfYmasuIEcW9g28t2/PVgUuPmdLvLMHerl0hBqXCOlCIwVReaeW0VgcBL/EloFvIoL JAvPw7KfBWZLmR15wAe0zxCfc1hU0yS11cjIUHfaBgZznexGovVWs+aDDkv0akIXg54b Bn8d5DnAw0P1pwVD/avc7y/83xNtTKMY7gn7qlKWzAM1zRO7RlBg+RCh8pWIfHyt0f+X Azbqk/7nAA7k8cFz1fY/M8xEHkTuaHI5VrrPmfBDjMabuDeB7RxT9ijbzDRWnfnwMbFL sB0w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h6vOHpXW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id g2-20020a056a0023c200b006bd27e41c17si5087801pfc.314.2023.10.19.06.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Oct 2023 06:54:54 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=h6vOHpXW; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 748F682372C4; Thu, 19 Oct 2023 06:54:51 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345759AbjJSNyk (ORCPT <rfc822;lkml4gm@gmail.com> + 25 others); Thu, 19 Oct 2023 09:54:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45178 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345498AbjJSNyj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 19 Oct 2023 09:54:39 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F782B0 for <linux-kernel@vger.kernel.org>; Thu, 19 Oct 2023 06:53:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1697723631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=HhuLAtEC9vvHEOX4edXMkoJRK35YOO0BifovbLT07EE=; b=h6vOHpXWO6Jm8RLCp14DXSMM8RZMnOzHrwUf2rpXM4De4i/YSPPt19EOtNAszxeLWUrQ12 wVaSHVHwhYUosVJIqYn9X8eKvArurLc3O/brfK34R0iTUqXUkPh5muzbiS9HBgjndCNaXj tXn6AYN0RC/dDc6YRdhGTtqWeyqMYxQ= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-359-kWHLDIYfO7KaAiIWsoYliQ-1; Thu, 19 Oct 2023 09:53:47 -0400 X-MC-Unique: kWHLDIYfO7KaAiIWsoYliQ-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id AFD1E185A78E; Thu, 19 Oct 2023 13:53:45 +0000 (UTC) Received: from p1.luc.com (unknown [10.45.226.105]) by smtp.corp.redhat.com (Postfix) with ESMTP id D8BF1111D782; Thu, 19 Oct 2023 13:53:43 +0000 (UTC) From: Ivan Vecera <ivecera@redhat.com> To: netdev@vger.kernel.org Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>, Tony Nguyen <anthony.l.nguyen@intel.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Jeff Kirsher <jeffrey.t.kirsher@intel.com>, Catherine Sullivan <catherine.sullivan@intel.com>, Anjali Singhai Jain <anjali.singhai@intel.com>, intel-wired-lan@lists.osuosl.org (moderated list:INTEL ETHERNET DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH net] i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR Date: Thu, 19 Oct 2023 15:53:42 +0200 Message-ID: <20231019135342.1209152-1-ivecera@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.3 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Thu, 19 Oct 2023 06:54:51 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780192320530435783 X-GMAIL-MSGID: 1780192320530435783 |
Series |
[net] i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR
|
|
Commit Message
Ivan Vecera
Oct. 19, 2023, 1:53 p.m. UTC
The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one.
Fixes: 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722")
Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of Ivan Vecera > Sent: Thursday, October 19, 2023 7:24 PM > To: netdev@vger.kernel.org > Cc: Catherine Sullivan <catherine.sullivan@intel.com>; Singhai, Anjali <anjali.singhai@intel.com>; Brandeburg, Jesse <jesse.brandeburg@intel.com>; open list <linux-kernel@vger.kernel.org>; Eric Dumazet <edumazet@google.com>; Nguyen, Anthony L <anthony.l.nguyen@intel.com>; Jeff Kirsher <jeffrey.t.kirsher@intel.com>; moderated list:INTEL ETHERNET DRIVERS <intel-wired-lan@lists.osuosl.org>; Jakub Kicinski <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller <davem@davemloft.net> > Subject: [Intel-wired-lan] [PATCH net] i40e: Fix wrong check for I40E_TXR_FLAGS_WB_ON_ITR > > The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one. > > Fixes: 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722") > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > --- > drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@intel.com> (A Contingent worker at Intel)
On Thu, Oct 19, 2023 at 03:53:42PM +0200, Ivan Vecera wrote: > The I40E_TXR_FLAGS_WB_ON_ITR is i40e_ring flag and not i40e_pf one. > > Fixes: 8e0764b4d6be42 ("i40e/i40evf: Add support for writeback on ITR feature for X722") > Signed-off-by: Ivan Vecera <ivecera@redhat.com> Thanks, I agree that I40E_TXR_FLAGS_WB_ON_ITR is consistently used as a i40e_ring flag, other than the case that is corrected by this patch. I also agree that the problem was introduced by the cited commit. Reviewed-by: Simon Horman <horms@kernel.org>
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c index 0b3a27f118fb97..9c36540846f7a9 100644 --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c @@ -2847,7 +2847,7 @@ int i40e_napi_poll(struct napi_struct *napi, int budget) return budget; } - if (vsi->back->flags & I40E_TXR_FLAGS_WB_ON_ITR) + if (q_vector->tx.ring[0].flags & I40E_TXR_FLAGS_WB_ON_ITR) q_vector->arm_wb_state = false; /* Exit the polling mode, but don't re-enable interrupts if stack might