From patchwork Wed Oct 18 08:19:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Saeed Mahameed X-Patchwork-Id: 154750 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4640503vqb; Wed, 18 Oct 2023 01:22:04 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHIlqYxhDsSU4UBb4h7g3zNOCtbnCIVCySmNU1lw+ANGFuoimoIaLoQr4Hru9owLEgCBMha X-Received: by 2002:a9d:7291:0:b0:6cd:74d:1f34 with SMTP id t17-20020a9d7291000000b006cd074d1f34mr838416otj.1.1697617324443; Wed, 18 Oct 2023 01:22:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697617324; cv=none; d=google.com; s=arc-20160816; b=D24ItZj/FqmXedkMXrmLeJxzDsmYB7DWYd1xSZUAIpWFV++OBbfJ0J6g7z0FqlswuC btr8mpszRoSCOlIWR0khyJUVFOfOJg95Ml60S+y6A8MAs+QOkWHKHjVP3uxRYsZRRMmS BdaEdzBfbrI85sPTtLo9F642hKWs1QkEYs+gePWy/UzvgBn6LCfVHTyT//Xrszy0yHZ1 +YY6g1OfcW6D44wid7pAbt6QI0hSg9NxQ7J7CsNCxFBLBIFur48yb+1JDdYVy4cXZTYg bpXMfXCZSU/amGVfDUD7TMiF8qMe9VWVsJvkF5MJERFSLmjdQNY+swP2lT3EO7RU70D2 YE0w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=7ZdbztE5v3Gm56tRr4hdBYvBMgDr+4+0FF+C1vludAc=; fh=OTS644v5rY1g/BUg247H5CRHtQNgRTQkhSPfJvy2RGE=; b=jcBDorL0E/gDV8eKuFkzV62GBQ1lVxW5XfUW68FKshvfQDCkGjGbq5EjcVn88tL7qK TMLSDOveMEaahBkBxXW9iBy3ylHUHCDWxc/Kp5ubBTAnqrHv/l07eg6JSnK6VtVmF2Kt tV7mH+HyR7B05cmPHWHLig8JYATVjOHIhwoVNeOjFPa3v4n0gIRARlrdqg4uZ5+lFWpb a3d90zcjAApBLT81hCEGmaih8hMjTAPSQ8UxMcYlwBO9DKberQQGzLRTqAat6KjFw87y Zb+qvogH8mAQ4z8aIWayBcSnWfW1vHUxS8bCaWMy+AzyOVTYwvwhbEeWilsHlXauifFz HRyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MUjLEJMl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id m11-20020a056a00080b00b0068fcb7125e1si3632484pfk.242.2023.10.18.01.22.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Oct 2023 01:22:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=MUjLEJMl; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id E4F598099277; Wed, 18 Oct 2023 01:20:59 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235154AbjJRIUl (ORCPT + 24 others); Wed, 18 Oct 2023 04:20:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235065AbjJRIU0 (ORCPT ); Wed, 18 Oct 2023 04:20:26 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5FF60EA for ; Wed, 18 Oct 2023 01:20:24 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8C95C433C8; Wed, 18 Oct 2023 08:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1697617224; bh=ATZUQIWAOgDAg1PKI2T/FaVUQ9kUPdB2Z0fU+YtNRwE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MUjLEJMlV7ER+0vMYzAwh9Dks212LHRvExU9uZoCilL95H+Vp4h5BPdwzL7UaOZId tI37don1zU9Yr8FE/syE0LiWInBI0xTOcLQDXYdFcA8aIhfz4I1WiG8Lj2z2iI83t4 2Sn+WnrTpArtApT658+Tbxrdt3mBsfzKlTe3lIDvBC9t67PCKfb7KOzFkPUUBSyzgk QpuVeRnfAS5lrq97GybMiSrgiMVCdywgumuqJyqzej448yZ0CNDxpSMbyVH0kV2qj8 BEI4DTxErGVqcDCncSqNki9aI0upTvkeR1+xdR8hig5EWQcnnxt2iJbRIHkQ2Ys8jE OBICB8aU7Vi/w== From: Saeed Mahameed To: Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Leon Romanovsky , Jason Gunthorpe , Jiri Pirko , Saeed Mahameed Subject: [PATCH 3/5] misc: mlx5ctl: Add info ioctl Date: Wed, 18 Oct 2023 01:19:39 -0700 Message-ID: <20231018081941.475277-4-saeed@kernel.org> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231018081941.475277-1-saeed@kernel.org> References: <20231018081941.475277-1-saeed@kernel.org> MIME-Version: 1.0 X-Spam-Status: No, score=-1.2 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Wed, 18 Oct 2023 01:21:00 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780080783216998778 X-GMAIL-MSGID: 1780080783216998778 From: Saeed Mahameed Implement INFO ioctl to return the allocated UID and the capability flags and some other useful device information such as the underlying ConnectX device. Example: $ mlx5ctl mlx5_core.ctl.0 mlx5dev: 0000:00:04.0 UCTX UID: 1 UCTX CAP: 0x3 DEV UCTX CAP: 0x3 USER CAP: 0x1d Reviewed-by: Leon Romanovsky Reviewed-by: Jason Gunthorpe Signed-off-by: Saeed Mahameed --- .../userspace-api/ioctl/ioctl-number.rst | 1 + drivers/misc/mlx5ctl/main.c | 72 +++++++++++++++++++ include/uapi/misc/mlx5ctl.h | 24 +++++++ 3 files changed, 97 insertions(+) create mode 100644 include/uapi/misc/mlx5ctl.h diff --git a/Documentation/userspace-api/ioctl/ioctl-number.rst b/Documentation/userspace-api/ioctl/ioctl-number.rst index 4ea5b837399a..9faf91ffefff 100644 --- a/Documentation/userspace-api/ioctl/ioctl-number.rst +++ b/Documentation/userspace-api/ioctl/ioctl-number.rst @@ -89,6 +89,7 @@ Code Seq# Include File Comments 0x20 all drivers/cdrom/cm206.h 0x22 all scsi/sg.h 0x3E 00-0F linux/counter.h +0x5c all uapi/misc/mlx5ctl.h Nvidia ConnectX control '!' 00-1F uapi/linux/seccomp.h '#' 00-3F IEEE 1394 Subsystem Block for the entire subsystem diff --git a/drivers/misc/mlx5ctl/main.c b/drivers/misc/mlx5ctl/main.c index de8d6129432c..008ad3a12d97 100644 --- a/drivers/misc/mlx5ctl/main.c +++ b/drivers/misc/mlx5ctl/main.c @@ -8,6 +8,7 @@ #include #include #include +#include #include #include @@ -198,10 +199,81 @@ static int mlx5ctl_release(struct inode *inode, struct file *file) return 0; } +static int mlx5ctl_info_ioctl(struct file *file, void __user *arg, size_t usize) +{ + struct mlx5ctl_fd *mfd = file->private_data; + struct mlx5ctl_dev *mcdev = mfd->mcdev; + struct mlx5_core_dev *mdev = mcdev->mdev; + struct mlx5ctl_info *info; + void *kbuff = NULL; + size_t ksize = 0; + int err = 0; + + ksize = max(sizeof(struct mlx5ctl_info), usize); + kbuff = kzalloc(ksize, GFP_KERNEL_ACCOUNT); + if (!kbuff) + return -ENOMEM; + + info = kbuff; + + info->size = sizeof(struct mlx5ctl_info); + info->flags = 0; + + info->dev_uctx_cap = MLX5_CAP_GEN(mdev, uctx_cap); + info->uctx_cap = mfd->uctx_cap; + info->uctx_uid = mfd->uctx_uid; + info->ucap = mfd->ucap; + + strscpy(info->devname, dev_name(&mdev->pdev->dev), sizeof(info->devname)); + + if (copy_to_user(arg, kbuff, usize)) + err = -EFAULT; + + kfree(kbuff); + return err; +} + +static ssize_t mlx5ctl_ioctl(struct file *file, unsigned int cmd, + unsigned long arg) +{ + struct mlx5ctl_fd *mfd = file->private_data; + struct mlx5ctl_dev *mcdev = mfd->mcdev; + void __user *argp = (void __user *)arg; + size_t size = _IOC_SIZE(cmd); + int err = 0; + + if (!capable(CAP_SYS_ADMIN)) + return -EPERM; + + mlx5ctl_dbg(mcdev, "ioctl 0x%x type/nr: %d/%d size: %d DIR:%d\n", cmd, + _IOC_TYPE(cmd), _IOC_NR(cmd), _IOC_SIZE(cmd), _IOC_DIR(cmd)); + + down_read(&mcdev->rw_lock); + if (!mcdev->mdev) { + err = -ENODEV; + goto unlock; + } + + switch (cmd) { + case MLX5CTL_IOCTL_INFO: + err = mlx5ctl_info_ioctl(file, argp, size); + break; + + default: + mlx5ctl_dbg(mcdev, "Unknown ioctl %x\n", cmd); + err = -ENOIOCTLCMD; + break; + } +unlock: + up_read(&mcdev->rw_lock); + return err; +} + static const struct file_operations mlx5ctl_fops = { .owner = THIS_MODULE, .open = mlx5ctl_open, .release = mlx5ctl_release, + .unlocked_ioctl = mlx5ctl_ioctl, }; static int mlx5ctl_probe(struct auxiliary_device *adev, diff --git a/include/uapi/misc/mlx5ctl.h b/include/uapi/misc/mlx5ctl.h new file mode 100644 index 000000000000..81d89cd285fc --- /dev/null +++ b/include/uapi/misc/mlx5ctl.h @@ -0,0 +1,24 @@ +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB WITH Linux-syscall-note */ +/* Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights reserved. */ + +#ifndef __MLX5CTL_IOCTL_H__ +#define __MLX5CTL_IOCTL_H__ + +struct mlx5ctl_info { + __aligned_u64 flags; + __u32 size; + __u8 devname[64]; /* underlaying ConnectX device */ + __u16 uctx_uid; /* current process allocated UCTX UID */ + __u16 reserved1; + __u32 uctx_cap; /* current process effective UCTX cap */ + __u32 dev_uctx_cap; /* device's UCTX capabilities */ + __u32 ucap; /* process user capability */ + __u32 reserved2[4]; +}; + +#define MLX5CTL_IOCTL_MAGIC 0x5c + +#define MLX5CTL_IOCTL_INFO \ + _IOR(MLX5CTL_IOCTL_MAGIC, 0x0, struct mlx5ctl_info) + +#endif /* __MLX5CTL_IOCTL_H__ */