diff mbox series

[net-next,v2,1/1] net: stmmac: Remove redundant checking for rx_coalesce_usecs

Message ID 20231018030802.741923-1-yi.fang.gan@intel.com
State New
Headers
Series [net-next,v2,1/1] net: stmmac: Remove redundant checking for rx_coalesce_usecs |

Commit Message

Gan, Yi Fang Oct. 18, 2023, 3:08 a.m. UTC 
  From: Gan Yi Fang <yi.fang.gan@intel.com>

The datatype of rx_coalesce_usecs is u32, always larger or equal to zero.
Previous checking does not include value 0, this patch removes the
checking to handle the value 0. This change in behaviour making the
value of 0 cause an error is not a problem because 0 is out of
range of rx_coalesce_usecs.

Signed-off-by: Gan Yi Fang <yi.fang.gan@intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 19, 2023, 10:30 a.m. UTC | #1 
Hello:

This patch was applied to netdev/net-next.git (main)
by Paolo Abeni <pabeni@redhat.com>:

On Wed, 18 Oct 2023 11:08:02 +0800 you wrote:
> From: Gan Yi Fang <yi.fang.gan@intel.com>
> 
> The datatype of rx_coalesce_usecs is u32, always larger or equal to zero.
> Previous checking does not include value 0, this patch removes the
> checking to handle the value 0. This change in behaviour making the
> value of 0 cause an error is not a problem because 0 is out of
> range of rx_coalesce_usecs.
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/1] net: stmmac: Remove redundant checking for rx_coalesce_usecs
    https://git.kernel.org/netdev/net-next/c/392c226cda94

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
index 6aa5c0556d22..f628411ae4ae 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c
@@ -981,7 +981,7 @@  static int __stmmac_set_coalesce(struct net_device *dev,
 	else if (queue >= max_cnt)
 		return -EINVAL;
 
-	if (priv->use_riwt && (ec->rx_coalesce_usecs > 0)) {
+	if (priv->use_riwt) {
 		rx_riwt = stmmac_usec2riwt(ec->rx_coalesce_usecs, priv);
 
 		if ((rx_riwt > MAX_DMA_RIWT) || (rx_riwt < MIN_DMA_RIWT))