Message ID | 20231017205119.416392-1-florian.fainelli@broadcom.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4391609vqb; Tue, 17 Oct 2023 13:51:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEfbn3u7LCXjUrrqZDB8kPlKTWo+lYxht/3YIxirmMFSgoXg2DhVYqhlUXhV1vPCArJOVPa X-Received: by 2002:a17:90b:3148:b0:27d:9b6:ec1b with SMTP id ip8-20020a17090b314800b0027d09b6ec1bmr3575493pjb.4.1697575891954; Tue, 17 Oct 2023 13:51:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697575891; cv=none; d=google.com; s=arc-20160816; b=EfL3WOM9A71OJKJdAjv0JIwmtpwKNLw5iIimktjqFv9YDZEc4ts5R/UhQ6wdHvQ6H0 jVU9Rq/OWUdxqWNmO8U2Q+uLnIOk28PdzfWr0dr8RmMxyZPIbemM/vQ9k2fI4shUoyyJ Ng7iFPjMF9NzWzwaWRers4NfyLs5XPfSEYCm+qY5/Gr5zjaioDxzkcLSx1mZPg5Fw1ma O8ahKib5X8rycmAgXymVaW1q1V/sUIqFGTdcqAEvC4YJno9cRrwiN1RyEAiKIzm4gbGi 6U/xHimPa5++wn9A4sTsGe0SPlvM/I7YqFDEASqpuSmby85mCmexHR+n6fd8gEgLWOOg Qnuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from :dkim-signature; bh=YWSSAhvuClqliPpOpBjCiF34ABolG049E0aWXE63hSo=; fh=lEolNhAq4UbSRLfLfFukG2F9ILJ7SF2RzxeHLpLI+W8=; b=lZfwWlwTJVioPxVt096s9RHUhcNmoXqPJYJkik3kXyKgSwB4I2YXHmPrkDwbw/Wu1M lR/7G6OWKj2Cuu3udYzClPGR+zusjSjLlWNDAcCBH7Mo37/bA8pgMK01pXi53jwyoxPu 5r9xAmsFh/v0pUGR3WBZ0o56/xInGNyhaY1N9AaChUfi3TWxG+EXPeqESiJ8CnKiZ1bd JEyK2uTq0vmKJw3oJioS7v9L9oLfW89gq81+0SL2g3A0qBLKBKpHmsLfd5P9wWjuUtNI a3D9i3GVz/N1ydvg3YRtCTlRw7Poh0DmiQYnI1nUyWU6i14KbBDG0Nusca9EuShqtzZn SGqg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Dw+9nR5G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from snail.vger.email (snail.vger.email. [23.128.96.37]) by mx.google.com with ESMTPS id z8-20020a17090ab10800b002777ca0d151si9038149pjq.165.2023.10.17.13.51.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 13:51:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) client-ip=23.128.96.37; Authentication-Results: mx.google.com; dkim=pass header.i=@broadcom.com header.s=google header.b=Dw+9nR5G; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.37 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=broadcom.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 39AE98073292; Tue, 17 Oct 2023 13:51:31 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343653AbjJQUv2 (ORCPT <rfc822;dexuan.linux@gmail.com> + 21 others); Tue, 17 Oct 2023 16:51:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231149AbjJQUv0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 17 Oct 2023 16:51:26 -0400 Received: from mail-vk1-xa30.google.com (mail-vk1-xa30.google.com [IPv6:2607:f8b0:4864:20::a30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 846C89F for <linux-kernel@vger.kernel.org>; Tue, 17 Oct 2023 13:51:25 -0700 (PDT) Received: by mail-vk1-xa30.google.com with SMTP id 71dfb90a1353d-49a99c43624so2389590e0c.2 for <linux-kernel@vger.kernel.org>; Tue, 17 Oct 2023 13:51:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1697575884; x=1698180684; darn=vger.kernel.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=YWSSAhvuClqliPpOpBjCiF34ABolG049E0aWXE63hSo=; b=Dw+9nR5GP9xrBdqnV/FUNyIrSyjuKpll7mC7WoPTpHQGthWSsF2dxWqv2EMxJcK7SH LKDugy/EHRmLaczya5WRREwdszPqwp3ksWJvMWte96oHJhzbYUw5QweL72SAd8MkrZrx clAjyuqizx9zZM7Tqf+lKONryh8E7XCxO0J8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697575884; x=1698180684; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=YWSSAhvuClqliPpOpBjCiF34ABolG049E0aWXE63hSo=; b=fQiGLVjr3eOQvBu1RARe25wokbBJf0X0KI11gNRlWvhQDtTx3m2iWBbT1uwNvkVv+i kWEWAOpkzfF3LQD4ZNnZ0J8ZD0OCVfNMq19H7vtBLSnU3LdXbcXnrOTDsjOYTqwqKRqQ gLq0zjIn194HSMnUCZYE8hrpdcUplX7VhYTSV6uYiZjMxVDM/Of6xxluME5TYXcBqzCA 2jI4XNLiVg1MaRYi7uHVs/UzyT1wHNvu0d5wnlpNn85Y+DMM0l4MtyknxWpIOW+bMBKS rBLGpLruk2mlwGparVykcS/yM+NzXVfnGzhsc0fvHeVoyUmVo7o9T46HhGF7ieuc5XbM 3A+A== X-Gm-Message-State: AOJu0Yw9yI+mUsV4ZE15utJjxeJr+Yp97Elx4tixGFrRXHVJC2ezrCYU W/8LF7jE80/P4KJW9iGmpVpr+w== X-Received: by 2002:a05:6122:16a9:b0:4a8:4218:8074 with SMTP id 41-20020a05612216a900b004a842188074mr4346455vkl.8.1697575884473; Tue, 17 Oct 2023 13:51:24 -0700 (PDT) Received: from fainelli-desktop.igp.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id x20-20020ac87314000000b004194c21ee85sm893029qto.79.2023.10.17.13.51.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 13:51:23 -0700 (PDT) From: Florian Fainelli <florian.fainelli@broadcom.com> To: netdev@vger.kernel.org Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Justin Chen <justin.chen@broadcom.com>, Andrew Lunn <andrew@lunn.ch>, Broadcom internal kernel review list <bcm-kernel-feedback-list@broadcom.com>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, linux-kernel@vger.kernel.org (open list) Subject: [PATCH net v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics Date: Tue, 17 Oct 2023 13:51:19 -0700 Message-Id: <20231017205119.416392-1-florian.fainelli@broadcom.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000982dbb0607efaf99" X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MIME_NO_TEXT, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_NONE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 13:51:31 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780037338134440883 X-GMAIL-MSGID: 1780037338134440883 |
Series |
[net,v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics
|
|
Commit Message
Florian Fainelli
Oct. 17, 2023, 8:51 p.m. UTC
The .probe() function would allocate the necessary space and ensure that the library call sizes the nunber of statistics but the callbacks necessary to fetch the name and values were not wired up. Reported-by: Justin Chen <justin.chen@broadcom.com> Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") Reviewed-by: Andrew Lunn <andrew@lunn.ch> Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> --- drivers/net/phy/bcm7xxx.c | 3 +++ 1 file changed, 3 insertions(+)
Comments
On Tue, Oct 17, 2023 at 01:51:19PM -0700, Florian Fainelli wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen <justin.chen@broadcom.com> > Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> Reviewed-by: Simon Horman <horms@kernel.org>
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski <kuba@kernel.org>: On Tue, 17 Oct 2023 13:51:19 -0700 you wrote: > The .probe() function would allocate the necessary space and ensure that > the library call sizes the nunber of statistics but the callbacks > necessary to fetch the name and values were not wired up. > > Reported-by: Justin Chen <justin.chen@broadcom.com> > Fixes: f68d08c437f9 ("net: phy: bcm7xxx: Add EPHY entry for 72165") > Reviewed-by: Andrew Lunn <andrew@lunn.ch> > Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com> > > [...] Here is the summary with links: - [net,v2] net: phy: bcm7xxx: Add missing 16nm EPHY statistics https://git.kernel.org/netdev/net/c/6200e00e112c You are awesome, thank you!
diff --git a/drivers/net/phy/bcm7xxx.c b/drivers/net/phy/bcm7xxx.c index 8478b081c058..97638ba7ae85 100644 --- a/drivers/net/phy/bcm7xxx.c +++ b/drivers/net/phy/bcm7xxx.c @@ -894,6 +894,9 @@ static int bcm7xxx_28nm_probe(struct phy_device *phydev) .name = _name, \ /* PHY_BASIC_FEATURES */ \ .flags = PHY_IS_INTERNAL, \ + .get_sset_count = bcm_phy_get_sset_count, \ + .get_strings = bcm_phy_get_strings, \ + .get_stats = bcm7xxx_28nm_get_phy_stats, \ .probe = bcm7xxx_28nm_probe, \ .config_init = bcm7xxx_16nm_ephy_config_init, \ .config_aneg = genphy_config_aneg, \