From patchwork Tue Oct 17 17:04:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Colin Ian King X-Patchwork-Id: 154397 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4277388vqb; Tue, 17 Oct 2023 10:04:55 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHnd6/13E17Kls8PVRNOl/X1IBANc7nCIZ8pSF+ts6ANrlmXPZiMVB9whmBtFEg+cAnjMd0 X-Received: by 2002:a17:90b:4c11:b0:27d:193f:2130 with SMTP id na17-20020a17090b4c1100b0027d193f2130mr2984523pjb.3.1697562295367; Tue, 17 Oct 2023 10:04:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697562295; cv=none; d=google.com; s=arc-20160816; b=wHQyXqGDJLMmV42xtaPszVTxzZ9G8yVDyRfWaNOzWTpokp0j8nzH3fp50cv/CR3RKw LC3jttCgDcgg55mZiLBG9o+Kc/iIdt77mLiYGjTBE0jbbJU76WNp2VE6ZHb7FKdkcKr7 OcGFDoeESGe2SCgCgGkJP3RwSTa7j/9HWe+NF/DlwCVM/r6XUwWc+8XCm1wd78XoME8o lS6/T+ywFEaCVM3YZCDwzOoh3N5TPLT/kTdh0O1Eil+iDyp6ZgRhWhayuX7zXG5BLfvE 6gx/9FFkH31ehOORdQMaZvHptXbubLKCcS7SQLe/0BMk+TIqQsKsSDpELWpSb6ZX2j9u sRng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=iYhVgVukknKnttKNru5mCHTZ6wmo6E2zfS+vFjWMe7o=; fh=4l7lfDPEHRZrTEcOzCM9+QI1J+IB/kt0Ikk1bDuTt+0=; b=oven3L4OGVlamqp4VfnHt9xAwLV6RbLKfS295WFPRijDmgTR00lGdtGbW/JFjMfxS8 mxg7TfE1ycwEJOVGXfo3RrDbiLOVfTVSicaU3men9SeaiI+o8AlgrDjFkOZHWhkBxyFU 9WSartgn27lfIgSyWkvSdSEkYarRhfTcAUlGDOsgT+JEq3UlLyrAOyRxcW23Dz3fNn2G WVR9EkKn3FYP4er+/zMSvWpfGpEpTYr3xFxIF5ARClm1CNSMvquG70J/q70TlChtp4LK NEy7rveqpVaZMXK37sNsiRdXMUipxgD5Fo4twz0FvEGkJ+usdyqKvXz3QQl0zXym1dO0 kENA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="QO/ZDkK3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from agentk.vger.email (agentk.vger.email. [2620:137:e000::3:2]) by mx.google.com with ESMTPS id e10-20020a656bca000000b00578a56baebesi165571pgw.674.2023.10.17.10.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 10:04:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) client-ip=2620:137:e000::3:2; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20230601 header.b="QO/ZDkK3"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:2 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by agentk.vger.email (Postfix) with ESMTP id 6F879802CD15; Tue, 17 Oct 2023 10:04:53 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at agentk.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343858AbjJQREn (ORCPT + 20 others); Tue, 17 Oct 2023 13:04:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233493AbjJQREl (ORCPT ); Tue, 17 Oct 2023 13:04:41 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DBD06A4; Tue, 17 Oct 2023 10:04:39 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-40684f53bfcso53198395e9.0; Tue, 17 Oct 2023 10:04:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697562278; x=1698167078; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=iYhVgVukknKnttKNru5mCHTZ6wmo6E2zfS+vFjWMe7o=; b=QO/ZDkK3EhPj4DZHs+NlLly2/TBT43VjH3Ea4JTW9Vm6FFvyEPdAGBGibbzir80brh nurxejzCPnP8qj5CLFnqkK1rOTWzx+6Y9z7XtRSaXCpIdYHpAQE2mL0Hj8z5t6DBZr3s p1cLBTHW0FzYLjXpcUjplLwwZ7Xh+1jCa1LktH+Rr1jxbLcQ59xfgySgTtbjyooM9tkM efeVcnH3KkJKZPcSWYQvQDZklHMXpmZJnVnrBbflPpf661pDpZE6clAhkh12Z8oLmTRH Ngaj1cnW1Ol2T3LUTlwhnPx0a1iUN+9TU1L5SJv/AYeCx02IDfajwpAQz07Af0oFJzZQ sC0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697562278; x=1698167078; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iYhVgVukknKnttKNru5mCHTZ6wmo6E2zfS+vFjWMe7o=; b=pUgcO6BMl2tXC9CYp1diNQkx1Xdv1KD64Jjx4s0eoknKf7DV/kWL/TnREAfOHWQ0T/ WJ/etwB/gnctiUBRZfUp9NxBSVex4KsVu2kEXZ+KolRq0iMlG3Eut525Vx9SX/RJ6K9d PCHRhsN/1FvW7I8GSSJHxjLX7u5Wy1oetJR/6SvA9rnrrfTnBji5hVef7A5xYnZDISgu uenDqPTjQIPGj4IYbx2wkO6y0EN1oqevb/G+QtZoK2neps4bhsVKwsNKyZMAVxXMIPJr ZNtdVEBl+JSKgS2J5RL0wyHSbh6dC6wOmYF1ge0xu9RkuWazEH4aMsBkviVT3cZXavU4 nCXQ== X-Gm-Message-State: AOJu0YzViKu8cxW5Bimu0OdC1HM+sahGSibQOg4Ig5nwDKFJ7vYfKSal Cyaq7bl7UpRjJtyUlTzhJfTxB/A/nxLesA== X-Received: by 2002:a5d:4e47:0:b0:32d:65ab:2228 with SMTP id r7-20020a5d4e47000000b0032d65ab2228mr2287392wrt.11.1697562278015; Tue, 17 Oct 2023 10:04:38 -0700 (PDT) Received: from localhost (cpc154979-craw9-2-0-cust193.16-3.cable.virginm.net. [80.193.200.194]) by smtp.gmail.com with ESMTPSA id z9-20020adff749000000b00323287186aasm191730wrp.32.2023.10.17.10.04.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 10:04:37 -0700 (PDT) From: Colin Ian King To: Shenghao Ding , Kevin Lu , Baojun Xu , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH][next] ASoC: tas2781: make const read-only array magic_number static Date: Tue, 17 Oct 2023 18:04:36 +0100 Message-Id: <20231017170436.176615-1-colin.i.king@gmail.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.6 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on agentk.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (agentk.vger.email [0.0.0.0]); Tue, 17 Oct 2023 10:04:53 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780023081788721452 X-GMAIL-MSGID: 1780023081788721452 Don't populate the const read-only array magic_number on the stack, instead make it static const. Signed-off-by: Colin Ian King --- sound/soc/codecs/tas2781-fmwlib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/codecs/tas2781-fmwlib.c b/sound/soc/codecs/tas2781-fmwlib.c index e27775d834e9..4efe95b60aaa 100644 --- a/sound/soc/codecs/tas2781-fmwlib.c +++ b/sound/soc/codecs/tas2781-fmwlib.c @@ -1757,7 +1757,7 @@ static int fw_parse_header(struct tasdevice_priv *tas_priv, { struct tasdevice_dspfw_hdr *fw_hdr = &(tas_fmw->fw_hdr); struct tasdevice_fw_fixed_hdr *fw_fixed_hdr = &(fw_hdr->fixed_hdr); - const unsigned char magic_number[] = { 0x35, 0x35, 0x35, 0x32 }; + static const unsigned char magic_number[] = { 0x35, 0x35, 0x35, 0x32 }; const unsigned char *buf = (unsigned char *)fmw->data; if (offset + 92 > fmw->size) {