| Message ID | 20231017125239.164455-4-huangjunxian6@hisilicon.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id
ib8csp4111424vqb;
Tue, 17 Oct 2023 05:56:43 -0700 (PDT)
X-Google-Smtp-Source:
AGHT+IHmOmOcX8/Laza5SpLL6MT5U3KJaDCnONtXhQnBqpsDp2gFY/nCrq1JqzyHjJxV4SPCBh1F
X-Received: by 2002:a17:902:e54a:b0:1c1:fbec:bc3f with SMTP id
n10-20020a170902e54a00b001c1fbecbc3fmr2176325plf.5.1697547403607;
Tue, 17 Oct 2023 05:56:43 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1697547403; cv=none;
d=google.com; s=arc-20160816;
b=mzcsChvlE7dJyy06zX/0xpmXibcneuk7KKYRiY6qkVmVrIjcq7XGb6S79UIAmvMzmK
OLG9ypcTozs6MMBWTANTAfhbab4wvqiI2t5eW6VDQQndV58wPKJYZ5BAlTtjd/ykdm/G
rSDeuBVgi2D0sGlPwBEgLCYTEA0ijVP3DMuo0pOSF58pJeAopG+Ja36EEjUdltVZ51O/
mt1SSlcDXj2zGgV/TpQoNtlhKNyCWReKl9fG61RuMI3UKsVE7pEIKkWnYrVHksWdiaC3
hCclnuuUCSlDqQWmjD9fKEDarSUDg8iIdkLF0//zkdYxOpmr7Xn5rmbb8ihndyk5N4N+
akAQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=mtHg0IwRDCQ2l/8xePRzo42XR+AT1NpbKMamJOJQMvM=;
fh=KWvyQxL3Ff+3WPSMjlYu+P4255AmcMULAsFol6M1vNI=;
b=XlIiPeXGB9rR7JMqAK8dPjO0PPcxLO1UxszTkUyn32m1zj7OCiry4ioZ9Np48AN2Mu
KVDJ+fEUuoRIYP7yDNeUmk+rJ6Gl5Rdq14AKQsMFe9YTb5ilTYbsuKeGI7RZVtQ02I15
RDlO20LW7ScJ7Etc7Ju1Vm4QB4zU9MaLTJ0Sa9qFgWvCkztcz2PdpRr9dLZDN1VlsvP5
zILh1aFcukYqe8qKYXXExidmZ3bKEnmop+ixJtgrm+KJm0hjgWy1v4D3uDt33tAcvrkG
mGa9YzDFqTbr8caJK4Q3YCp4v6eJktacbXzVwA/Wxk9JzKH+/LQd4ICwQij1hrq8mSuk
HQBA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=hisilicon.com
Received: from howler.vger.email (howler.vger.email. [2620:137:e000::3:4])
by mx.google.com with ESMTPS id
bi12-20020a170902bf0c00b001c370dc4445si1645945plb.210.2023.10.17.05.56.43
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 17 Oct 2023 05:56:43 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
client-ip=2620:137:e000::3:4;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::3:4 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=hisilicon.com
Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0])
by howler.vger.email (Postfix) with ESMTP id 683E780A1E1F;
Tue, 17 Oct 2023 05:56:41 -0700 (PDT)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.10 at howler.vger.email
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1343737AbjJQM4F (ORCPT <rfc822;hjfbswb@gmail.com> + 19 others);
Tue, 17 Oct 2023 08:56:05 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34050 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S234486AbjJQMz6 (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Tue, 17 Oct 2023 08:55:58 -0400
Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7134F101;
Tue, 17 Oct 2023 05:55:56 -0700 (PDT)
Received: from kwepemi500006.china.huawei.com (unknown [172.30.72.54])
by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4S8v6H1tMGz15Nd5;
Tue, 17 Oct 2023 20:53:11 +0800 (CST)
Received: from localhost.localdomain (10.67.165.2) by
kwepemi500006.china.huawei.com (7.221.188.68) with Microsoft SMTP Server
(version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
15.1.2507.31; Tue, 17 Oct 2023 20:55:52 +0800
From: Junxian Huang <huangjunxian6@hisilicon.com>
To: <jgg@ziepe.ca>, <leon@kernel.org>
CC: <linux-rdma@vger.kernel.org>, <linuxarm@huawei.com>,
<linux-kernel@vger.kernel.org>, <huangjunxian6@hisilicon.com>
Subject: [PATCH for-rc 3/7] RDMA/hns: Fix signed-unsigned mixed comparisons
Date: Tue, 17 Oct 2023 20:52:35 +0800
Message-ID: <20231017125239.164455-4-huangjunxian6@hisilicon.com>
X-Mailer: git-send-email 2.30.0
In-Reply-To: <20231017125239.164455-1-huangjunxian6@hisilicon.com>
References: <20231017125239.164455-1-huangjunxian6@hisilicon.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7BIT
Content-Type: text/plain; charset=US-ASCII
X-Originating-IP: [10.67.165.2]
X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To
kwepemi500006.china.huawei.com (7.221.188.68)
X-CFilter-Loop: Reflected
X-Spam-Status: No,
score=-0.8 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on howler.vger.email
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-Greylist: Sender passed SPF test,
not delayed by milter-greylist-4.6.4 (howler.vger.email [0.0.0.0]);
Tue, 17 Oct 2023 05:56:41 -0700 (PDT)
X-getmail-retrieved-from-mailbox: INBOX
X-GMAIL-THRID: 1780007466460287108
X-GMAIL-MSGID: 1780007466460287108
|
| Series |
Bugfixes for hns RoCE
|
|
Commit Message
Junxian Huang
Oct. 17, 2023, 12:52 p.m. UTC
From: Chengchang Tang <tangchengchang@huawei.com> The ib_mtu_enum_to_int() and uverbs_attr_get_len() may returns a negative value. In this case, mixed comparisons of signed and unsigned types will throw wrong results. This patch adds judgement for this situation. Fixes: 30b707886aeb ("RDMA/hns: Support inline data in extented sge space for RC") Signed-off-by: Chengchang Tang <tangchengchang@huawei.com> Signed-off-by: Junxian Huang <huangjunxian6@hisilicon.com> --- drivers/infiniband/hw/hns/hns_roce_hw_v2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c index 2b8f6489ab3d..3daa684f8836 100644 --- a/drivers/infiniband/hw/hns/hns_roce_hw_v2.c +++ b/drivers/infiniband/hw/hns/hns_roce_hw_v2.c @@ -270,7 +270,7 @@ static bool check_inl_data_len(struct hns_roce_qp *qp, unsigned int len) struct hns_roce_dev *hr_dev = to_hr_dev(qp->ibqp.device); int mtu = ib_mtu_enum_to_int(qp->path_mtu); - if (len > qp->max_inline_data || len > mtu) { + if (mtu < 0 || len > qp->max_inline_data || len > mtu) { ibdev_err(&hr_dev->ib_dev, "invalid length of data, data len = %u, max inline len = %u, path mtu = %d.\n", len, qp->max_inline_data, mtu);