From patchwork Tue Oct 17 12:17:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Ilpo_J=C3=A4rvinen?= X-Patchwork-Id: 154225 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4091341vqb; Tue, 17 Oct 2023 05:18:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IES2wSbympgJ7C49GNU/OvyHlxkgFXw+xRK2Fl2+Mkqn8GoPP9IJm2qochIEA2LdDLPUrxW X-Received: by 2002:a05:6358:72a6:b0:166:d9c9:dbe with SMTP id w38-20020a05635872a600b00166d9c90dbemr2291012rwf.3.1697545109183; Tue, 17 Oct 2023 05:18:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697545109; cv=none; d=google.com; s=arc-20160816; b=ZeUq0dADQgZD0nIkEC+TqvPGcJpAg9dw/MmH1mDIzBn5+FM+sHZO4CcKqh55DQe5l8 R19mqYNXF2wGvt0In3tapQ69lU3zWVt4Hd89WRzQWf4jtt0MuE0S12W+9SHsicb9tt1L RFCvFkyLaOHJVIBJn41o0+Ld6vDgVPz/qrAx/anKrjYrnEwSZSHWTbOme2XJpMAtW+e8 Iwns91CBrVChlIF2yGYkXELiAdZBtKsnD6aj/PGzRNQI0DNRsURWOhZKI892Zzf+/LZy uqS1BzQnI4Ylzoyu9SGCXdEZ4jhVbpjSOubhGgjspzPJjxgz6OCgh9Nc86NXsPQGe/Jr BRpA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:to:from:dkim-signature; bh=CltTZF8jMoZTTgRnNw7OQ0wxmaxtoJDfFT7EBUQjYnQ=; fh=M9ocEYFn8yrZ266S4+clsyb25gK7oCq66+Q1PeHBTAw=; b=nqjfSjn1IuAbQUjsAibthc7mOKFYdrTb+2poXmhqhDvPw0B85AAFoHg8jN3eI/Hhlh 4XHyk/plh44FSw12ke0JwMVr6z3oJuHsMx79dh1ViIOBIsfXoXd/jMykuDCMYv/sYwBS GJRohv+uT//RuklMGMs213tlRwGYwFXjFM4vWyvdCZ5COARrRfa+a7YOUr7W2nkycIuv lVwomSdjwxFsvy8AI9lQdacDnqK4sb1BsgRiHh/V6z/0r9Vkig5gFylw3t34i8ay+LWh 7DOM+UbRrkEbWNZIE6rEICjDDS1GrIsj4Zw3VUt4AC8PW4M2fXaP/1lGB4zUaQXnP9sW o1dA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=agfXW489; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from lipwig.vger.email (lipwig.vger.email. [2620:137:e000::3:3]) by mx.google.com with ESMTPS id c30-20020a056a00009e00b0068a6f6d9f7dsi1487925pfj.57.2023.10.17.05.18.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:18:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) client-ip=2620:137:e000::3:3; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=agfXW489; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:3 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by lipwig.vger.email (Postfix) with ESMTP id 7362F8029861; Tue, 17 Oct 2023 05:18:26 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at lipwig.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235025AbjJQMSL (ORCPT + 19 others); Tue, 17 Oct 2023 08:18:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57742 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234143AbjJQMSE (ORCPT ); Tue, 17 Oct 2023 08:18:04 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E330186; Tue, 17 Oct 2023 05:18:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697545083; x=1729081083; h=from:to:subject:date:message-id:mime-version: content-transfer-encoding; bh=6E7Vvr30AXJewe66Dzx3EIvZeCNC2ARaF2V37Rds5vw=; b=agfXW4894t/WXv48CYorgOp9T3lJW3KfvLLqm6e8bmtQ4tpM6RmhUcaw XkKSWMiA6BQ42cq2STz84Wk5jDPLxEaqfhHqBF44MBCsarXYgkuCGIRuH ph/4nm0r6hkTrfStj0So9FUz5VZ0U2KpoAm1u7VV1n+wdLpvPOSLoOnuG jUPD568nhNi5bFMFuRaPD9ZbGJyRSrn2FkYwolCwuyRAvYwWqENsbcMwN 5icVkE7PALPdbZh3E26gKTarqCBaNNZNmHaRLulaPIEj/vWVc9CpQlW5T vOE3G13QiurGkMeyznHdfSgdS6NKl/1eBVfNV5D+rN9ZYzQ+jpNUhc37I A==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="416852632" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="416852632" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 05:18:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="846801368" X-IronPort-AV: E=Sophos;i="6.03,232,1694761200"; d="scan'208";a="846801368" Received: from thaimovx-mobl2.ger.corp.intel.com (HELO localhost) ([10.251.208.112]) by fmsmga003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 05:18:00 -0700 From: =?utf-8?q?Ilpo_J=C3=A4rvinen?= To: Fenghua Yu , Reinette Chatre , Shuah Khan , Maciej Wieczor-Retman , =?utf-8?q?Ilpo_J?= =?utf-8?q?=C3=A4rvinen?= , linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH 1/1] selftests/resctrl: Don't fail MBM test when schemata doesn't support MB:x=x line Date: Tue, 17 Oct 2023 15:17:50 +0300 Message-Id: <20231017121750.15433-1-ilpo.jarvinen@linux.intel.com> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lipwig.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (lipwig.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:18:26 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780005060494041478 X-GMAIL-MSGID: 1780005060494041478 Commit 20d96b25cc4c ("selftests/resctrl: Fix schemata write error check") exposed a problem in feature detection logic in MBM selftest. If schemata does not support MB:x=x entries, the schemata write to initialize 100% memory bandwidth allocation in mbm_setup() will now fail with -EINVAL due to the error handling corrected by 20d96b25cc4c. Commit 20d96b25cc4c just uncovers the failed write, it is not wrong itself. If MB:x=x is not supported by schemata, it is safe to assume 100% memory bandwidth is always set. Therefore, the previously ignored error does not make the MBM test itself wrong. Restore the previous behavior of MBM test by checking MB support before attempting to write it into schemata which results in behavior equivalent to ignoring the write error. Fixes: 20d96b25cc4c ("selftests/resctrl: Fix schemata write error check") Signed-off-by: Ilpo Järvinen Reviewed-by: Reinette Chatre --- tools/testing/selftests/resctrl/mbm_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/resctrl/mbm_test.c b/tools/testing/selftests/resctrl/mbm_test.c index d3c0d30c676a..85987957e7f5 100644 --- a/tools/testing/selftests/resctrl/mbm_test.c +++ b/tools/testing/selftests/resctrl/mbm_test.c @@ -95,7 +95,7 @@ static int mbm_setup(struct resctrl_val_param *p) return END_OF_TESTS; /* Set up shemata with 100% allocation on the first run. */ - if (p->num_of_runs == 0) + if ((p->num_of_runs == 0) && validate_resctrl_feature_request("MB", NULL)) ret = write_schemata(p->ctrlgrp, "100", p->cpu_no, p->resctrl_val);