[v3,53/73] pinctrl: intel: lynxpoint: drop the wrappers around pinctrl_gpio_direction_input()
Message ID | 20231017120431.68847-54-brgl@bgdev.pl |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4085753vqb; Tue, 17 Oct 2023 05:08:52 -0700 (PDT) X-Google-Smtp-Source: AGHT+IF/wQxXXGIJQID/l6i00tCCxgi8nCqVPUOdN8ShTiEyK4iRqSNsFlsTpBviSRyE5dWpeYBu X-Received: by 2002:a17:902:f092:b0:1bb:ac37:384b with SMTP id p18-20020a170902f09200b001bbac37384bmr2027735pla.6.1697544532437; Tue, 17 Oct 2023 05:08:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697544532; cv=none; d=google.com; s=arc-20160816; b=jlYqQcrh0/KlCW4xmXwtoH3zJF6Bf8eZcOScb0fSN71vuluygR/COqndjrEc/SkmBx 46Xr38orzGhpFy7FZenKhZ0yIC+YYOIYniEyvPp3FxgRucg265F+ILn+DdFTybwi+/2w 0nYCQ3hmMMljm3WpHTvxtbqTVq9oOYg9oEWNTUTfjdAhHqqIZWFd8ELDnrbCGgnPirrR hBfHQpwUguEtnz0UOv9pZ6TissRXhuBNIHf05hXOKiz6CIKhNrP8vUmqf14ZR4i8xM52 rr1HE5WmlV7dW9CitsIec/y6hQzlaTZhM/P33UdVHvEQKLuL8OVnssM342SkOS0maI3Z SLtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=IpzD63FKTnDkoNuJq4Z0rqQ6O9C3QSfgDXXMR4608kY=; fh=kOxmq+prcfKKX/dgMaMxTb6TRjzyc//QKXZBiaS/a94=; b=VOaMIQwHE2AEGfttx7WyuLHFSkQ+d2dTVF40vtoNSlB7bPKTFb9u2n64pmI8T7j8wh xaYXw/OvEIoTfpTURVb+lsJb7AoO+MtV9oXbI4ik/LHtHJxSqdY2EbwZbNFlwWA4gAVY XKshEDzeAQ3W3EblKdRrxE1oYh0bY3OmzsvZqGlWVW4U/gccLaylhE86XfTdEhw08F3e FRZBIww8vhFLYNHOF0Mkhm9UjsjCvHlsJrWal0mUvDP/opbTqevO7llHjj0UD08ebBkD WA0g5I6jKyD/i8LGGbx05MwEJ3h0OZsxcFzfiPTdXLjBTG/aPC+lpgurSGad2iEN1jHM Ug0Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=07QgEBSV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from snail.vger.email (snail.vger.email. [2620:137:e000::3:7]) by mx.google.com with ESMTPS id c4-20020a170902aa4400b001c76b4c349esi1595983plr.218.2023.10.17.05.08.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:08:52 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) client-ip=2620:137:e000::3:7; Authentication-Results: mx.google.com; dkim=pass header.i=@bgdev-pl.20230601.gappssmtp.com header.s=20230601 header.b=07QgEBSV; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:7 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by snail.vger.email (Postfix) with ESMTP id 6D88C801B73F; Tue, 17 Oct 2023 05:08:49 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at snail.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343833AbjJQMIf (ORCPT <rfc822;hjfbswb@gmail.com> + 19 others); Tue, 17 Oct 2023 08:08:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234956AbjJQMH1 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 17 Oct 2023 08:07:27 -0400 Received: from mail-wm1-x32f.google.com (mail-wm1-x32f.google.com [IPv6:2a00:1450:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 624CC2125 for <linux-kernel@vger.kernel.org>; Tue, 17 Oct 2023 05:05:41 -0700 (PDT) Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-406402933edso55836155e9.2 for <linux-kernel@vger.kernel.org>; Tue, 17 Oct 2023 05:05:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1697544339; x=1698149139; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IpzD63FKTnDkoNuJq4Z0rqQ6O9C3QSfgDXXMR4608kY=; b=07QgEBSVAhhSADoKzJRmmqC51TqHYqrlj8l0RkLHTIlnAAKJWd4vourKYo3Luqfu3T yy+4N8wczQHTuvFGjCfzCvQ3NXE8ablCvICit1QU5B4OTkVZZuDFJdNk/yPz3PvLQ0A5 WyvpvmtJwnsDiG9vDL3ph6QkH1teax/9xXcOicgORnJ6/1lzXOD/G3TsZWjfaOESUY+E bULrtbITrAnBancIIFmg2z7LhOhxilRSi9vmf+qcgeKPe3z4j+6C/kBGzxgzj+XpRCHy R+jkrH7dl7B9I/pcKfD/OA0ffVOZQ9P3kNod7Ih6LiAd1lxAdNewdYpH4+8gQY2kHlis Pg7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697544339; x=1698149139; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IpzD63FKTnDkoNuJq4Z0rqQ6O9C3QSfgDXXMR4608kY=; b=WdsRSz07SqqPLzaoLohxRJBV8RhL4yy/HmdY20PD+MwgQFpzR0YCzNekJKTUzn5krC wodvqdkre517It13tBWbR7pmC6At7B7s4PokHjBCHYpF5EvK9JOQzuqznRqmWy5OskzR MNFVtupklWwVXVi3mlrfXbFA5m0pMuqD88RUY1hS/Pqpa01lErVIVldqsV+FvOVnCm8k E1Rps0+KJSVA/T1/4+/lqZLFRXNEprkRs9hpH/yv9jAGCCOqXO3xLD17I+dGUnHrODS/ JKhQE1d9Mm0Kwr/YPWWQua9JASenshgOsO3KBCTkzBvZWHiPowcUvchyT1AYKqFTouxw m63A== X-Gm-Message-State: AOJu0YxOrlJGtRmGXrWvsA4BbhWWjWnVj63ApJ8MDCt7Lw/85Av8qe19 EKWmYvznsUIYJ9BhOgKhx8m+XA== X-Received: by 2002:a05:600c:a01:b0:405:3f19:fc49 with SMTP id z1-20020a05600c0a0100b004053f19fc49mr1487521wmp.34.1697544339820; Tue, 17 Oct 2023 05:05:39 -0700 (PDT) Received: from brgl-uxlite.home ([2a01:cb1d:334:ac00:f1ee:b000:ce90:ed14]) by smtp.gmail.com with ESMTPSA id a2-20020a05600c224200b00405442edc69sm1353859wmm.14.2023.10.17.05.05.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 05:05:39 -0700 (PDT) From: Bartosz Golaszewski <brgl@bgdev.pl> To: Linus Walleij <linus.walleij@linaro.org>, Andy Shevchenko <andriy.shevchenko@linux.intel.com> Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski <bartosz.golaszewski@linaro.org> Subject: [PATCH v3 53/73] pinctrl: intel: lynxpoint: drop the wrappers around pinctrl_gpio_direction_input() Date: Tue, 17 Oct 2023 14:04:11 +0200 Message-Id: <20231017120431.68847-54-brgl@bgdev.pl> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20231017120431.68847-1-brgl@bgdev.pl> References: <20231017120431.68847-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (snail.vger.email [0.0.0.0]); Tue, 17 Oct 2023 05:08:49 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1780004455445387508 X-GMAIL-MSGID: 1780004455445387508 |
Series |
pinctrl: don't use GPIOLIB global numberspace in helpers
|
|
Commit Message
Bartosz Golaszewski
Oct. 17, 2023, 12:04 p.m. UTC
From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> pinctrl_gpio_direction_input() now has the same signature as the wrappers around it so we can drop them. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> --- drivers/pinctrl/intel/pinctrl-lynxpoint.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)
Comments
On Tue, Oct 17, 2023 at 02:04:11PM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > pinctrl_gpio_direction_input() now has the same signature as the > wrappers around it so we can drop them. W/o "intel:" part in the Subj Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
On Tue, Oct 17, 2023 at 2:28 PM Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > > On Tue, Oct 17, 2023 at 02:04:11PM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org> > > > > pinctrl_gpio_direction_input() now has the same signature as the > > wrappers around it so we can drop them. > > W/o "intel:" part in the Subj > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Unless something new comes up, I'll fix this in tree in order to not spam the list anymore with these patch bombs. Bart > > -- > With Best Regards, > Andy Shevchenko > >
diff --git a/drivers/pinctrl/intel/pinctrl-lynxpoint.c b/drivers/pinctrl/intel/pinctrl-lynxpoint.c index e6878e4cf20c..303aaca341ea 100644 --- a/drivers/pinctrl/intel/pinctrl-lynxpoint.c +++ b/drivers/pinctrl/intel/pinctrl-lynxpoint.c @@ -539,11 +539,6 @@ static void lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int value) raw_spin_unlock_irqrestore(&lg->lock, flags); } -static int lp_gpio_direction_input(struct gpio_chip *chip, unsigned int offset) -{ - return pinctrl_gpio_direction_input(chip, offset); -} - static int lp_gpio_direction_output(struct gpio_chip *chip, unsigned int offset, int value) { @@ -799,7 +794,7 @@ static int lp_gpio_probe(struct platform_device *pdev) gc->owner = THIS_MODULE; gc->request = gpiochip_generic_request; gc->free = gpiochip_generic_free; - gc->direction_input = lp_gpio_direction_input; + gc->direction_input = pinctrl_gpio_direction_input; gc->direction_output = lp_gpio_direction_output; gc->get = lp_gpio_get; gc->set = lp_gpio_set;