Message ID | 20231017105341.415466-10-przemyslaw.kitszel@intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp4046654vqb; Tue, 17 Oct 2023 03:55:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmnFjkRImBaDw7LUvrmugol9B4KY9YrV3IItJt/DVrin4mJxQtAkp+ZTz3NQZHRF98epgS X-Received: by 2002:a05:6830:6a9b:b0:6b8:7653:dd66 with SMTP id da27-20020a0568306a9b00b006b87653dd66mr1966875otb.0.1697540148739; Tue, 17 Oct 2023 03:55:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697540148; cv=none; d=google.com; s=arc-20160816; b=Eu6b3aXIWRjJ9w1KV3qRwODZsPMi11rhI4XtXRzE20PHuTh6flsyev5hvXJpC2nAgC bmWQ+9I4g6fosV8cHpBftBEnDRM8sRnAGdUnV1WaJxzedADvwsnwQAMmAprAgSnkVck9 mL2govz13y3uxQ0tkft69K9bXt9mLsKT9Au/FkeWGVUmDQJmuh9WAPtn21sw4jA1+U8R uL6XuBjdXxQJ+fFbaXQezw/hr/hHwPMxxfG8bJhIo7WgmHUVFvL4CdRCOujSUzqxeLAh 6woyZxo9W5QqAjiweXuRItCrs2Xg6ZLQx6c6iVdxthwqjW+V3NhkHDFhMQ4cuYACEZ0d qHDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=369HuB2a+u/MIA/NsRH4rnlzL9bMDocDOgi/d1QE984=; fh=ra8hxhoqIUy+VJmNSvVkWWGIcW9PSd+mVEd/OcQHjSY=; b=M26VXTKIyF7UTXU8uQnvgkFWtxcaiwCNn0+ldutm3vcRamOH0MMcq7dyO6/VsRLaBs Tfwc7/0jw4Gvq8Bk+3bxxGWC8TrkSpcFC/8VI3mQ6uC+ELYSFlxB3tKChBW5nOZeAqhs drC0tjJ2Gka8hjxCyz48SDXEVNcxcHPk5AG7kpr8l2yCaN+TuAtt+y53HbZXWUhSlp9s Fq5oTs72KB6vh20GRbcY3jCt3DyIE2HCleTx8RvsFoSsg0uM1TXw8CNirgDz2Nzgp3mL P3fCpK/S+XiAECh8ddo8R4hpQmLKTuWmKj3KeWnO5vla3+Myl2q/j8a4Gt1eeyHEHpi+ rD1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d0BBFmqO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from fry.vger.email (fry.vger.email. [23.128.96.38]) by mx.google.com with ESMTPS id j3-20020a056a00174300b00690ffbb46e6si1377751pfc.261.2023.10.17.03.55.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 03:55:48 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) client-ip=23.128.96.38; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=d0BBFmqO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.38 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by fry.vger.email (Postfix) with ESMTP id CD76C80A0DD3; Tue, 17 Oct 2023 03:55:37 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at fry.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1343914AbjJQKzJ (ORCPT <rfc822;hjfbswb@gmail.com> + 19 others); Tue, 17 Oct 2023 06:55:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1343828AbjJQKyn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 17 Oct 2023 06:54:43 -0400 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.151]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7936410E; Tue, 17 Oct 2023 03:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1697540080; x=1729076080; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=3FHuzyM+tI/YYtEQt5RwYl7WHtkjbOPZEQMxcGD8fUk=; b=d0BBFmqOIElrxPgbUa28FVQuT8GRWiyp+8EjJOTCu1p0Xwpa8Yt0uhA4 ClxiH7bK5gLxVFMNMXZ4Az33vTPtJxMHpDCMOPA45hLHEIWc4iSehCanV WCvc9OjsH/Rer4HuLochrUDpMJ2q5SCtCRWRFYGik7BoJ3fxCN1GVMFCG 4+x3ApaK7T/7F2ZHfqCCP3vLRLijN526oUQGFbM1w80lzEpcxZKRfuee6 0764QIFADN14qdaX38jqSCLHKZIKWFWBrSbLUV+J7GsL0LxEvDU1lk9kW xR1vQC10UOqINQ9yz0NCH/U8rFrhtELxYGaOGUDfDmG0BasguudjZRV4L w==; X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="366012724" X-IronPort-AV: E=Sophos;i="6.03,231,1694761200"; d="scan'208";a="366012724" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Oct 2023 03:54:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10865"; a="785445352" X-IronPort-AV: E=Sophos;i="6.03,231,1694761200"; d="scan'208";a="785445352" Received: from irvmail002.ir.intel.com ([10.43.11.120]) by orsmga008.jf.intel.com with ESMTP; 17 Oct 2023 03:54:33 -0700 Received: from pelor.igk.intel.com (pelor.igk.intel.com [10.123.220.13]) by irvmail002.ir.intel.com (Postfix) with ESMTP id E9706312C0; Tue, 17 Oct 2023 11:54:30 +0100 (IST) From: Przemek Kitszel <przemyslaw.kitszel@intel.com> To: Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Shannon Nelson <shannon.nelson@amd.com>, Michael Chan <michael.chan@broadcom.com>, Cai Huoqing <cai.huoqing@linux.dev>, George Cherian <george.cherian@marvell.com>, Danielle Ratson <danieller@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>, Saeed Mahameed <saeedm@nvidia.com>, Ariel Elior <aelior@marvell.com>, Manish Chopra <manishc@marvell.com>, Igor Russkikh <irusskikh@marvell.com>, Coiby Xu <coiby.xu@gmail.com> Cc: Brett Creeley <brett.creeley@amd.com>, Sunil Goutham <sgoutham@marvell.com>, Linu Cherian <lcherian@marvell.com>, Geetha sowjanya <gakula@marvell.com>, Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>, Subbaraya Sundeep <sbhatta@marvell.com>, Ido Schimmel <idosch@nvidia.com>, Petr Machata <petrm@nvidia.com>, Eran Ben Elisha <eranbe@nvidia.com>, Aya Levin <ayal@mellanox.com>, Leon Romanovsky <leon@kernel.org>, linux-kernel@vger.kernel.org, Przemek Kitszel <przemyslaw.kitszel@intel.com> Subject: [PATCH net-next v2 09/11] qed: devlink health: use retained error fmsg API Date: Tue, 17 Oct 2023 12:53:39 +0200 Message-Id: <20231017105341.415466-10-przemyslaw.kitszel@intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20231017105341.415466-1-przemyslaw.kitszel@intel.com> References: <20231017105341.415466-1-przemyslaw.kitszel@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on fry.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (fry.vger.email [0.0.0.0]); Tue, 17 Oct 2023 03:55:37 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779999858994914518 X-GMAIL-MSGID: 1779999858994914518 |
Series |
devlink: retain error in struct devlink_fmsg
|
|
Commit Message
Przemek Kitszel
Oct. 17, 2023, 10:53 a.m. UTC
Drop unneeded error checking.
devlink_fmsg_*() family of functions is now retaining errors,
so there is no need to check for them after each call.
Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
---
add/remove: 0/0 grow/shrink: 0/1 up/down: 0/-2 (-2)
---
drivers/net/ethernet/qlogic/qed/qed_devlink.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/qlogic/qed/qed_devlink.c b/drivers/net/ethernet/qlogic/qed/qed_devlink.c index be5cc8b79bd5..dad8e617c393 100644 --- a/drivers/net/ethernet/qlogic/qed/qed_devlink.c +++ b/drivers/net/ethernet/qlogic/qed/qed_devlink.c @@ -66,12 +66,12 @@ qed_fw_fatal_reporter_dump(struct devlink_health_reporter *reporter, return err; } - err = devlink_fmsg_binary_pair_put(fmsg, "dump_data", - p_dbg_data_buf, dbg_data_buf_size); + devlink_fmsg_binary_pair_put(fmsg, "dump_data", p_dbg_data_buf, + dbg_data_buf_size); vfree(p_dbg_data_buf); - return err; + return 0; } static int