Message ID | 2023101709-amuck-upward-46f1@gregkh |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3974355vqb; Tue, 17 Oct 2023 01:13:37 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEMHXA6bFvz0T+7Vb/RCyIqonCbCbaRsAanuHBgljQbxxj6roB235VGFAu11VmtYFPRhP9v X-Received: by 2002:a05:6a00:1d09:b0:6bc:ff89:a2fc with SMTP id a9-20020a056a001d0900b006bcff89a2fcmr1554012pfx.2.1697530417541; Tue, 17 Oct 2023 01:13:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1697530417; cv=none; d=google.com; s=arc-20160816; b=LH0YgN9c/3vlzfySz+O48besKl6UaN8p1G77kMwg+HzgTxvGxhpn0SIregyd3xGsLM sZChjCDlNGyeJJkz0EU5CHtXln+hu8Tz9JESJoZKj45lL7kyTu171DEee6XiY0uHzgJs oBbGmaCe/NRdiRBjBw74bqRigyF5kNfr1prwxN+F2BM3F8dlhDGuEI6JdyVsQx+S/Ct7 R8C7qAdF+J7a+2QCSMHXUtNGeSt8HBRfvmRldklYhgM6W0qeKs5isA6nfHw50y0YzrKm MI7JXjtS8NLIyoXQJST5JeFQu584L/1r7jURClccS6zWyq+x5Bkxws0viBvSSdkMWSD+ TEMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:lines:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=0zOoe/uy9CrYqSgQm+jaTnFsyTXTtZKWozUcpbvoCpU=; fh=sqmsQHvPh+sAMP+kZKdm//PkmBtjIYOuPiCd6FE75Mk=; b=ZetqalBn/GCX0VcVr5IEE5l8eomQgo4oTrEcygrMP/dEBN4FlT9Os+uEVtwkmmoR/x aTqfQiyl6bX3jRwYseabPrKv8d7NEHzCD5m6lDaW3fc56SBD+rJBark0Xj6bfEFODzG3 I13UmJSUXD1FExywOEz2z197XgG4n/cy8e29rKtnjefflcZvJMI+/Vaw+pNcdQRBUCuZ Q8Pu/iTDcD8HWN7KnPW+plU7JrjyzXAInCJf9DBC7jdInGPWGllzFQqa5B9P0EuDqh4p rP69sEfDPRGdcJIt1YEhRfi7EQArVwNYsqMStY78Uc7dl2K2QfhV/M7cz+bj/Ct4dFro RQjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PbwrsftL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from groat.vger.email (groat.vger.email. [2620:137:e000::3:5]) by mx.google.com with ESMTPS id u204-20020a6279d5000000b00690d695b113si1083820pfc.337.2023.10.17.01.13.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Oct 2023 01:13:37 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) client-ip=2620:137:e000::3:5; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=PbwrsftL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:5 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by groat.vger.email (Postfix) with ESMTP id 71B2B8087FDC; Tue, 17 Oct 2023 01:13:35 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at groat.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234642AbjJQINa (ORCPT <rfc822;hjfbswb@gmail.com> + 19 others); Tue, 17 Oct 2023 04:13:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37408 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234639AbjJQIN3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 17 Oct 2023 04:13:29 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C2F02E8 for <linux-kernel@vger.kernel.org>; Tue, 17 Oct 2023 01:13:26 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1225AC433C8; Tue, 17 Oct 2023 08:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1697530406; bh=46LFzxJ8kVX8In6gN8/8l3XSFq9NXQixEzzsEgPJrZI=; h=From:To:Cc:Subject:Date:From; b=PbwrsftLLcm9eKRbpFoh1Xo1EVbsmerWJ7QUrWDhUzstBQtj4BXm8dscZkc9KbtS7 p+6wmy534ZJEdBP4PsSK5Qf1zm4rYF8eDbM358IwHNGD1yRTyA0CKMjUKYjlfKEhpF ZUhBub3R+RYdT3YKlIBHeC5vHThTHtdKj9wtLN/g= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-staging@lists.linux.dev Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Thorsten Leemhuis <linux@leemhuis.info>, Philipp Hortmann <philipp.g.hortmann@gmail.com>, Arnd Bergmann <arnd@arndb.de> Subject: [PATCH] staging: rtl8192u: remove entry from Makefile Date: Tue, 17 Oct 2023 10:13:10 +0200 Message-ID: <2023101709-amuck-upward-46f1@gregkh> X-Mailer: git-send-email 2.42.0 MIME-Version: 1.0 Lines: 31 X-Developer-Signature: v=1; a=openpgp-sha256; l=1187; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=46LFzxJ8kVX8In6gN8/8l3XSFq9NXQixEzzsEgPJrZI=; b=owGbwMvMwCRo6H6F97bub03G02pJDKl6TqJebl+2HHpdV39+YSRnb33SqT8u+sdnx/Avt0nIy tvwXKOnI5aFQZCJQVZMkeXLNp6j+ysOKXoZ2p6GmcPKBDKEgYtTACaSxsYwz0hY4Pa6qMf71d7U aJRvet/EFX5/NsOCGbfEZp23bXOaNaX9JefSreYzNeXUAQ== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on groat.vger.email Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (groat.vger.email [0.0.0.0]); Tue, 17 Oct 2023 01:13:35 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779989654990959826 X-GMAIL-MSGID: 1779989654990959826 |
Series |
staging: rtl8192u: remove entry from Makefile
|
|
Commit Message
Greg KH
Oct. 17, 2023, 8:13 a.m. UTC
In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the
driver was removed, along with the Kconfig entry, but the Makefile line
in drivers/staging/Makefile was not updated, so things like 'make clean'
fail to work properly as they will decend into all subdirectories to try
to clean things up.
Resolve this by removing the entry in the main staging Makefile.
Reported-by: Thorsten Leemhuis <linux@leemhuis.info>
Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver")
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
drivers/staging/Makefile | 1 -
1 file changed, 1 deletion(-)
Comments
On 17.10.23 10:13, Greg Kroah-Hartman wrote: > In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the > driver was removed, along with the Kconfig entry, but the Makefile line > in drivers/staging/Makefile was not updated, so things like 'make clean' > fail to work properly as they will decend into all subdirectories to try > to clean things up. > > Resolve this by removing the entry in the main staging Makefile. > > Reported-by: Thorsten Leemhuis <linux@leemhuis.info> > Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver") > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Thx Greg, that fixed things for my case. In case anyone cares: Tested-by: Thorsten Leemhuis <linux@leemhuis.info> Ciao, Thorsten
On Tue, Oct 17, 2023 at 12:35:57PM +0200, Thorsten Leemhuis wrote: > On 17.10.23 10:13, Greg Kroah-Hartman wrote: > > In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the > > driver was removed, along with the Kconfig entry, but the Makefile line > > in drivers/staging/Makefile was not updated, so things like 'make clean' > > fail to work properly as they will decend into all subdirectories to try > > to clean things up. > > > > Resolve this by removing the entry in the main staging Makefile. > > > > Reported-by: Thorsten Leemhuis <linux@leemhuis.info> > > Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com> > > Cc: Arnd Bergmann <arnd@arndb.de> > > Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver") > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > Thx Greg, that fixed things for my case. In case anyone cares: I care, thanks!
On 10/17/23 15:35, Greg Kroah-Hartman wrote: > On Tue, Oct 17, 2023 at 12:35:57PM +0200, Thorsten Leemhuis wrote: >> On 17.10.23 10:13, Greg Kroah-Hartman wrote: >>> In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the >>> driver was removed, along with the Kconfig entry, but the Makefile line >>> in drivers/staging/Makefile was not updated, so things like 'make clean' >>> fail to work properly as they will decend into all subdirectories to try >>> to clean things up. >>> >>> Resolve this by removing the entry in the main staging Makefile. >>> >>> Reported-by: Thorsten Leemhuis <linux@leemhuis.info> >>> Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com> >>> Cc: Arnd Bergmann <arnd@arndb.de> >>> Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver") >>> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >> >> Thx Greg, that fixed things for my case. In case anyone cares: > > I care, thanks! Sorry for messing up. I did a compile test of the entire kernel but I was not aware that I also need to test 'make clean' Bye Philipp
On Tue, Oct 17, 2023 at 08:07:33PM +0200, Philipp Hortmann wrote: > On 10/17/23 15:35, Greg Kroah-Hartman wrote: > > On Tue, Oct 17, 2023 at 12:35:57PM +0200, Thorsten Leemhuis wrote: > > > On 17.10.23 10:13, Greg Kroah-Hartman wrote: > > > > In commit 697455ce4110 ("staging: rtl8192u: Remove broken driver"), the > > > > driver was removed, along with the Kconfig entry, but the Makefile line > > > > in drivers/staging/Makefile was not updated, so things like 'make clean' > > > > fail to work properly as they will decend into all subdirectories to try > > > > to clean things up. > > > > > > > > Resolve this by removing the entry in the main staging Makefile. > > > > > > > > Reported-by: Thorsten Leemhuis <linux@leemhuis.info> > > > > Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com> > > > > Cc: Arnd Bergmann <arnd@arndb.de> > > > > Fixes: 697455ce4110 ("staging: rtl8192u: Remove broken driver") > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > > > Thx Greg, that fixed things for my case. In case anyone cares: > > > > I care, thanks! > > > Sorry for messing up. I did a compile test of the entire kernel but I was > not aware that I also need to test 'make clean' Not a problem, I didn't either, and neither did the 0-day bot. greg k-h
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile index ffa70dda481d..0f6379436443 100644 --- a/drivers/staging/Makefile +++ b/drivers/staging/Makefile @@ -4,7 +4,6 @@ obj-y += media/ obj-$(CONFIG_PRISM2_USB) += wlan-ng/ obj-$(CONFIG_FB_OLPC_DCON) += olpc_dcon/ -obj-$(CONFIG_RTL8192U) += rtl8192u/ obj-$(CONFIG_RTL8192E) += rtl8192e/ obj-$(CONFIG_RTL8723BS) += rtl8723bs/ obj-$(CONFIG_R8712U) += rtl8712/