From patchwork Tue Oct 17 00:23:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Moger, Babu" X-Patchwork-Id: 153829 Return-Path: Delivered-To: ouuuleilei@gmail.com Received: by 2002:a05:612c:2908:b0:403:3b70:6f57 with SMTP id ib8csp3808872vqb; Mon, 16 Oct 2023 17:24:26 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFLSxmc4WBqJKV3EBFKN4z6BXXWorcwwyg2YjH1bjZRSRbLJd4x8raapwIQYHKNJGvu7ju/ X-Received: by 2002:a05:6a21:a5a0:b0:17a:e03f:38b7 with SMTP id gd32-20020a056a21a5a000b0017ae03f38b7mr718530pzc.6.1697502266186; Mon, 16 Oct 2023 17:24:26 -0700 (PDT) ARC-Seal: i=2; a=rsa-sha256; t=1697502266; cv=pass; d=google.com; s=arc-20160816; b=oNzkajBHhAB4QQ5SN9j2msBketS+aQ579Wh8AaftVXlS/iRlXy+hcZTT5mfM8/U45D 3hNwV3K4EZe3vDoxDbOpWgrxeEIrQdAyDxrIfp5uVXr5MfAWw6cLDGVlbr1PG4s5fFiG Qqs4cE4Exf5An71Tef+7um8QO4RMKm9FBIWgj+8XV5LdPlhzWVv1EHz98s34FPqIoOlf 2Yt0Ve13kZQePL+dZ8HZ9HnVjzIn6+r28TbDxQzyB3f8ZZI7KOxjKtmf0omv+taNnYgE APbrmqVF4G11zwpuHFPo0an5e0ajbsRINHvlsEI9AyFSLvT0F54FliE0ZIZSPuYeqFA/ Pcug== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=WY9Q1XGjovX2NbFwxDDwTA7B7ZrS4TCO4WC9VQcHadI=; fh=a8QQDpsyeps30vd5Li+WI6v6dtcd7xKVvftia9bksQM=; b=hC0Uy4owpSvxabLBbKNcZsmKxUor2/x3jcQIsLCrwxoSS+N+fWZhH2pa60b1pNMyz9 qXItFXB32F6SppQ3zFAInOBjAQXk5/Wt7xQ6C6M5sisM4/DWwm3zGMB01rJg5doApqL9 idl819RgzePNT1RPnssXW+LyITt9tOHMJYBUiG7tMctoVia5BHYbNYwJ7AY79oCB0su7 RRClHxwUmHoLQ3zsW/9POBRZ4y+iMb2KWR0ih4GQrwNa+G2aTYQy2mnU9B2Yq6ekUcFV 9HqYQaBpnMliR8vLcIW7n0kPE4LsDRP2w+klGoBLRB0U9pqjA4aa0fKkdYTYGI9qAak9 Az2A== ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=TwJNw4k1; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from morse.vger.email (morse.vger.email. [2620:137:e000::3:1]) by mx.google.com with ESMTPS id bx25-20020a056a02051900b00565f182839asi611879pgb.28.2023.10.16.17.24.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Oct 2023 17:24:26 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) client-ip=2620:137:e000::3:1; Authentication-Results: mx.google.com; dkim=pass header.i=@amd.com header.s=selector1 header.b=TwJNw4k1; arc=pass (i=1 spf=pass spfdomain=amd.com dmarc=pass fromdomain=amd.com); spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::3:1 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=amd.com Received: from out1.vger.email (depot.vger.email [IPv6:2620:137:e000::3:0]) by morse.vger.email (Postfix) with ESMTP id 4EC468042D09; Mon, 16 Oct 2023 17:24:24 -0700 (PDT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 0.103.10 at morse.vger.email Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234379AbjJQAYM (ORCPT + 18 others); Mon, 16 Oct 2023 20:24:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56154 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234311AbjJQAYB (ORCPT ); Mon, 16 Oct 2023 20:24:01 -0400 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2067.outbound.protection.outlook.com [40.107.101.67]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DD5B116; Mon, 16 Oct 2023 17:23:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fwEAAh8vnAJ6d1FDSQvEMWdzL4zxKFXt/RxeejirlANnShvyW1NGQhO4IS+sdMlrEK0jYONUE4hEo/YJmOXbqc+VIUmYJSvg+JgqKFMRjMK6kqQPqRMnvJ2r2neygwjKL45PcYwo07zIMUXuD6wZVd3qAebqs8SU/ctM0vrohY8iNVAlQ/MWFXjMH7JS5oeDE4gLo5nCIyKohltCAPGytZMpyj9ZIKgHXyQeCYQN2KWGomCpN9vkhKMEgz4wC8sNWJlVRyvWmiBub0FF/RhcTZGHk63BePjU3aL6f0W5oFdbesF+IjdHOZjxB5Ft1LEqapZIo5fxXX32m1320EWc6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=WY9Q1XGjovX2NbFwxDDwTA7B7ZrS4TCO4WC9VQcHadI=; b=H07kH2OuSVYI7YGEfzVKkPTmP+yBR1DPANPn3ctMTdcah0gMXCQV5QMSwcCiooBUgIZTwoso/h0yAB2CJ7IQYKe6smgwnVRkhVHTiYVLX2JpxWbaFZkattROUPO/ToFdM+1BkDCK/dqsBkZjga6nogAtG/jUzVfkubig0dGFFo2jjRbQKJydzKN6vJF3GIJWmd6rCmkHJ50Tk1GHBx7rp5NSkqoGPzoPZ9ebMeAhT0BbY3bldrqWIDuBokp70Fz5UrbmEWjhwzTMqYJzH8ksvul+9kAQn8nySVGG3NrNfhGro7euq6EQgiChjQSsIArxZ7zRFYu9nP4ZM9Ur9TEoBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lwn.net smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=WY9Q1XGjovX2NbFwxDDwTA7B7ZrS4TCO4WC9VQcHadI=; b=TwJNw4k1yE0SKywTIcNpzFF5WJygZ1l4uapTiTOhQ5arcFzGF+CEWSAwbI3CmGL0RvCBNpS2OO0a9kKUcZl8jSc0go9GBCmK+cT+narpQUcNPdAc0o8OCPTm8rx7aT+SQEXurC4+kM6UABlDG5qI8TKBIrIT27CUNndULOWi7jA= Received: from MW4PR04CA0132.namprd04.prod.outlook.com (2603:10b6:303:84::17) by IA0PR12MB8352.namprd12.prod.outlook.com (2603:10b6:208:3dd::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6863.46; Tue, 17 Oct 2023 00:23:42 +0000 Received: from MWH0EPF000989E5.namprd02.prod.outlook.com (2603:10b6:303:84:cafe::3d) by MW4PR04CA0132.outlook.office365.com (2603:10b6:303:84::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6886.35 via Frontend Transport; Tue, 17 Oct 2023 00:23:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by MWH0EPF000989E5.mail.protection.outlook.com (10.167.241.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6907.20 via Frontend Transport; Tue, 17 Oct 2023 00:23:42 +0000 Received: from bmoger-ubuntu.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Mon, 16 Oct 2023 19:23:39 -0500 From: Babu Moger To: , , , , CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: [PATCH v14 8/9] x86/resctrl: Add support for the files for MON groups only Date: Mon, 16 Oct 2023 19:23:07 -0500 Message-ID: <20231017002308.134480-9-babu.moger@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231017002308.134480-1-babu.moger@amd.com> References: <20231017002308.134480-1-babu.moger@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MWH0EPF000989E5:EE_|IA0PR12MB8352:EE_ X-MS-Office365-Filtering-Correlation-Id: 2c177fba-5e2c-4b18-e949-08dbcea75179 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: nbg3F92Qd/XamYnFM7/4Ip0AyjjAoxhuFtQx6pZqo05+GSnleiEjCYWQg00MWpo0vBd7TtJOkLgcqboJrljMTVrzlmEB7ydbiXxvjgEPLtj95t6atHe0wx2nLa1ijzi51CF3N0rBPuc/YWG40e8pNbE4OcS9NRhDuUo3nNppjkmYQpaC8BacuR1A/CRU/vPwl7uHJAI3FDP5jOqf9nDaCi/oRBwiQ8jpLBUnuyVXcn5ECTHRptCgSvLmhuIqRSrYr//utw5scOFHKJ8XFAUvlKBdMy6yVQGgPNLSUD9/Kn8dxUtOBKwcMcdnxx89hpbih399GQXbyuEQyIT5fO6Hu+mcL4vs3OkFY6w6mO+IQN6bT1XePlgdz0AmwoY7WFTPvDQW2h5ChhQNFXO+nOORI8B+QBVsmibKDw1FLC2ASzque9regbpritHw5zYkD4konu2yMHZzx0RHsxDxUK4V7zohF5Ffp5LcdIG+K51NqfBF6ECaZxJR87GKmge8GS0kaKVDcAI+YRd2OzzasTz/ROAaMNDVmsZCbX/dxixhH1W1cVYkTqKZbBqi0VQa3SxarWXZ/tUry5KF8ux97GjKSftCfFm+DmWrXD8v7Ft6Iy70XmQLTvEQcpf/1vEuZbGhJyt29nTdyac8jaEitvI17DIWyyvQJXU+2gmLFkvyQJ9PyQd6e4cwKnRNEAoa9/h4ELki0GJ4phcxKDrVu5yRhm9ezoplTaW/ABQGCy7zIPT3XghNtjijUp/Srts4h6le8XOu0ctxxWDtLQU92+NKiA== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:SATLEXMB04.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230031)(4636009)(376002)(39860400002)(396003)(136003)(346002)(230922051799003)(1800799009)(451199024)(186009)(82310400011)(64100799003)(36840700001)(40470700004)(46966006)(478600001)(6666004)(356005)(81166007)(7696005)(2906002)(82740400003)(26005)(36860700001)(86362001)(110136005)(40460700003)(7406005)(7416002)(70206006)(70586007)(47076005)(54906003)(316002)(4326008)(66574015)(16526019)(1076003)(2616005)(8676002)(40480700001)(336012)(83380400001)(36756003)(426003)(8936002)(5660300002)(44832011)(41300700001)(36900700001);DIR:OUT;SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Oct 2023 00:23:42.3455 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2c177fba-5e2c-4b18-e949-08dbcea75179 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MWH0EPF000989E5.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8352 X-Spam-Status: No, score=-0.9 required=5.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on morse.vger.email Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.6.4 (morse.vger.email [0.0.0.0]); Mon, 16 Oct 2023 17:24:24 -0700 (PDT) X-getmail-retrieved-from-mailbox: INBOX X-GMAIL-THRID: 1779960136266985579 X-GMAIL-MSGID: 1779960136266985579 Files unique to monitoring groups have the RFTYPE_MON flag. When a new monitoring group is created the resctrl files with flags RFTYPE_BASE (files common to all resource groups) and RFTYPE_MON (files unique to monitoring groups) are created to support interacting with the new monitoring group. A resource group can support both monitoring and control, also termed a CTRL_MON resource group. CTRL_MON groups should get both monitoring and control resctrl files but that is not the case. Only the RFTYPE_BASE and RFTYPE_CTRL files are created for CTRL_MON groups. Ensure that files with the RFTYPE_MON flag are created for CTRL_MON groups. Signed-off-by: Babu Moger Tested-by: Peter Newman Reviewed-by: Peter Newman Tested-by: Tan Shaopeng Reviewed-by: Tan Shaopeng Reviewed-by: Fenghua Yu Reviewed-by: Ilpo Järvinen Reviewed-by: Reinette Chatre --- v14: No changes v13: Commit message update(adds a blank line). (Reinette) v12: Removed the comments about the later patch. The text is moved to patch 10. (Boris) --- arch/x86/kernel/cpu/resctrl/rdtgroup.c | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/x86/kernel/cpu/resctrl/rdtgroup.c b/arch/x86/kernel/cpu/resctrl/rdtgroup.c index 5814a0bf3cea..5f6d6ba63a2e 100644 --- a/arch/x86/kernel/cpu/resctrl/rdtgroup.c +++ b/arch/x86/kernel/cpu/resctrl/rdtgroup.c @@ -2551,6 +2551,7 @@ static void schemata_list_destroy(void) static int rdt_get_tree(struct fs_context *fc) { struct rdt_fs_context *ctx = rdt_fc2context(fc); + unsigned long flags = RFTYPE_CTRL_BASE; struct rdt_domain *dom; struct rdt_resource *r; int ret; @@ -2581,7 +2582,10 @@ static int rdt_get_tree(struct fs_context *fc) closid_init(); - ret = rdtgroup_add_files(rdtgroup_default.kn, RFTYPE_CTRL_BASE); + if (rdt_mon_capable) + flags |= RFTYPE_MON; + + ret = rdtgroup_add_files(rdtgroup_default.kn, flags); if (ret) goto out_schemata_free; @@ -3271,8 +3275,8 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn, enum rdt_group_type rtype, struct rdtgroup **r) { struct rdtgroup *prdtgrp, *rdtgrp; + unsigned long files = 0; struct kernfs_node *kn; - uint files = 0; int ret; prdtgrp = rdtgroup_kn_lock_live(parent_kn); @@ -3324,10 +3328,13 @@ static int mkdir_rdt_prepare(struct kernfs_node *parent_kn, goto out_destroy; } - if (rtype == RDTCTRL_GROUP) + if (rtype == RDTCTRL_GROUP) { files = RFTYPE_BASE | RFTYPE_CTRL; - else + if (rdt_mon_capable) + files |= RFTYPE_MON; + } else { files = RFTYPE_BASE | RFTYPE_MON; + } ret = rdtgroup_add_files(kn, files); if (ret) {